summaryrefslogtreecommitdiff
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #7083 from chef/btm/fix-windows-serviceTim Smith2018-03-291-8/+9
|\ | | | | Avoid lookups for rights of 'LocalSystem' in windows service
| * Avoid lookups for rights of 'LocalSystem' in windows serviceBryan McLellan2018-03-291-8/+9
| | | | | | | | | | | | | | | | | | | | LocalSystem is a special account for the service subsystem, and the security subsystem doesn't know about it. It inherits rights from BUILTIN\Administrators so we don't need to check it for SeServiceLogonRight. Even if we look up System it wouldn't show up as it gets that right from hidden membership in BUILTIN\Administrators. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
* | Merge pull request #7079 from chef/case_insensitve_dismTim Smith2018-03-281-5/+5
|\ \ | |/ |/| windows_feature_dism: Be case insensitive with feature names
| * Keep case sensitivity on Windows < 2012case_insensitve_dismTim Smith2018-03-281-1/+1
| | | | | | | | | | | | Dism here does not support case insensitive feature installs. This isn't a user behavior change sine they always needed the feature to have the right case here. Signed-off-by: Tim Smith <tsmith@chef.io>
| * windows_feature_dism: Be case insensitive with feature namesTim Smith2018-03-271-5/+5
| | | | | | | | | | | | | | | | | | We took what they user gave us and compared it to the list of available packages from dism.exe. In doing so we were case sensitive, but the CLI doesn't actually care. This just downcases what the user gives us and what dism gives us so it doesn't matter. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #7037 from chef/lcg/nil-sets-defaultThom May2018-03-281-4/+51
|\ \ | |/ |/| Setting nil to properties with implicit nil sets default value
| * Setting nil to properties with implicit nil sets default valueLamont Granquist2018-03-221-4/+51
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - This makes converting core resources to properties safer - This makes it easier to apply wrapping properties to subresources property :foo, String, default: "foo" This is where the change lies, and writing a nil here will now actually write a "foo" to the variable. property :foo, [ String, nil ], default: "foo" This is unchanged. Writing nil writes nil. property :foo, String Technically this is changed, since it writes the default value, but since nil.equal?(nil) in a very deep way no behavior changes. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Fix array parsing in windows_feature_dism / windows_feature_powershellfix_dismTim Smith2018-03-272-4/+24
| | | | | | | | | | | | | | | | | | | | This fixes how we parse out the arrays and adds testing to make sure it's doing what we want. Plus it properly continues on when the user has removed all local feature but specified an external source of those via the registry. That was a reported issue that came in on the cookbook after the rewrite. Lastly this also fixes a bad method call to the dism method that came over when diffing from the cookbook. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #7050 from chef/tm/deprecated_propertiesTim Smith2018-03-261-0/+24
|\ \ | | | | | | RFC-102: Deprecation warning in resources
| * | RFC-102: Deprecation warning in resourcestm/deprecated_propertiesThom May2018-03-241-0/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * `deprecated_property_alias` allows the resource author to provide transition from old properties to new ones with a deprecation warning. * The `deprecated` option on a property emits a deprecation warning. * The `deprecated` method on a resource takes a message, but does not yet emit a deprecation warning. Signed-off-by: Thom May <thom@chef.io>
* | | mechanical conversion of most debug log statements to traceThom May2018-03-2626-113/+157
| | | | | | | | | | | | Signed-off-by: Thom May <thom@chef.io>
* | | ensure that providers inherit loggers from the run contextThom May2018-03-268-16/+20
| | | | | | | | | | | | Signed-off-by: Thom May <thom@chef.io>
* | | Merge pull request #7048 from chef/fix_windows_pagefileTim Smith2018-03-241-5/+5
|\ \ \ | | | | | | | | Remove path helpers from window_pagefile
| * | | Remove path helpers from window_pagefileTim Smith2018-03-231-5/+5
| |/ / | | | | | | | | | | | | | | | I backported locate_sysnative_cmd initially, but after chatting with Stuart this isn't something we need anymore. This removes it and instead uses wmic.exe directly, which in testing works just fine. This also removes the windows friendly path helper which is really just a gsub on the slashes. Instead I changed the coerce to get us what we need in terms of path formats. I copied this to a Windows 2016 box and it works fine with both formats of paths. I'm making this same change to the windows cookbook. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Add swap_file resource form the swap cookbookTim Smith2018-03-231-0/+40
|/ / | | | | | | | | | | Copied as-is from the cookbook Signed-off-by: Tim Smith <tsmith@chef.io>
* | Rename to windows_ad_joinTim Smith2018-03-221-2/+2
| | | | | | | | | | | | This allows us to have windows_ad_* in the future Signed-off-by: Tim Smith <tsmith@chef.io>
* | Require the domain_name to be a FQDNTim Smith2018-03-221-0/+4
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* | Handle reboots in Chef and provide finer grained control of behaviorTim Smith2018-03-221-0/+7
| | | | | | | | | | | | Rename the property to reboot to align with Chef naming. Allow delayed, immediate, or never for reboot actions. Using the actions from reboot was pretty confusing so I used notification names which seems to lineup nicely. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Add windows_adjoin resourceTim Smith2018-03-221-0/+34
| | | | | | | | | | | | Copied with permission from John Snow's win_ad cookbook. It's been reworked to not mess with dns servers and use powershell_out + sensitive. Some of those changes are getting pushed upstream, but the name is different and there's no expectation of compatibility here. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #7022 from chef/sysctlTim Smith2018-03-221-0/+56
|\ \ | | | | | | Add sysctl_param resource from the sysctl cookbook
| * | Rename systctl_param to sysctlTim Smith2018-03-211-4/+4
| | | | | | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * | Add sysctl_param resource from the sysctl cookbookTim Smith2018-03-211-0/+56
| | | | | | | | | | | | | | | | | | Copied from the cookbook with modifications made there Signed-off-by: Tim Smith <tsmith@chef.io>
* | | sudo: Don't fail on FreeBSD. Turns out there's a .d directoryTim Smith2018-03-221-0/+5
| | | | | | | | | | | | | | | | | | I guess they use .d directory structures in sudo, but that's about it. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Fix the openssl resource spec namesfix_spec_namesTim Smith2018-03-212-0/+0
| |/ |/| | | | | | | | | Simple rename Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #7023 from chef/lcg/rubocop-fixesLamont Granquist2018-03-213-3/+3
|\ \ | | | | | | rubocop fixes from engine bump to 0.54.0
| * | rubocop fixes from engine bump to 0.54.0lcg/rubocop-fixesLamont Granquist2018-03-213-3/+3
| |/ | | | | | | | | | | some cops got a little stricter. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Merge pull request #7016 from chef/tm/chef_guidThom May2018-03-215-1/+68
|\ \ | |/ |/| Save the node's UUID as an attribute
| * Save the node's UUID as an attributetm/chef_guidThom May2018-03-215-1/+68
| | | | | | | | | | | | | | We generate the UUID as part of the data collector report, but we didn't make that available to the node or the chef server otherwise. Signed-off-by: Thom May <thom@chef.io>
* | Update to the code from the homebrew 9.0 cookbookTim Smith2018-03-203-5/+75
| | | | | | | | | | | | This converts the Chef resources to shell_out and adds new properties for dealing with edge case installations. It also adds validation messaging / testing and lazy evals the stuff that uses the mixin. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Add dmg_package, homebrew_cask, and homebrew_tap resourcesTim Smith2018-03-201-0/+35
| | | | | | | | | | | | Pull in resources from the dmg and homebrew cookbooks Signed-off-by: Tim Smith <tsmith@chef.io>
* | Remove Chef 12-isms from the apt_repository resourceTim Smith2018-03-201-3/+34
| | | | | | | | | | | | We set a lot of nil defaults and did coersions here that are no longer necessary. Since we did accept nil in a lot of these properties at one point we need to keep it so I wrote a note to future me about that. I also added some specs for the remaining coersion and the defaults. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #7000 from chef/repo_filenamesTim Smith2018-03-203-0/+12
|\ \ | | | | | | Fail with a warning if users specify apt/yum/zypper repos with slashes
| * | Fail with a warning if users specify apt/yum/zypper repos with slashesrepo_filenamesTim Smith2018-03-193-0/+12
| | | | | | | | | | | | | | | | | | We can't write out a filename like foo/bar.repo so we should properly warn the user if they try to give us that. There's probably other things, but this one makes particular sense for apt since people want to use the slash in PPA repo names. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Detect new "automatically" installed string in ZypperTim Smith2018-03-191-0/+8
|/ / | | | | | | | | | | | | | | | | | | This resolves issue #6836 which explains the issue in great detail. TLDR: Packages that are installed as deps on another package have a different string when you get info on them now. This updates the regex to detect both. Based on the zypper changelog I believe this was introduced in 1.13.17. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Add the ability to inject log objectstm/inject_logThom May2018-03-198-24/+27
| | | | | | | | | | | | meaning that we can have inheritable metadata Signed-off-by: Thom May <thom@chef.io>
* | Merge pull request #6995 from chef/btm/fix-lsa-heap-corruptionBryan McLellan2018-03-191-0/+36
|\ \ | | | | | | Fix regression in #6980, add functional tests
| * | Fix regression in #6980, add functional testsBryan McLellan2018-03-191-0/+36
| |/ | | | | | | | | | | | | | | The logging refactor in #6980 should have been a class variable. This fixes that. Also adds functional tests that would catch that and the original #6980 bug. Signed-off-by: Bryan McLellan <btm@loftninjas.org>
* | Move subversion specific properties from scm to subversionscm_subversionTim Smith2018-03-172-11/+12
|/ | | | | | We actually set the defaults for these in the subversion property, but the actual properties are in scm. Move them to subversion since they are subversion specific. Signed-off-by: Tim Smith <tsmith@chef.io>
* Merge pull request #6979 from chef/sudoTim Smith2018-03-161-0/+87
|\ | | | | Add the sudo resource from the sudo resource
| * Add the sudo resource from the sudo resourceTim Smith2018-03-151-0/+87
| | | | | | | | | | | | Copied as is with the new description fields added. Signed-off-by: Tim Smith <tsmith@chef.io>
* | el6 fixesLamont Granquist2018-03-151-2/+2
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | chefstyle fixLamont Granquist2018-03-151-1/+1
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | add more tests, fix more subtle bugsLamont Granquist2018-03-151-0/+17
| | | | | | | | | | | | | | we support locking based on provides lines, and now test that and ensure that locking checks go through name resolution properly. Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | add a few lock/unlock tests and fix a bugLamont Granquist2018-03-151-0/+48
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix rebase issueLamont Granquist2018-03-151-3/+0
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix yum_cache arch options and use positional parametersLamont Granquist2018-03-151-10/+30
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | fix provider resolver specLamont Granquist2018-03-151-3/+2
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | add specs for YumCache fascadeLamont Granquist2018-03-151-0/+89
| | | | | | | | Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* | Yum package provider rewriteLamont Granquist2018-03-1542-2468/+1056
|/ | | | | | squash and rebase of all the work Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
* Merge pull request #6969 from chef/tm/6851Thom May2018-03-153-45/+37
|\ | | | | update mount to use properties and fix 6851
View Lorry Controller Status