From 413632d2e593d520231801423a4a9d8ea30591e0 Mon Sep 17 00:00:00 2001 From: Tim Smith Date: Mon, 3 Aug 2020 14:02:18 -0700 Subject: Resolve Performance/RangeInclude warnings Use cover? instead of include? with ranges Signed-off-by: Tim Smith --- lib/chef/resource/windows_firewall_rule.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/chef/resource/windows_firewall_rule.rb b/lib/chef/resource/windows_firewall_rule.rb index f1a039267d..7398fb6eb5 100644 --- a/lib/chef/resource/windows_firewall_rule.rb +++ b/lib/chef/resource/windows_firewall_rule.rb @@ -273,11 +273,11 @@ class Chef requirements.assert(:create) do |a| a.assertion do if new_resource.icmp_type.is_a?(Integer) - (0..255).include?(new_resource.icmp_type) + (0..255).cover?(new_resource.icmp_type) elsif new_resource.icmp_type.is_a?(String) && !new_resource.icmp_type.include?(":") && new_resource.protocol.start_with?("ICMP") - (0..255).include?(new_resource.icmp_type.to_i) + (0..255).cover?(new_resource.icmp_type.to_i) elsif new_resource.icmp_type.is_a?(String) && new_resource.icmp_type.include?(":") && new_resource.protocol.start_with?("ICMP") - new_resource.icmp_type.split(":").all? { |type| (0..255).include?(type.to_i) } + new_resource.icmp_type.split(":").all? { |type| (0..255).cover?(type.to_i) } else true end -- cgit v1.2.1