From 43d45b243d0c54d64b62202710445a70e6d05ac6 Mon Sep 17 00:00:00 2001 From: Tim Smith Date: Sun, 26 Dec 2021 19:12:54 -0800 Subject: Resolve Performance/RedundantSortBlock warnings Simplify and speed up the sorts Signed-off-by: Tim Smith --- knife/lib/chef/knife/core/generic_presenter.rb | 2 +- knife/spec/unit/knife/environment_list_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/knife/lib/chef/knife/core/generic_presenter.rb b/knife/lib/chef/knife/core/generic_presenter.rb index 850bfa8b3d..214ffd340b 100644 --- a/knife/lib/chef/knife/core/generic_presenter.rb +++ b/knife/lib/chef/knife/core/generic_presenter.rb @@ -140,7 +140,7 @@ class Chef end def format_list_for_display(list) - config[:with_uri] ? list : list.keys.sort { |a, b| a <=> b } + config[:with_uri] ? list : list.keys.sort end def format_for_display(data) diff --git a/knife/spec/unit/knife/environment_list_spec.rb b/knife/spec/unit/knife/environment_list_spec.rb index 4f44a93f60..5090596815 100644 --- a/knife/spec/unit/knife/environment_list_spec.rb +++ b/knife/spec/unit/knife/environment_list_spec.rb @@ -39,7 +39,7 @@ describe Chef::Knife::EnvironmentList do end it "should print the environment names in a sorted list" do - names = @environments.keys.sort { |a, b| a <=> b } + names = @environments.keys.sort expect(@knife).to receive(:output).with(names) @knife.run end -- cgit v1.2.1