From ab720d3c5272c765d6afe11257f6359c545d243a Mon Sep 17 00:00:00 2001 From: Tim Smith Date: Tue, 25 Feb 2020 15:31:32 -0800 Subject: Add basic spec for return code Traditionally we've tested the defaults so we don't accidentally change them. Signed-off-by: Tim Smith --- spec/unit/provider/package/windows/exe_spec.rb | 2 +- spec/unit/resource/windows_package_spec.rb | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/spec/unit/provider/package/windows/exe_spec.rb b/spec/unit/provider/package/windows/exe_spec.rb index 2ed4c03905..afceaabd55 100644 --- a/spec/unit/provider/package/windows/exe_spec.rb +++ b/spec/unit/provider/package/windows/exe_spec.rb @@ -126,7 +126,7 @@ describe Chef::Provider::Package::Windows::Exe do it "removes installed package and quotes uninstall string" do new_resource.timeout = 300 allow(::File).to receive(:exist?).with("uninst_dir/uninst_file").and_return(true) - expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir/uninst_file\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, default_env: false, timeout: 300, returns: [0]) + expect(provider).to receive(:shell_out!).with(%r{start \"\" /wait \"uninst_dir/uninst_file\" /S /NCRC & exit %%%%ERRORLEVEL%%%%}, default_env: false, timeout: 300, returns: [0, 3010]) provider.remove_package end end diff --git a/spec/unit/resource/windows_package_spec.rb b/spec/unit/resource/windows_package_spec.rb index a0f746393d..af38942877 100644 --- a/spec/unit/resource/windows_package_spec.rb +++ b/spec/unit/resource/windows_package_spec.rb @@ -1,6 +1,6 @@ # # Author:: Bryan McLellan -# Copyright:: Copyright 2014-2019, Chef Software, Inc. +# Copyright:: Copyright 2014-2020, Chef Software, Inc. # License:: Apache License, Version 2.0 # # Licensed under the Apache License, Version 2.0 (the "License"); @@ -89,6 +89,10 @@ describe Chef::Resource::WindowsPackage, "initialize" do expect(resource.source).to eql "c:\\frost.msi" end + it "defaults returns to [0, 3010]" do + expect(resource.returns).to eq([0, 3010]) + end + it "defaults source to the resource name" do # it's a little late to stub out File.absolute_path expect(resource.source).to include("solitaire.msi") -- cgit v1.2.1