From 9b6f1129364ab39dd272ccffd14bbc82f4c32ace Mon Sep 17 00:00:00 2001 From: Steven Danna Date: Tue, 9 Dec 2014 13:27:21 +0000 Subject: Implement RFC 027 File Verification This implements usable-suppliable file content verification per RFC 027. Users can supplie a block, string, or symbol to the `verify` resource attribute. Blocks will be called, string will be executed as shell commands (respecing the same options as not_if and only_if), and symbols can be used to access built-in registered validations. --- spec/unit/resource/file/verification_spec.rb | 107 +++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 spec/unit/resource/file/verification_spec.rb (limited to 'spec/unit/resource/file') diff --git a/spec/unit/resource/file/verification_spec.rb b/spec/unit/resource/file/verification_spec.rb new file mode 100644 index 0000000000..60e51ddb93 --- /dev/null +++ b/spec/unit/resource/file/verification_spec.rb @@ -0,0 +1,107 @@ +# +# Author:: Steven Danna () +# Copyright:: Copyright (c) 2014 Chef Software, Inc +# License:: Apache License, Version 2.0 +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +require 'spec_helper' + +describe Chef::Resource::File::Verification do + let(:t_block) { Proc.new { true } } + let(:f_block) { Proc.new { false } } + let(:path_block) { Proc.new { |path| path }} + let(:temp_path) { "/tmp/foobar" } + + describe "verification registration" do + it "registers a verification for later use" do + class Chef::Resource::File::Verification::Wombat < Chef::Resource::File::Verification + register :tabmow + end + expect(Chef::Resource::File::Verification.lookup(:tabmow)).to eq(Chef::Resource::File::Verification::Wombat) + end + + it "raises an error if a verificationc can't be found" do + expect{Chef::Resource::File::Verification.lookup(:dne)}.to raise_error(Chef::Exceptions::VerificationNotFound) + end + end + + describe "#verify" do + let(:parent_resource) { Chef::Resource.new("llama") } + + it "expects a string argument" do + v = Chef::Resource::File::Verification.new(parent_resource, nil, {}) {} + expect{ v.verify("/foo/bar") }.to_not raise_error + expect{ v.verify }.to raise_error + end + + it "accepts an options hash" do + v = Chef::Resource::File::Verification.new(parent_resource, nil, {}) {} + expect{ v.verify("/foo/bar", {:future => true}) }.to_not raise_error + end + + context "with a verification block" do + it "passes a file path to the block" do + v = Chef::Resource::File::Verification.new(parent_resource, nil, {}, &path_block) + expect(v.verify(temp_path)).to eq(temp_path) + end + + it "returns true if the block returned true" do + v = Chef::Resource::File::Verification.new(parent_resource, nil, {}, &t_block) + expect(v.verify(temp_path)).to eq(true) + end + + it "returns false if the block returned false" do + v = Chef::Resource::File::Verification.new(parent_resource, nil, {}, &f_block) + expect(v.verify(temp_path)).to eq(false) + end + end + + context "with a verification command(String)" do + it "substitutes \%{file} with the path" do + test_command = "test #{temp_path} = %{file}" + v = Chef::Resource::File::Verification.new(parent_resource, test_command, {}) + expect(v.verify(temp_path)).to eq(true) + end + + it "returns false if the command fails" do + v = Chef::Resource::File::Verification.new(parent_resource, "false", {}) + expect(v.verify(temp_path)).to eq(false) + end + + it "returns true if the command succeeds" do + v = Chef::Resource::File::Verification.new(parent_resource, "true", {}) + expect(v.verify(temp_path)).to eq(true) + end + end + + context "with a named verification(Symbol)" do + before(:each) do + class Chef::Resource::File::Verification::Turtle < Chef::Resource::File::Verification + register :cats + def verify(path, opts) + end + end + end + + it "delegates to the registered verification" do + registered_verification = double() + allow(Chef::Resource::File::Verification::Turtle).to receive(:new).and_return(registered_verification) + v = Chef::Resource::File::Verification.new(parent_resource, :cats, {}) + expect(registered_verification).to receive(:verify).with(temp_path, {}) + v.verify(temp_path, {}) + end + end + end +end -- cgit v1.2.1