1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
|
#
# Copyright:: Copyright (c) Chef Software Inc.
# License:: Apache License, Version 2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
require "spec_helper"
require "support/shared/integration/integration_helper"
require "chef/mixin/shell_out"
describe "notifications" do
include IntegrationSupport
include Chef::Mixin::ShellOut
let(:chef_dir) { File.expand_path("../../../bin", __dir__) }
let(:chef_client) { "bundle exec chef-client --minimal-ohai" }
when_the_repository "notifies a nameless resource" do
before do
directory "cookbooks/x" do
file "recipes/default.rb", <<-EOM
apt_update do
action :nothing
end
notify_group "foo" do
notifies :nothing, 'apt_update', :delayed
action :run
end
notify_group "bar" do
notifies :nothing, 'apt_update[]', :delayed
action :run
end
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
# our delayed notification should run at the end of the parent run_context after the baz resource
expect(result.stdout).to match(/\* apt_update\[\] action nothing \(skipped due to action :nothing\)\s+\* notify_group\[foo\] action run\s+\* notify_group\[bar\] action run\s+\* apt_update\[\] action nothing \(skipped due to action :nothing\)/)
result.error!
end
end
when_the_repository "notifies delayed one" do
before do
directory "cookbooks/x" do
file "resources/notifying_test.rb", <<~EOM
default_action :run
provides :notifying_test
resource_name :notifying_test
action :run do
notify_group "bar" do
notifies :write, 'log[foo]', :delayed
action :run
end
end
EOM
file "recipes/default.rb", <<~EOM
log "foo" do
action :nothing
end
notifying_test "whatever"
log "baz"
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
# our delayed notification should run at the end of the parent run_context after the baz resource
expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* log\[baz\] action write\s+\* log\[foo\] action write/)
result.error!
end
end
when_the_repository "notifies delayed two" do
before do
directory "cookbooks/x" do
file "resources/notifying_test.rb", <<~EOM
default_action :run
provides :notifying_test
resource_name :notifying_test
action :run do
notify_group "bar" do
notifies :write, 'log[foo]', :delayed
action :run
end
end
EOM
file "recipes/default.rb", <<~EOM
log "foo" do
action :nothing
end
notifying_test "whatever"
notify_group "baz" do
notifies :write, 'log[foo]', :delayed
action :run
end
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
# our delayed notification should run at the end of the parent run_context after the baz resource
expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* notify_group\[baz\] action run\s+\* log\[foo\] action write/)
# and only run once
expect(result.stdout).not_to match(/\* log\[foo\] action write.*\* log\[foo\] action write/)
result.error!
end
end
when_the_repository "notifies delayed three" do
before do
directory "cookbooks/x" do
file "resources/notifying_test.rb", <<~EOM
default_action :run
provides :notifying_test
resource_name :notifying_test
action :run do
notify_group "bar" do
notifies :write, 'log[foo]', :delayed
action :run
end
end
EOM
file "recipes/default.rb", <<~EOM
log "foo" do
action :nothing
end
notify_group "quux" do
notifies :write, 'log[foo]', :delayed
notifies :write, 'log[baz]', :delayed
action :run
end
notifying_test "whatever"
log "baz"
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
# the delayed notification from the sub-resource is de-duplicated by the notification already in the parent run_context
expect(result.stdout).to match(/\* notify_group\[quux\] action run\s+\* notifying_test\[whatever\] action run\s+\* notify_group\[bar\] action run\s+\* log\[baz\] action write\s+\* log\[foo\] action write\s+\* log\[baz\] action write/)
# and only run once
expect(result.stdout).not_to match(/\* log\[foo\] action write.*\* log\[foo\] action write/)
result.error!
end
end
when_the_repository "notifies delayed four" do
before do
directory "cookbooks/x" do
file "recipes/default.rb", <<~EOM
log "foo" do
action :nothing
end
notify_group "bar" do
notifies :write, 'log[foo]', :delayed
action :run
end
notify_group "baz" do
notifies :write, 'log[foo]', :delayed
action :run
end
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
# the delayed notification from the sub-resource is de-duplicated by the notification already in the parent run_context
expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* notify_group\[baz\] action run\s+\* log\[foo\] action write/)
# and only run once
expect(result.stdout).not_to match(/\* log\[foo\] action write.*\* log\[foo\] action write/)
result.error!
end
end
when_the_repository "notifies immediately" do
before do
directory "cookbooks/x" do
file "resources/notifying_test.rb", <<~EOM
default_action :run
provides :notifying_test
resource_name :notifying_test
action :run do
notify_group "bar" do
notifies :write, 'log[foo]', :immediately
action :run
end
end
EOM
file "recipes/default.rb", <<~EOM
log "foo" do
action :nothing
end
notifying_test "whatever"
log "baz"
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* log\[foo\] action write\s+\* log\[baz\] action write/)
result.error!
end
end
when_the_repository "uses old notifies syntax" do
before do
directory "cookbooks/x" do
file "resources/notifying_test.rb", <<~EOM
default_action :run
provides :notifying_test
resource_name :notifying_test
action :run do
notify_group "bar" do
notifies :write, resources(log: "foo"), :immediately
action :run
end
end
EOM
file "recipes/default.rb", <<~EOM
log "foo" do
action :nothing
end
notifying_test "whatever"
log "baz"
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
expect(result.stdout).to match(/\* notify_group\[bar\] action run\s+\* log\[foo\] action write\s+\* log\[baz\] action write/)
result.error!
end
end
when_the_repository "does not have a matching resource" do
before do
directory "cookbooks/x" do
file "resources/notifying_test.rb", <<~EOM
default_action :run
provides :notifying_test
resource_name :notifying_test
action :run do
notify_group "bar" do
notifies :write, "log[foo]"
action :run
end
end
EOM
file "recipes/default.rb", <<~EOM
notifying_test "whatever"
log "baz"
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
expect(result.stdout).to match(/Chef::Exceptions::ResourceNotFound/)
expect(result.exitstatus).not_to eql(0)
end
end
when_the_repository "encounters identical resources in parent and child resource collections" do
before do
directory "cookbooks/x" do
file "resources/cloning_test.rb", <<~EOM
default_action :run
provides :cloning_test
resource_name :cloning_test
action :run do
log "bar" do
level :info
end
end
EOM
file "recipes/default.rb", <<~EOM
log "bar" do
level :warn
end
cloning_test "whatever"
EOM
end
end
it "should complete with success" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
expect(result.stdout).not_to match(/CHEF-3694/)
result.error!
end
end
when_the_repository "has resources that have arrays as the name" do
before do
directory "cookbooks/x" do
file "recipes/default.rb", <<-EOM
log [ "a", "b" ] do
action :nothing
end
notify_group "doit" do
notifies :write, "log[a, b]"
action :run
end
EOM
end
end
it "notifying the resource should work" do
file "config/client.rb", <<~EOM
local_mode true
cookbook_path "#{path_to("cookbooks")}"
log_level :warn
EOM
result = shell_out("#{chef_client} -c \"#{path_to("config/client.rb")}\" --no-color -F doc -o 'x::default'", cwd: chef_dir)
expect(result.stdout).to match /\* log\[a, b\] action write/
result.error!
end
end
end
|
