summaryrefslogtreecommitdiff
path: root/spec/integration/recipes/resource_action_spec.rb
blob: a55ea72b3fd094f0b21f8b6a44f14efab58f7398 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
require 'support/shared/integration/integration_helper'

# Houses any classes we declare
module ResourceActionSpec

describe "Resource.action" do
  include IntegrationSupport

  shared_context "ActionJackson" do
    it "the default action is the first declared action" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_recipe_dsl
      expect(ActionJackson.succeeded).to eq true
    end

    it "the action can access recipe DSL" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_recipe_dsl
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_recipe_dsl
      expect(ActionJackson.succeeded).to eq true
    end

    it "the action can access attributes" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_attribute
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_attribute
      expect(ActionJackson.succeeded).to eq 'foo!'
    end

    it "the action can access public methods" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_method
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_method
      expect(ActionJackson.succeeded).to eq 'foo_public!'
    end

    it "the action can access protected methods" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_protected_method
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_protected_method
      expect(ActionJackson.succeeded).to eq 'foo_protected!'
    end

    it "the action cannot access private methods" do
      expect {
        converge(<<-EOM, __FILE__, __LINE__+1)
          #{resource_dsl} 'hi' do
            foo 'foo!'
            action :access_private_method
          end
        EOM
      }.to raise_error(NameError)
      expect(ActionJackson.ran_action).to eq :access_private_method
    end

    it "the action cannot access resource instance variables" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_instance_variable
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_instance_variable
      expect(ActionJackson.succeeded).to be_nil
    end

    it "the action does not compile until the prior resource has converged" do
      converge <<-EOM, __FILE__, __LINE__+1
        ruby_block 'wow' do
          block do
            ResourceActionSpec::ActionJackson.ruby_block_converged = 'ruby_block_converged!'
          end
        end

        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_class_method
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_class_method
      expect(ActionJackson.succeeded).to eq 'ruby_block_converged!'
    end

    it "the action's resources converge before the next resource converges" do
      converge <<-EOM, __FILE__, __LINE__+1
        #{resource_dsl} 'hi' do
          foo 'foo!'
          action :access_attribute
        end

        ruby_block 'wow' do
          block do
            ResourceActionSpec::ActionJackson.ruby_block_converged = ResourceActionSpec::ActionJackson.succeeded
          end
        end
      EOM
      expect(ActionJackson.ran_action).to eq :access_attribute
      expect(ActionJackson.succeeded).to eq 'foo!'
      expect(ActionJackson.ruby_block_converged).to eq 'foo!'
    end
  end

  context "With resource 'action_jackson'" do
    class ActionJackson < Chef::Resource
      use_automatic_resource_name
      def foo(value=nil)
        @foo = value if value
        @foo
      end
      def blarghle(value=nil)
        @blarghle = value if value
        @blarghle
      end

      class <<self
        attr_accessor :ran_action
        attr_accessor :succeeded
        attr_accessor :ruby_block_converged
      end

      public
      def foo_public
        'foo_public!'
      end
      protected
      def foo_protected
        'foo_protected!'
      end
      private
      def foo_private
        'foo_private!'
      end

      public
      action :access_recipe_dsl do
        ActionJackson.ran_action = :access_recipe_dsl
        ruby_block 'hi there' do
          block do
            ActionJackson.succeeded = true
          end
        end
      end
      action :access_attribute do
        ActionJackson.ran_action = :access_attribute
        ActionJackson.succeeded = foo
        ActionJackson.succeeded += " #{blarghle}" if blarghle
        ActionJackson.succeeded += " #{bar}" if respond_to?(:bar)
      end
      action :access_attribute2 do
        ActionJackson.ran_action = :access_attribute2
        ActionJackson.succeeded = foo
        ActionJackson.succeeded += " #{blarghle}" if blarghle
        ActionJackson.succeeded += " #{bar}" if respond_to?(:bar)
      end
      action :access_method do
        ActionJackson.ran_action = :access_method
        ActionJackson.succeeded = foo_public
      end
      action :access_protected_method do
        ActionJackson.ran_action = :access_protected_method
        ActionJackson.succeeded = foo_protected
      end
      action :access_private_method do
        ActionJackson.ran_action = :access_private_method
        ActionJackson.succeeded = foo_private
      end
      action :access_instance_variable do
        ActionJackson.ran_action = :access_instance_variable
        ActionJackson.succeeded = @foo
      end
      action :access_class_method do
        ActionJackson.ran_action = :access_class_method
        ActionJackson.succeeded = ActionJackson.ruby_block_converged
      end
    end

    before(:each) {
      ActionJackson.ran_action = :error
      ActionJackson.succeeded = :error
      ActionJackson.ruby_block_converged = :error
    }

    it_behaves_like "ActionJackson" do
      let(:resource_dsl) { :action_jackson }
    end

    it "Can retrieve ancestors of action class without crashing" do
      converge { action_jackson 'hi' }
      expect { ActionJackson.action_class.ancestors.join(",") }.not_to raise_error
    end

    context "And 'action_jackgrandson' inheriting from ActionJackson and changing nothing" do
      before(:context) {
        class ActionJackgrandson < ActionJackson
          use_automatic_resource_name
        end
      }

      it_behaves_like "ActionJackson" do
        let(:resource_dsl) { :action_jackgrandson }
      end
    end

    context "And 'action_jackalope' inheriting from ActionJackson with an extra attribute, action and custom method" do
      class ActionJackalope < ActionJackson
        use_automatic_resource_name

        def foo(value=nil)
          @foo = "#{value}alope" if value
          @foo
        end
        def bar(value=nil)
          @bar = "#{value}alope" if value
          @bar
        end
        class <<self
          attr_accessor :load_current_resource_ran
          attr_accessor :jackalope_ran
        end
        action :access_jackalope do
          ActionJackalope.jackalope_ran = :access_jackalope
          ActionJackalope.succeeded = "#{foo} #{blarghle} #{bar}"
        end
        action :access_attribute do
          super()
          ActionJackalope.jackalope_ran = :access_attribute
          ActionJackalope.succeeded = ActionJackson.succeeded
        end
      end
      before do
        ActionJackalope.jackalope_ran = nil
        ActionJackalope.load_current_resource_ran = nil
      end

      context "action_jackson still behaves the same" do
        it_behaves_like "ActionJackson" do
          let(:resource_dsl) { :action_jackson }
        end
      end

      it "the default action remains the same even though new actions were specified first" do
        converge {
          action_jackalope 'hi' do
            foo 'foo!'
            bar 'bar!'
          end
        }
        expect(ActionJackson.ran_action).to eq :access_recipe_dsl
        expect(ActionJackson.succeeded).to eq true
      end

      it "new actions run, and can access overridden, new, and overridden attributes" do
        converge {
          action_jackalope 'hi' do
            foo 'foo!'
            bar 'bar!'
            blarghle 'blarghle!'
            action :access_jackalope
          end
        }
        expect(ActionJackalope.jackalope_ran).to eq :access_jackalope
        expect(ActionJackalope.succeeded).to eq "foo!alope blarghle! bar!alope"
      end

      it "overridden actions run, call super, and can access overridden, new, and overridden attributes" do
        converge {
          action_jackalope 'hi' do
            foo 'foo!'
            bar 'bar!'
            blarghle 'blarghle!'
            action :access_attribute
          end
        }
        expect(ActionJackson.ran_action).to eq :access_attribute
        expect(ActionJackson.succeeded).to eq "foo!alope blarghle! bar!alope"
        expect(ActionJackalope.jackalope_ran).to eq :access_attribute
        expect(ActionJackalope.succeeded).to eq "foo!alope blarghle! bar!alope"
      end

      it "non-overridden actions run and can access overridden and non-overridden variables (but not necessarily new ones)" do
        converge {
          action_jackalope 'hi' do
            foo 'foo!'
            bar 'bar!'
            blarghle 'blarghle!'
            action :access_attribute2
          end
        }
        expect(ActionJackson.ran_action).to eq :access_attribute2
        expect(ActionJackson.succeeded).to eq("foo!alope blarghle! bar!alope").or(eq("foo!alope blarghle!"))
      end
    end
  end

  context "With a resource with no actions" do
    class NoActionJackson < Chef::Resource
      use_automatic_resource_name

      def foo(value=nil)
        @foo = value if value
        @foo
      end

      class <<self
        attr_accessor :action_was
      end
    end

    it "the default action is :nothing" do
      converge {
        no_action_jackson 'hi' do
          foo 'foo!'
          NoActionJackson.action_was = action
        end
      }
      expect(NoActionJackson.action_was).to eq [:nothing]
    end
  end

  context "With a resource with action a-b-c d" do
    class WeirdActionJackson < Chef::Resource
      use_automatic_resource_name

      class <<self
        attr_accessor :action_was
      end

      action "a-b-c d" do
        WeirdActionJackson.action_was = action
      end
    end

    it "Running the action works" do
      expect_recipe {
        weird_action_jackson 'hi'
      }.to be_up_to_date
      expect(WeirdActionJackson.action_was).to eq :"a-b-c d"
    end
  end

  context "With a resource with property x" do
    class ResourceActionSpecWithX < Chef::Resource
      resource_name :resource_action_spec_with_x
      property :x, default: 20
      action :set do
        # Access x during converge to ensure that we emit no warnings there
        x
      end
    end

    context "And another resource with a property x and an action that sets property x to its value" do
      class ResourceActionSpecAlsoWithX < Chef::Resource
        resource_name :resource_action_spec_also_with_x
        property :x
        action :set_x_to_x do
          resource_action_spec_with_x 'hi' do
            x x
          end
        end
        action :set_x_to_10 do
          resource_action_spec_with_x 'hi' do
            x 10
          end
        end
      end

      it "Using the enclosing resource to set x to x emits a warning that you're using the wrong x" do
        recipe = converge {
          resource_action_spec_also_with_x 'hi' do
            x 1
            action :set_x_to_x
          end
        }
        warnings = recipe.logs.lines.select { |l| l =~ /warn/i }
        expect(warnings.size).to eq 1
        expect(warnings[0]).to match(/property x is declared in both resource_action_spec_with_x\[hi\] and resource_action_spec_also_with_x\[hi\] action :set_x_to_x. Use new_resource.x instead. At #{__FILE__}:#{__LINE__-19}/)
      end

      it "Using the enclosing resource to set x to 10 emits no warning" do
        expect_recipe {
          resource_action_spec_also_with_x 'hi' do
            x 1
            action :set_x_to_10
          end
        }.to emit_no_warnings_or_errors
      end
    end

  end

  context "When a resource has a property with the same name as another resource" do
    class HasPropertyNamedTemplate < Chef::Resource
      use_automatic_resource_name
      property :template
      action :create do
        template "x" do
          'blah'
        end
      end
    end

    it "Raises an error when attempting to use a template in the action" do
      expect_converge {
        has_property_named_template 'hi'
      }.to raise_error(/Property template of has_property_named_template\[hi\] cannot be passed a block! If you meant to create a resource named template instead, you'll need to first rename the property./)
    end
  end

  context "When a resource declares methods in action_class and declare_action_class" do
    class DeclaresActionClassMethods < Chef::Resource
      use_automatic_resource_name
      property :x
      action :hi do
        new_resource.x = a + b
      end
      action_class do
        def a
          1
        end
        def b
          2
        end
      end
    end

    it "the methods are not available on the resource" do
      expect { DeclaresActionClassMethods.new('hi').a }.to raise_error(NameError)
      expect { DeclaresActionClassMethods.new('hi').b }.to raise_error(NameError)
    end

    it "the methods are available to the action" do
      r = nil
      expect_recipe {
        r = declares_action_class_methods 'hi'
      }.to emit_no_warnings_or_errors
      expect(r.x).to eq(3)
    end
  end
end

end