1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
|
require "spec_helper"
require "chef/cookbook/synchronizer"
require "chef/cookbook_version"
describe Chef::CookbookCacheCleaner do
describe "when cleaning up unused cookbook components" do
let(:cleaner) do
cleaner = Chef::CookbookCacheCleaner.instance
cleaner.reset!
cleaner
end
let(:file_cache) { double("Chef::FileCache with files from unused cookbooks") }
let(:unused_template_files) do
%w{
cookbooks/unused/templates/default/foo.conf.erb
cookbooks/unused/tempaltes/default/bar.conf.erb
}
end
let(:valid_cached_cb_files) do
%w{
cookbooks/valid1/recipes/default.rb
cookbooks/valid2/recipes/default.rb
}
end
before do
valid_cached_cb_files.each do |cbf|
cleaner.mark_file_as_valid(cbf)
end
end
it "removes all files not validated during the chef run" do
expect(file_cache).to receive(:find).with(File.join(%w{cookbooks ** {*,.*}})).and_return(valid_cached_cb_files + unused_template_files)
unused_template_files.each do |cbf|
expect(file_cache).to receive(:delete).with(cbf)
end
allow(cleaner).to receive(:cache).and_return(file_cache)
cleaner.cleanup_file_cache
end
it "does not remove anything when skip_removal is true" do
cleaner.skip_removal = true
allow(cleaner.cache).to receive(:find).and_return(%w{cookbooks/valid1/recipes/default.rb cookbooks/valid2/recipes/default.rb})
expect(cleaner.cache).not_to receive(:delete)
cleaner.cleanup_file_cache
end
it "does not remove anything on chef-solo" do
Chef::Config[:solo] = true
allow(cleaner.cache).to receive(:find).and_return(%w{cookbooks/valid1/recipes/default.rb cookbooks/valid2/recipes/default.rb})
expect(cleaner.cache).not_to receive(:delete)
cleaner.cleanup_file_cache
end
end
end
describe Chef::CookbookSynchronizer do
let(:cookbook_a_default_recipe) do
{
"path" => "recipes/default.rb",
"url" => "http://chef.example.com/abc123",
"checksum" => "abc123",
}
end
let(:cookbook_a_default_attrs) do
{
"path" => "attributes/default.rb",
"url" => "http://chef.example.com/abc456",
"checksum" => "abc456",
}
end
let(:cookbook_a_template) do
{
"path" => "templates/default/apache2.conf.erb",
"url" => "http://chef.example.com/ffffff",
"checksum" => "abc125",
}
end
let(:cookbook_a_file) do
{
"path" => "files/default/megaman.conf",
"url" => "http://chef.example.com/megaman.conf",
"checksum" => "abc124",
}
end
let(:cookbook_a_manifest) do
segments = [ :resources, :providers, :recipes, :definitions, :libraries, :attributes, :files, :templates, :root_files ]
cookbook_a_manifest = segments.inject({}) {|h, segment| h[segment.to_s] = []; h}
cookbook_a_manifest["recipes"] = [ cookbook_a_default_recipe ]
cookbook_a_manifest["attributes"] = [ cookbook_a_default_attrs ]
cookbook_a_manifest["templates"] = [ cookbook_a_template ]
cookbook_a_manifest["files"] = [ cookbook_a_file ]
cookbook_a_manifest
end
let(:cookbook_a) do
cookbook_a = Chef::CookbookVersion.new("cookbook_a")
cookbook_a.manifest = cookbook_a_manifest
cookbook_a
end
let(:cookbook_manifest) do
{
"cookbook_a" => cookbook_a
}
end
let(:events) { Chef::EventDispatch::Dispatcher.new }
let(:no_lazy_load) { true }
let(:synchronizer) do
Chef::Config[:no_lazy_load] = no_lazy_load
Chef::CookbookSynchronizer.new(cookbook_manifest, events)
end
it "lists the cookbook names" do
expect(synchronizer.cookbook_names).to eq(%w[cookbook_a])
end
it "lists the cookbook manifests" do
expect(synchronizer.cookbooks).to eq([cookbook_a])
end
context "#clear_obsoleted_cookbooks" do
after do
# Singletons == Global State == Bad
Chef::CookbookCacheCleaner.instance.skip_removal = nil
end
it "behaves correctly when remove_obsoleted_files is false" do
synchronizer.remove_obsoleted_files = false
expect(synchronizer).not_to receive(:remove_old_cookbooks)
expect(synchronizer).to receive(:remove_deleted_files)
synchronizer.clear_obsoleted_cookbooks
expect(Chef::CookbookCacheCleaner.instance.skip_removal).to be true
end
it "behaves correctly when remove_obsoleted_files is true" do
synchronizer.remove_obsoleted_files = true
expect(synchronizer).to receive(:remove_old_cookbooks)
expect(synchronizer).to receive(:remove_deleted_files)
synchronizer.clear_obsoleted_cookbooks
expect(Chef::CookbookCacheCleaner.instance.skip_removal).to be nil
end
end
context "#remove_old_cookbooks" do
let(:file_cache) { double("Chef::FileCache with files from unused cookbooks") }
let(:cookbook_manifest) do
{"valid1"=> {}, "valid2" => {}}
end
it "removes unneeded cookbooks" do
valid_cached_cb_files = %w{cookbooks/valid1/recipes/default.rb cookbooks/valid2/recipes/default.rb}
obsolete_cb_files = %w{cookbooks/old1/recipes/default.rb cookbooks/old2/recipes/default.rb}
expect(file_cache).to receive(:find).with(File.join(%w{cookbooks ** {*,.*}})).and_return(valid_cached_cb_files + obsolete_cb_files)
expect(file_cache).to receive(:delete).with("cookbooks/old1/recipes/default.rb")
expect(file_cache).to receive(:delete).with("cookbooks/old2/recipes/default.rb")
allow(synchronizer).to receive(:cache).and_return(file_cache)
synchronizer.remove_old_cookbooks
end
end
context "#remove_deleted_files" do
let(:file_cache) { double("Chef::FileCache with files from unused cookbooks") }
let(:cookbook_manifest) do
{"valid1"=> {}, "valid2" => {}}
end
it "removes only deleted files" do
valid_cached_cb_files = %w{cookbooks/valid1/recipes/default.rb cookbooks/valid2/recipes/default.rb}
obsolete_cb_files = %w{cookbooks/valid1/recipes/deleted.rb cookbooks/valid2/recipes/deleted.rb}
expect(file_cache).to receive(:find).with(File.join(%w{cookbooks ** {*,.*}})).and_return(valid_cached_cb_files + obsolete_cb_files)
# valid1 is a cookbook in our run_list
expect(synchronizer).to receive(:have_cookbook?).with("valid1").at_least(:once).and_return(true)
# valid2 is a cookbook not in our run_list (we're simulating an override run_list where valid2 needs to be preserved)
expect(synchronizer).to receive(:have_cookbook?).with("valid2").at_least(:once).and_return(false)
expect(file_cache).to receive(:delete).with("cookbooks/valid1/recipes/deleted.rb")
expect(synchronizer).to receive(:cookbook_segment).with("valid1", "recipes").at_least(:once).and_return([ { "path" => "recipes/default.rb" }])
allow(synchronizer).to receive(:cache).and_return(file_cache)
synchronizer.remove_deleted_files
end
end
let(:cookbook_a_default_recipe_tempfile) do
double("Tempfile for cookbook_a default.rb recipe",
:path => "/tmp/cookbook_a_recipes_default_rb")
end
let(:cookbook_a_default_attribute_tempfile) do
double("Tempfile for cookbook_a default.rb attr file",
:path => "/tmp/cookbook_a_attributes_default_rb")
end
let(:cookbook_a_file_default_tempfile) do
double("Tempfile for cookbook_a megaman.conf file",
:path => "/tmp/cookbook_a_file_default_tempfile")
end
let(:cookbook_a_template_default_tempfile) do
double("Tempfile for cookbook_a apache.conf.erb template",
:path => "/tmp/cookbook_a_template_default_tempfile")
end
def setup_common_files_missing_expectations
# Files are not in the cache:
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/recipes/default.rb").
and_return(false)
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/attributes/default.rb").
and_return(false)
# Fetch and copy default.rb recipe
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/abc123").
and_return(cookbook_a_default_recipe_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_recipes_default_rb", "cookbooks/cookbook_a/recipes/default.rb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/recipes/default.rb", false).
and_return("/file-cache/cookbooks/cookbook_a/recipes/default.rb")
# Fetch and copy default.rb attribute file
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/abc456").
and_return(cookbook_a_default_attribute_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_attributes_default_rb", "cookbooks/cookbook_a/attributes/default.rb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/attributes/default.rb", false).
and_return("/file-cache/cookbooks/cookbook_a/attributes/default.rb")
end
def setup_no_lazy_files_and_templates_missing_expectations
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/files/default/megaman.conf").
and_return(false)
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/templates/default/apache2.conf.erb").
and_return(false)
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/megaman.conf").
and_return(cookbook_a_file_default_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_file_default_tempfile", "cookbooks/cookbook_a/files/default/megaman.conf")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/files/default/megaman.conf", false).
and_return("/file-cache/cookbooks/cookbook_a/default/megaman.conf")
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/ffffff").
and_return(cookbook_a_template_default_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_template_default_tempfile", "cookbooks/cookbook_a/templates/default/apache2.conf.erb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/templates/default/apache2.conf.erb", false).
and_return("/file-cache/cookbooks/cookbook_a/templates/default/apache2.conf.erb")
end
def setup_common_files_chksum_mismatch_expectations
# Files are in the cache:
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/recipes/default.rb").
and_return(true)
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/attributes/default.rb").
and_return(true)
# Fetch and copy default.rb recipe
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/abc123").
and_return(cookbook_a_default_recipe_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_recipes_default_rb", "cookbooks/cookbook_a/recipes/default.rb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/recipes/default.rb", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/recipes/default.rb")
# Current file has fff000, want abc123
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/recipes/default.rb").
and_return("fff000")
# Fetch and copy default.rb attribute file
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/abc456").
and_return(cookbook_a_default_attribute_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_attributes_default_rb", "cookbooks/cookbook_a/attributes/default.rb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/attributes/default.rb", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/attributes/default.rb")
# Current file has fff000, want abc456
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/attributes/default.rb").
and_return("fff000")
end
def setup_no_lazy_files_and_templates_chksum_mismatch_expectations
# Files are in the cache:
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/files/default/megaman.conf").
and_return(true)
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/templates/default/apache2.conf.erb").
and_return(true)
# Fetch and copy megaman.conf
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/megaman.conf").
and_return(cookbook_a_file_default_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_file_default_tempfile", "cookbooks/cookbook_a/files/default/megaman.conf")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/files/default/megaman.conf", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/default/megaman.conf")
# Fetch and copy apache2.conf template
expect(server_api).to receive(:streaming_request).
with("http://chef.example.com/ffffff").
and_return(cookbook_a_template_default_tempfile)
expect(file_cache).to receive(:move_to).
with("/tmp/cookbook_a_template_default_tempfile", "cookbooks/cookbook_a/templates/default/apache2.conf.erb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/templates/default/apache2.conf.erb", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/templates/default/apache2.conf.erb")
# Current file has fff000
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/default/megaman.conf").
and_return("fff000")
# Current file has fff000
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/templates/default/apache2.conf.erb").
and_return("fff000")
end
def setup_common_files_present_expectations
# Files are in the cache:
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/recipes/default.rb").
and_return(true)
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/attributes/default.rb").
and_return(true)
# Current file has abc123, want abc123
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/recipes/default.rb").
and_return("abc123")
# Current file has abc456, want abc456
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/attributes/default.rb").
and_return("abc456")
# :load called twice
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/recipes/default.rb", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/recipes/default.rb")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/attributes/default.rb", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/attributes/default.rb")
end
def setup_no_lazy_files_and_templates_present_expectations
# Files are in the cache:
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/files/default/megaman.conf").
and_return(true)
expect(file_cache).to receive(:has_key?).
with("cookbooks/cookbook_a/templates/default/apache2.conf.erb").
and_return(true)
# Current file has abc124, want abc124
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/default/megaman.conf").
and_return("abc124")
# Current file has abc125, want abc125
expect(Chef::CookbookVersion).to receive(:checksum_cookbook_file).
with("/file-cache/cookbooks/cookbook_a/templates/default/apache2.conf.erb").
and_return("abc125")
# :load called twice
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/files/default/megaman.conf", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/default/megaman.conf")
expect(file_cache).to receive(:load).
with("cookbooks/cookbook_a/templates/default/apache2.conf.erb", false).
twice.
and_return("/file-cache/cookbooks/cookbook_a/templates/default/apache2.conf.erb")
end
describe "when syncing cookbooks with the server" do
let(:server_api) { double("Chef::ServerAPI (mock)") }
let(:file_cache) { double("Chef::FileCache (mock)") }
before do
# Would rather not stub out methods on the test subject, but setting up
# the state is a PITA and tests for this behavior are above.
allow(synchronizer).to receive(:clear_obsoleted_cookbooks)
allow(synchronizer).to receive(:server_api).and_return(server_api)
allow(synchronizer).to receive(:cache).and_return(file_cache)
end
context "when the cache does not contain the desired files" do
before do
setup_common_files_missing_expectations
end
context "Chef::Config[:no_lazy_load] is false" do
let(:no_lazy_load) { false }
it "fetches eagerly loaded files" do
synchronizer.sync_cookbooks
end
it "does not fetch templates or cookbook files" do
# Implicitly tested in previous test; this test is just for behavior specification.
expect(server_api).not_to receive(:streaming_request).
with("http://chef.example.com/ffffff")
synchronizer.sync_cookbooks
end
end
context "Chef::Config[:no_lazy_load] is true" do
let(:no_lazy_load) { true }
before do
setup_no_lazy_files_and_templates_missing_expectations
end
it "fetches templates and cookbook files" do
synchronizer.sync_cookbooks
end
end
end
context "when the cache contains outdated files" do
before do
setup_common_files_chksum_mismatch_expectations
end
context "Chef::Config[:no_lazy_load] is true" do
let(:no_lazy_load) { true }
before do
setup_no_lazy_files_and_templates_chksum_mismatch_expectations
end
it "updates the outdated files" do
synchronizer.sync_cookbooks
end
end
context "Chef::Config[:no_lazy_load] is false" do
let(:no_lazy_load) { false }
it "updates the outdated files" do
synchronizer.sync_cookbooks
end
end
end
context "when the cache is up to date" do
before do
setup_common_files_present_expectations
end
context "Chef::Config[:no_lazy_load] is true" do
let(:no_lazy_load) { true }
before do
setup_no_lazy_files_and_templates_present_expectations
end
it "does not update files" do
expect(file_cache).not_to receive(:move_to)
expect(server_api).not_to receive(:streaming_request)
synchronizer.sync_cookbooks
end
end
context "Chef::Config[:no_lazy_load] is false" do
let(:no_lazy_load) { false }
it "does not update files" do
expect(file_cache).not_to receive(:move_to)
expect(server_api).not_to receive(:streaming_request)
synchronizer.sync_cookbooks
end
end
end
end
end
|