1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
|
#--
# Author:: Daniel DeLeo (<dan@chef.io>)
# Copyright:: Copyright 2012-2016, Chef Software Inc.
# License:: Apache License, Version 2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
require "spec_helper"
describe Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector do
before do
@expanded_run_list = Chef::RunList.new("recipe[annoyances]", "recipe[apache2]", "recipe[users]", "recipe[chef::client]")
@description = Chef::Formatters::ErrorDescription.new("Error Resolving Cookbooks for Run List:")
@outputter_output = StringIO.new
@outputter = Chef::Formatters::IndentableOutputStream.new(@outputter_output, STDERR)
# @outputter = Chef::Formatters::IndentableOutputStream.new(STDOUT, STDERR)
end
describe "when explaining a 403 error" do
before do
@response_body = %q({"error": [{"message": "gtfo"}])
@response = Net::HTTPForbidden.new("1.1", "403", "(response) forbidden")
allow(@response).to receive(:body).and_return(@response_body)
@exception = Net::HTTPServerException.new("(exception) forbidden", @response)
@inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
@inspector.add_explanation(@description)
end
it "prints a nice message" do
expect { @description.display(@outputter) }.not_to raise_error
end
end
describe "when explaining a PreconditionFailed (412) error with current error message style" do
# Chef currently returns error messages with some fields as JSON strings,
# which must be re-parsed to get the actual data.
before do
@response_body = "{\"error\":[\"{\\\"non_existent_cookbooks\\\":[\\\"apache2\\\"],\\\"cookbooks_with_no_versions\\\":[\\\"users\\\"],\\\"message\\\":\\\"Run list contains invalid items: no such cookbook nope.\\\"}\"]}"
@response = Net::HTTPPreconditionFailed.new("1.1", "412", "(response) unauthorized")
allow(@response).to receive(:body).and_return(@response_body)
@exception = Net::HTTPServerException.new("(exception) precondition failed", @response)
@inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
@inspector.add_explanation(@description)
end
it "prints a pretty message" do
@description.display(@outputter)
@outputter_output.rewind
observed_output = @outputter_output.read
expect(observed_output).to include("apache2")
expect(observed_output).to include("users")
expect(observed_output).not_to include("Run list contains invalid items: no such cookbook nope.")
end
end
describe "when explaining a PreconditionFailed (412) error with current error message style without cookbook details" do
# Chef currently returns error messages with some fields as JSON strings,
# which must be re-parsed to get the actual data.
# In some cases the error message doesn't contain any cookbook
# details. But we should still print a pretty error message.
before do
@response_body = "{\"error\":[{\"non_existent_cookbooks\":[],\"cookbooks_with_no_versions\":[],\"message\":\"unable to solve dependencies in alotted time.\"}]}"
@response = Net::HTTPPreconditionFailed.new("1.1", "412", "(response) unauthorized")
allow(@response).to receive(:body).and_return(@response_body)
@exception = Net::HTTPServerException.new("(exception) precondition failed", @response)
@inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
@inspector.add_explanation(@description)
end
it "prints a pretty message" do
@description.display(@outputter)
@outputter_output.rewind
expect(@outputter_output.read).to include("unable to solve dependencies in alotted time.")
end
end
describe "when explaining a PreconditionFailed (412) error with single encoded JSON" do
# Chef currently returns error messages with some fields as JSON strings,
# which must be re-parsed to get the actual data.
before do
@response_body = "{\"error\":[{\"non_existent_cookbooks\":[\"apache2\"],\"cookbooks_with_no_versions\":[\"users\"],\"message\":\"Run list contains invalid items: no such cookbook nope.\"}]}"
@response = Net::HTTPPreconditionFailed.new("1.1", "412", "(response) unauthorized")
allow(@response).to receive(:body).and_return(@response_body)
@exception = Net::HTTPServerException.new("(exception) precondition failed", @response)
@inspector = Chef::Formatters::ErrorInspectors::CookbookResolveErrorInspector.new(@expanded_run_list, @exception)
@inspector.add_explanation(@description)
end
it "prints a pretty message" do
@description.display(@outputter)
@outputter_output.rewind
observed_output = @outputter_output.read
expect(observed_output).to include("apache2")
expect(observed_output).to include("users")
expect(observed_output).not_to include("Run list contains invalid items: no such cookbook nope.")
end
end
end
|
