1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
|
#
# Author:: Lamont Granquist (<lamont@chef.io>)
# Copyright:: Copyright 2014-2018, Chef Software Inc.
# License:: Apache License, Version 2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
require "spec_helper"
require "chef/node_map"
class Foo; end
class Bar; end
class FooResource < Chef::Resource; end
class BarResource < Chef::Resource; end
class FooProvider < Chef::Provider; end
class BarProvider < Chef::Provider; end
describe Chef::NodeMap do
let(:node_map) { Chef::NodeMap.new }
let(:node) { Chef::Node.new }
describe "with a bad filter name" do
it "should raise an error" do
expect { node_map.set(node, :thing, on_platform_family: "rhel") }.to raise_error(ArgumentError)
end
end
describe "when no matchers are set at all" do
before do
node_map.set(:thing, :foo)
end
it "returns the value" do
expect(node_map.get(node, :thing)).to eql(:foo)
end
it "returns nil for keys that do not exist" do
expect(node_map.get(node, :other_thing)).to eql(nil)
end
end
describe "filtering by os" do
before do
node_map.set(:thing, :foo, os: ["windows"])
node_map.set(:thing, :bar, os: "linux")
end
it "returns the correct value for windows" do
allow(node).to receive(:[]).with(:os).and_return("windows")
expect(node_map.get(node, :thing)).to eql(:foo)
end
it "returns the correct value for linux" do
allow(node).to receive(:[]).with(:os).and_return("linux")
expect(node_map.get(node, :thing)).to eql(:bar)
end
it "returns nil for a non-matching os" do
allow(node).to receive(:[]).with(:os).and_return("freebsd")
expect(node_map.get(node, :thing)).to eql(nil)
end
end
describe "rejecting an os" do
before do
node_map.set(:thing, :foo, os: "!windows")
end
it "returns nil for windows" do
allow(node).to receive(:[]).with(:os).and_return("windows")
expect(node_map.get(node, :thing)).to eql(nil)
end
it "returns the correct value for linux" do
allow(node).to receive(:[]).with(:os).and_return("linux")
expect(node_map.get(node, :thing)).to eql(:foo)
end
end
describe "filtering by os and platform_family" do
before do
node_map.set(:thing, :bar, os: "linux", platform_family: "rhel")
end
it "returns the correct value when both match" do
allow(node).to receive(:[]).with(:os).and_return("linux")
allow(node).to receive(:[]).with(:platform_family).and_return("rhel")
expect(node_map.get(node, :thing)).to eql(:bar)
end
it "returns nil for a non-matching os" do
allow(node).to receive(:[]).with(:os).and_return("freebsd")
expect(node_map.get(node, :thing)).to eql(nil)
end
it "returns nil when the platform_family does not match" do
allow(node).to receive(:[]).with(:os).and_return("linux")
allow(node).to receive(:[]).with(:platform_family).and_return("debian")
expect(node_map.get(node, :thing)).to eql(nil)
end
end
describe "platform version checks" do
before do
node_map.set(:thing, :foo, platform_family: "rhel", platform_version: ">= 7")
end
it "handles non-x.y.z platform versions without throwing an exception" do
allow(node).to receive(:[]).with(:platform_family).and_return("rhel")
allow(node).to receive(:[]).with(:platform_version).and_return("7.19.2.2F")
expect(node_map.get(node, :thing)).to eql(:foo)
end
it "handles non-x.y.z platform versions without throwing an exception when the match fails" do
allow(node).to receive(:[]).with(:platform_family).and_return("rhel")
allow(node).to receive(:[]).with(:platform_version).and_return("4.19.2.2F")
expect(node_map.get(node, :thing)).to eql(nil)
end
end
describe "ordering classes" do
it "last writer wins when its reverse alphabetic order" do
node_map.set(:thing, Foo)
node_map.set(:thing, Bar)
expect(node_map.get(node, :thing)).to eql(Bar)
end
it "last writer wins when its alphabetic order" do
node_map.set(:thing, Bar)
node_map.set(:thing, Foo)
expect(node_map.get(node, :thing)).to eql(Foo)
end
end
describe "deleting classes" do
it "deletes a class and removes the mapping completely" do
node_map.set(:thing, Bar)
expect( node_map.delete_class(Bar) ).to include({ :thing => [{ :klass => Bar, :cookbook_override => false, :core_override => false }] })
expect( node_map.get(node, :thing) ).to eql(nil)
end
it "deletes a class and leaves the mapping that still has an entry" do
node_map.set(:thing, Bar)
node_map.set(:thing, Foo)
expect( node_map.delete_class(Bar) ).to eql({ :thing => [{ :klass => Bar, :cookbook_override => false, :core_override => false }] })
expect( node_map.get(node, :thing) ).to eql(Foo)
end
it "handles deleting classes from multiple keys" do
node_map.set(:thing1, Bar)
node_map.set(:thing2, Bar)
node_map.set(:thing2, Foo)
expect( node_map.delete_class(Bar) ).to eql({ :thing1 => [{ :klass => Bar, :cookbook_override => false, :core_override => false }], :thing2 => [{ :klass => Bar, :cookbook_override => false, :core_override => false }] })
expect( node_map.get(node, :thing1) ).to eql(nil)
expect( node_map.get(node, :thing2) ).to eql(Foo)
end
end
describe "with a block doing platform_version checks" do
before do
node_map.set(:thing, :foo, platform_family: "rhel") do |node|
node[:platform_version].to_i >= 7
end
end
it "returns the value when the node matches" do
allow(node).to receive(:[]).with(:platform_family).and_return("rhel")
allow(node).to receive(:[]).with(:platform_version).and_return("7.0")
expect(node_map.get(node, :thing)).to eql(:foo)
end
it "returns nil when the block does not match" do
allow(node).to receive(:[]).with(:platform_family).and_return("rhel")
allow(node).to receive(:[]).with(:platform_version).and_return("6.4")
expect(node_map.get(node, :thing)).to eql(nil)
end
it "returns nil when the platform_family filter does not match" do
allow(node).to receive(:[]).with(:platform_family).and_return("debian")
allow(node).to receive(:[]).with(:platform_version).and_return("7.0")
expect(node_map.get(node, :thing)).to eql(nil)
end
it "returns nil when both do not match" do
allow(node).to receive(:[]).with(:platform_family).and_return("debian")
allow(node).to receive(:[]).with(:platform_version).and_return("6.0")
expect(node_map.get(node, :thing)).to eql(nil)
end
context "when there is a less specific definition" do
before do
node_map.set(:thing, :bar, platform_family: "rhel")
end
it "returns the value when the node matches" do
allow(node).to receive(:[]).with(:platform_family).and_return("rhel")
allow(node).to receive(:[]).with(:platform_version).and_return("7.0")
expect(node_map.get(node, :thing)).to eql(:foo)
end
end
end
describe "locked mode" do
context "while unlocked" do
it "allows setting the same key twice" do
expect(Chef).to_not receive(:log_deprecation)
node_map.set(:foo, FooResource)
node_map.set(:foo, BarResource)
expect(node_map.get(node, :foo)).to eql(BarResource)
end
end
context "while locked" do
# Uncomment the commented `expect`s in 15.0.
it "rejects setting the same key twice" do
expect(Chef).to receive(:log_deprecation).with("Trying to register resource foo on top of existing Chef core resource. Check if a new version of the cookbook is available.")
node_map.set(:foo, FooResource)
node_map.lock!
node_map.set(:foo, BarResource)
# expect(node_map.get(node, :foo)).to eql(FooResource)
end
it "allows setting the same key twice when the first has allow_cookbook_override" do
expect(Chef).to_not receive(:log_deprecation)
node_map.set(:foo, FooResource, allow_cookbook_override: true)
node_map.lock!
node_map.set(:foo, BarResource)
expect(node_map.get(node, :foo)).to eql(BarResource)
end
it "allows setting the same key twice when the first has allow_cookbook_override with a future version" do
expect(Chef).to_not receive(:log_deprecation)
node_map.set(:foo, FooResource, allow_cookbook_override: "< 100")
node_map.lock!
node_map.set(:foo, BarResource)
expect(node_map.get(node, :foo)).to eql(BarResource)
end
it "rejects setting the same key twice when the first has allow_cookbook_override with a past version" do
expect(Chef).to receive(:log_deprecation).with("Trying to register resource foo on top of existing Chef core resource. Check if a new version of the cookbook is available.")
node_map.set(:foo, FooResource, allow_cookbook_override: "< 1")
node_map.lock!
node_map.set(:foo, BarResource)
# expect(node_map.get(node, :foo)).to eql(FooResource)
end
it "allows setting the same key twice when the second has __core_override__" do
expect(Chef).to_not receive(:log_deprecation)
node_map.set(:foo, FooResource)
node_map.lock!
node_map.set(:foo, BarResource, __core_override__: true)
expect(node_map.get(node, :foo)).to eql(BarResource)
end
it "rejects setting the same key twice for a provider" do
expect(Chef).to receive(:log_deprecation).with("Trying to register provider foo on top of existing Chef core provider. Check if a new version of the cookbook is available.")
node_map.set(:foo, FooProvider)
node_map.lock!
node_map.set(:foo, BarProvider)
# expect(node_map.get(node, :foo)).to eql(FooProvider)
end
end
end
end
|