diff options
author | Christoph Sassenberg <christoph.sassenberg@googlemail.com> | 2014-01-26 14:56:23 +0000 |
---|---|---|
committer | Christoph Sassenberg <christoph.sassenberg@googlemail.com> | 2014-01-26 15:17:50 +0000 |
commit | 9a655bcd4265153368ca8c1dfbcd1e5159767cfc (patch) | |
tree | 8ea619f9f3abb1785bf3517450cfa2f6ef656817 | |
parent | 3321005d0bd77e0811a2cea6dbbd302d8e86851f (diff) | |
download | hashie-9a655bcd4265153368ca8c1dfbcd1e5159767cfc.tar.gz |
replacing dynamic include with recursion helper method
-rw-r--r-- | lib/hashie/extensions/deep_merge.rb | 21 | ||||
-rw-r--r-- | spec/hashie/extensions/deep_merge_spec.rb | 11 |
2 files changed, 21 insertions, 11 deletions
diff --git a/lib/hashie/extensions/deep_merge.rb b/lib/hashie/extensions/deep_merge.rb index ce821de..aa3b478 100644 --- a/lib/hashie/extensions/deep_merge.rb +++ b/lib/hashie/extensions/deep_merge.rb @@ -3,19 +3,28 @@ module Hashie module DeepMerge # Returns a new hash with +self+ and +other_hash+ merged recursively. def deep_merge(other_hash) - (class << (h = dup); self; end).send :include, Hashie::Extensions::DeepMerge - h.deep_merge!(other_hash) + self.dup.deep_merge!(other_hash) end # Returns a new hash with +self+ and +other_hash+ merged recursively. # Modifies the receiver in place. def deep_merge!(other_hash) - other_hash.each do |k,v| - (class << (tv = self[k]); self; end).send :include, Hashie::Extensions::DeepMerge - self[k] = tv.is_a?(::Hash) && v.is_a?(::Hash) ? tv.deep_merge(v) : v - end + _recursive_merge(self, other_hash) self end + + private + + def _recursive_merge(hash, other_hash) + if other_hash.is_a?(::Hash) && hash.is_a?(::Hash) + other_hash.each do |k, v| + hash[k] = hash.has_key?(k) ? _recursive_merge(hash[k], v) : v + end + hash + else + other_hash + end + end end end end diff --git a/spec/hashie/extensions/deep_merge_spec.rb b/spec/hashie/extensions/deep_merge_spec.rb index d835381..ea88ee6 100644 --- a/spec/hashie/extensions/deep_merge_spec.rb +++ b/spec/hashie/extensions/deep_merge_spec.rb @@ -5,16 +5,17 @@ describe Hashie::Extensions::DeepMerge do subject{ DeepMergeHash } - let(:h1) { subject.new.merge(:a => "a", :b => "b", :c => { :c1 => "c1", :c2 => "c2", :c3 => { :d1 => "d1" } }) } - let(:h2) { { :a => 1, :c => { :c1 => 2, :c3 => { :d2 => "d2" } } } } - let(:expected_hash) { { :a => 1, :b => "b", :c => { :c1 => 2, :c2 => "c2", :c3 => { :d1 => "d1", :d2 => "d2" } } } } + let(:h1) { subject.new.merge(:a => "a", :a1 => 42, :b => "b", :c => { :c1 => "c1", :c2 => {:a => "b"}, :c3 => { :d1 => "d1" } }) } + let(:h2) { { :a => 1, :a1 => 1, :c => { :c1 => 2, :c2 => "c2", :c3 => { :d2 => "d2" } } } } + let(:expected_hash) { { :a => 1, :a1 => 1, :b => "b", :c => { :c1 => 2, :c2 => "c2", :c3 => { :d1 => "d1", :d2 => "d2" } } } } - it 'should deep merge two hashes' do + it 'deep merges two hashes' do h1.deep_merge(h2).should == expected_hash end - it 'should deep merge two hashes with bang method' do + it 'deep merges another hash in place via bang method' do h1.deep_merge!(h2) h1.should == expected_hash end + end |