summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #140 from abinoam/feat_refac_askv2.0.0-developAbinoam P. Marques Jr.2015-07-0647-995/+1905
|\ | | | | Develop Release 2.0.0-develop.1
| * Add tests for HighLine::Simulator - Issue #142Abinoam Praxedes Marques Jr2015-06-291-0/+25
| | | | | | | | | | | | As suggested by @bparanj on https://github.com/JEG2/highline/issues/142 Note: cherry picked from master and adapted to develop branch.
| * Add ruby 2.2.1 and 2.2.2 to travis matrixAbinoam Praxedes Marques Jr2015-06-291-0/+2
| |
| * Remove commented (non functional) codeAbinoam Praxedes Marques Jr2015-06-171-68/+0
| | | | | | | | As suggested by @maurogeorge at https://github.com/JEG2/highline/pull/140#discussion_r32679353
| * Add SimpleCov supportAbinoam Praxedes Marques Jr2015-06-175-2/+11
| | | | | | | | As suggested by @maurogeorge at https://github.com/JEG2/highline/pull/140#issuecomment-112963251
| * Use a conditional assignment operatorAbinoam Praxedes Marques Jr2015-06-151-1/+1
| | | | | | | | As suggested by @plribeiro3000 at https://github.com/JEG2/highline/pull/140#discussion_r32379527
| * Merge pull request #2 from mikz/feat_refac_askAbinoam P. Marques Jr.2015-06-1527-22/+20
| |\ | | | | | | Unify file headers
| | * unify 'coding: utf-8' headersMichal Cichra2015-06-1512-3/+20
| | |
| | * remove unneccessary shebang lines from *.rb files in libMichal Cichra2015-06-1519-19/+0
| |/
| * Minor update to Changelog.mdAbinoam Praxedes Marques Jr2015-06-131-1/+1
| |
| * Require forwardable as AnswerConverter depends on itAbinoam Praxedes Marques Jr2015-06-121-0/+2
| |
| * Fix version testing to accomodate pre release versionsAbinoam Praxedes Marques Jr2015-06-121-1/+1
| |
| * Update Changelog.md - 2.0.0-develop.1Abinoam Praxedes Marques Jr2015-06-121-0/+61
| |
| * Bump up version to 2.0.0-develop.1Abinoam Praxedes Marques Jr2015-06-121-1/+1
| |
| * Add .DS_Store (mac) files to .gitignoreAbinoam Praxedes Marques Jr2015-06-111-0/+1
| |
| * Extract AnswerConverter#convert_by_answer_typeAbinoam Praxedes Marques Jr2015-06-061-7/+8
| |
| * Make all convertion methods private to AnswerConverterAbinoam Praxedes Marques Jr2015-06-061-4/+2
| | | | | | | | And remove TODO message
| * Unify Array and Proc AnswerConverter convertionsAbinoam Praxedes Marques Jr2015-06-061-5/+11
| |
| * Send the name (string) directly. No need to convert to symbol hereAbinoam Praxedes Marques Jr2015-06-061-1/+1
| |
| * Split some AnswerConverter conversions separate methods - simplify conditionalAbinoam Praxedes Marques Jr2015-06-062-18/+61
| |
| * Use a more natural calling syntax for procsAbinoam Praxedes Marques Jr2015-06-061-1/+1
| |
| * Remove duplicate String handling in AnswerConverter#convertAbinoam Praxedes Marques Jr2015-06-061-1/+1
| |
| * Extract HighLine::Question::AnswerConverterAbinoam Praxedes Marques Jr2015-06-053-27/+61
| | | | | | | | | | | | | | | | | | It makes the dependencies clear. Preparing for refactoring this long chain of conditionals into something not that long. It also changes where NotInRangeQuestionError is raised, simplifying HighLine a little bit.
| * Use case/when not if/elsif/elseAbinoam Praxedes Marques Jr2015-06-041-2/+3
| |
| * Remove rescueing for NameError/NoMethdoErrorAbinoam Praxedes Marques Jr2015-06-041-12/+3
| | | | | | | | | | | | | | I just couldn't see where these errors could be triggered in a way that we would like to "treat" them. Now it's simpler with only ArgumentError handling.
| * Add String convertion/coercion to HighLine::Question#format_answerAbinoam Praxedes Marques Jr2015-06-041-0/+1
| |
| * Extract HighLine#confirm(question)Abinoam Praxedes Marques Jr2015-06-031-1/+6
| |
| * Move HighLine#ask_on_error_msg to Question. Make it simpler and it's the ↵Abinoam Praxedes Marques Jr2015-05-312-9/+9
| | | | | | | | | | | | | | | | right place to be. It's good to note after extracting it that now the method has dependency only on a Question instance. So its home is inside Question class.
| * Extract HighLine#ask_on_error_msgAbinoam Praxedes Marques Jr2015-05-311-2/+6
| |
| * Simplify conditionals raising earlierAbinoam Praxedes Marques Jr2015-05-311-8/+6
| |
| * Remove unecessary assignmentAbinoam Praxedes Marques Jr2015-05-311-3/+2
| |
| * Extract Question#confirm_questionAbinoam Praxedes Marques Jr2015-05-312-10/+14
| |
| * Set Question#answer on Question#get_response_or_default and #convert. ↵Abinoam Praxedes Marques Jr2015-05-312-4/+5
| | | | | | | | Simplify assignments on HighLine#ask_once
| * Remove Question#in_range? #valid_answer? and #convert parameters. Use ↵Abinoam Praxedes Marques Jr2015-05-312-19/+19
| | | | | | | | self.answer as default.
| * Add Question#get_response_or_default and simplify HighLine#ask_onceAbinoam Praxedes Marques Jr2015-05-312-1/+5
| |
| * Add NoConfirmationQuestionError. Simplify error handling using an specific ↵Abinoam Praxedes Marques Jr2015-05-311-4/+9
| | | | | | | | error class.
| * Add NotInRangeQuestionError. Simplify error handling using an specific error ↵Abinoam Praxedes Marques Jr2015-05-311-2/+9
| | | | | | | | class.
| * Add NotValidQuestionError. Simplify error handling using an specific error ↵Abinoam Praxedes Marques Jr2015-05-311-4/+10
| | | | | | | | class.
| * Aggregate code and simplify conditionalsAbinoam Praxedes Marques Jr2015-05-241-16/+8
| |
| * Remove backspace_limit tracking needAbinoam Praxedes Marques Jr2015-05-241-11/+3
| | | | | | | | | | Put the "echoing" with "chopping" altogether and remove the need for tracking a backspace_limit
| * Extract HighLine#output_erase_charAbinoam Praxedes Marques Jr2015-05-241-1/+5
| |
| * Change String#slice!(-1, 1) to a more native way - String#chop!Abinoam Praxedes Marques Jr2015-05-241-1/+1
| |
| * Change getbyte -> getc and easy all encoding issuesAbinoam Praxedes Marques Jr2015-05-243-27/+15
| | | | | | | | | | | | | | | | | | There was a lot of encoding handling because of compatibility with old Ruby versions. Using getc handles the multibyte chars correctly (with current Ruby versions) and make us be able to drop all the encoding handling.
| * Extract HighLine#erase_current_lineAbinoam Praxedes Marques Jr2015-05-211-2/+6
| |
| * Move #raw_no_echo_mode_exec from HighLine to TerminalAbinoam Praxedes Marques Jr2015-05-212-16/+14
| | | | | | | | | | | | | | | | I think the "knowledge" about how to exec a block in raw no echo mode should be contained in the HighLine::Terminal itself. (It doesn't depend on anything outside that class!) With the help of the recent commit, we could move it to there in this step.
| * Extract (unifying) HighLine#raw_no_echo_mode_execAbinoam Praxedes Marques Jr2015-05-201-7/+15
| |
| * Extract HighLine#get_response_getc_modeAbinoam Praxedes Marques Jr2015-05-202-11/+16
| |
| * Unify answer formattingAbinoam Praxedes Marques Jr2015-05-201-1/+1
| |
| * Remove jruby conditionalsAbinoam Praxedes Marques Jr2015-05-201-5/+1
| |
| * Extract Question#get_echoAbinoam Praxedes Marques Jr2015-05-201-7/+11
| |
View Lorry Controller Status