summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarc-Andre Lafortune <github@marc-andre.ca>2020-06-30 01:10:49 -0400
committerMarc-Andre Lafortune <github@marc-andre.ca>2020-06-30 01:10:49 -0400
commit5b4f1baef055d2a7be58cdfe7329b1b2f5b748c9 (patch)
tree6e4fe58a191fe299f728ff13d20c2388ce68051a
parentb20cdca8eb03297132bcf3b786eba602fa04ca37 (diff)
downloadjson-5b4f1baef055d2a7be58cdfe7329b1b2f5b748c9.tar.gz
Fix pure parser with unclosed arrays / objects [Fix #314]
-rw-r--r--lib/json/pure/parser.rb8
-rw-r--r--tests/fixtures/fail29.json1
-rw-r--r--tests/fixtures/fail30.json1
-rw-r--r--tests/fixtures/fail31.json1
-rw-r--r--tests/fixtures/fail32.json1
5 files changed, 10 insertions, 2 deletions
diff --git a/lib/json/pure/parser.rb b/lib/json/pure/parser.rb
index 1c8f59f..2bf93f0 100644
--- a/lib/json/pure/parser.rb
+++ b/lib/json/pure/parser.rb
@@ -242,8 +242,10 @@ module JSON
@max_nesting.nonzero? && @current_nesting > @max_nesting
result = @array_class.new
delim = false
- until eos?
+ loop do
case
+ when eos?
+ raise ParserError, "unexpected end of string while parsing array"
when !UNPARSED.equal?(value = parse_value)
delim = false
result << value
@@ -274,8 +276,10 @@ module JSON
@max_nesting.nonzero? && @current_nesting > @max_nesting
result = @object_class.new
delim = false
- until eos?
+ loop do
case
+ when eos?
+ raise ParserError, "unexpected end of string while parsing object"
when !UNPARSED.equal?(string = parse_string)
skip(IGNORE)
unless scan(PAIR_DELIMITER)
diff --git a/tests/fixtures/fail29.json b/tests/fixtures/fail29.json
new file mode 100644
index 0000000..98232c6
--- /dev/null
+++ b/tests/fixtures/fail29.json
@@ -0,0 +1 @@
+{
diff --git a/tests/fixtures/fail30.json b/tests/fixtures/fail30.json
new file mode 100644
index 0000000..558ed37
--- /dev/null
+++ b/tests/fixtures/fail30.json
@@ -0,0 +1 @@
+[
diff --git a/tests/fixtures/fail31.json b/tests/fixtures/fail31.json
new file mode 100644
index 0000000..70773e4
--- /dev/null
+++ b/tests/fixtures/fail31.json
@@ -0,0 +1 @@
+[1, 2, 3,
diff --git a/tests/fixtures/fail32.json b/tests/fixtures/fail32.json
new file mode 100644
index 0000000..b18d550
--- /dev/null
+++ b/tests/fixtures/fail32.json
@@ -0,0 +1 @@
+{"foo": "bar"