summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNobuyoshi Nakada <nobu@ruby-lang.org>2019-10-14 19:13:20 +0900
committerNobuyoshi Nakada <nobu@ruby-lang.org>2019-10-14 19:38:05 +0900
commit4f471bf590a6193681ef10fc15da33eed91fc33a (patch)
tree0dfb1ceffc7afedd97faac80017dc4afd4c1722c
parent8d8e1aa70297d55034e3f6a4ce2f32300294b2a4 (diff)
downloadjson-4f471bf590a6193681ef10fc15da33eed91fc33a.tar.gz
Fixed unexpected illegal/malformed utf-8 error
flori/json@c34d01ff6a18dac04a90b2e0f820cdb1d5c7e1b2 does not consider US-ASCII compatible but non-UTF-8 encodings, and causes an error in RDoc tests.
-rw-r--r--ext/json/ext/generator/generator.c11
-rw-r--r--tests/json_generator_test.rb6
2 files changed, 16 insertions, 1 deletions
diff --git a/ext/json/ext/generator/generator.c b/ext/json/ext/generator/generator.c
index cc8c3a7..862f766 100644
--- a/ext/json/ext/generator/generator.c
+++ b/ext/json/ext/generator/generator.c
@@ -846,11 +846,20 @@ static void generate_json_array(FBuffer *buffer, VALUE Vstate, JSON_Generator_St
fbuffer_append_char(buffer, ']');
}
+#ifdef HAVE_RUBY_ENCODING_H
+static int enc_utf8_compatible_p(rb_encoding *enc)
+{
+ if (enc == rb_usascii_encoding()) return 1;
+ if (enc == rb_utf8_encoding()) return 1;
+ return 0;
+}
+#endif
+
static void generate_json_string(FBuffer *buffer, VALUE Vstate, JSON_Generator_State *state, VALUE obj)
{
fbuffer_append_char(buffer, '"');
#ifdef HAVE_RUBY_ENCODING_H
- if (!rb_enc_str_asciicompat_p(obj)) {
+ if (!enc_utf8_compatible_p(rb_enc_get(obj))) {
obj = rb_str_encode(obj, CEncoding_UTF_8, 0, Qnil);
}
#endif
diff --git a/tests/json_generator_test.rb b/tests/json_generator_test.rb
index 86be398..d7f9ebe 100644
--- a/tests/json_generator_test.rb
+++ b/tests/json_generator_test.rb
@@ -374,4 +374,10 @@ EOT
assert_equal '["foo"]', JSON.generate([s.new('foo')])
end
end
+
+ if defined?(Encoding)
+ def test_nonutf8_encoding
+ assert_equal("\"5\u{b0}\"", "5\xb0".force_encoding("iso-8859-1").to_json)
+ end
+ end
end