From 0a4fb406a268de6aec6eba5653e7c67c3b06b670 Mon Sep 17 00:00:00 2001 From: Lamont Granquist Date: Fri, 6 Jul 2018 13:28:16 -0700 Subject: master of chefstyle + fixes Signed-off-by: Lamont Granquist --- spec/mixlib/shellout_spec.rb | 8 ++++---- spec/support/platform_helpers.rb | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) (limited to 'spec') diff --git a/spec/mixlib/shellout_spec.rb b/spec/mixlib/shellout_spec.rb index 3867a9d..ceb80d9 100644 --- a/spec/mixlib/shellout_spec.rb +++ b/spec/mixlib/shellout_spec.rb @@ -353,13 +353,13 @@ describe Mixlib::ShellOut do context "when setting user by id" do before(:each) { shell_cmd.user = uid } # Setting the user by uid should change the uid - #it 'should set the uid' do + # it 'should set the uid' do describe "#uid" do subject { super().uid } it { is_expected.to eq(uid) } end - #end + # end # Setting the user without a different gid should change the gid to 1002 describe "#gid" do @@ -1378,7 +1378,7 @@ describe Mixlib::ShellOut do end context "with subprocess writing lots of data to both stdout and stderr" do - let(:expected_output_with) { lambda { |chr| (chr * 20_000) + "#{LINE_ENDING}" + (chr * 20_000) + "#{LINE_ENDING}" } } + let(:expected_output_with) { lambda { |chr| (chr * 20_000) + (LINE_ENDING).to_s + (chr * 20_000) + (LINE_ENDING).to_s } } context "when writing to STDOUT first" do let(:ruby_code) { %q{puts "f" * 20_000; STDERR.puts "u" * 20_000; puts "f" * 20_000; STDERR.puts "u" * 20_000} } @@ -1540,7 +1540,7 @@ describe Mixlib::ShellOut do let(:options) { { user: user } } it "should run as specified user" do - expect(running_user).to eql("#{user}") + expect(running_user).to eql((user).to_s) end end end diff --git a/spec/support/platform_helpers.rb b/spec/support/platform_helpers.rb index bbf7d15..25e17f1 100644 --- a/spec/support/platform_helpers.rb +++ b/spec/support/platform_helpers.rb @@ -9,11 +9,11 @@ def unix? end if windows? - LINE_ENDING = "\r\n" - ECHO_LC_ALL = "echo %LC_ALL%" + LINE_ENDING = "\r\n".freeze + ECHO_LC_ALL = "echo %LC_ALL%".freeze else - LINE_ENDING = "\n" - ECHO_LC_ALL = "echo $LC_ALL" + LINE_ENDING = "\n".freeze + ECHO_LC_ALL = "echo $LC_ALL".freeze end def root? -- cgit v1.2.1