Update rubocop-todo.yml

Signed-off-by: Florian Wininger <fw.centrale@gmail.com>

1 files changed, 40 insertions, 136 deletions

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index a1b7067..68ba713 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -1,19 +1,19 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-09-10 17:13:26 +0200 using RuboCop version 0.74.0.
+# on 2020-05-29 10:37:36 +0200 using RuboCop version 0.74.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 76
+# Offense count: 75
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: with_first_argument, with_fixed_indentation
 Layout/AlignArguments:
   Enabled: false
 
-# Offense count: 57
+# Offense count: 63
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
 # SupportedHashRocketStyles: key, separator, table
@@ -32,39 +32,13 @@ Layout/AlignHash:
 Layout/EmptyLineAfterGuardClause:
   Enabled: false
 
-# Offense count: 170
+# Offense count: 172
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
 Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Layout/IndentFirstArrayElement:
-  Exclude:
-    - 'lib/net/ssh/transport/openssl.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
-Layout/LeadingBlankLines:
-  Exclude:
-    - 'Rakefile'
-    - 'lib/net/ssh/authentication/pub_key_fingerprint.rb'
-    - 'support/arcfour_check.rb'
-
-# Offense count: 14
-# Cop supports --auto-correct.
-# Configuration parameters: AllowDoxygenCommentStyle.
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'test/integration/test_ed25519_pkeys.rb'
-    - 'test/integration/test_forward.rb'
-    - 'test/integration/test_id_rsa_keys.rb'
-    - 'test/integration/test_proxy.rb'
-
 # Offense count: 23
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -87,7 +61,7 @@ Layout/SpaceAfterColon:
     - 'test/integration/test_ed25519_pkeys.rb'
     - 'test/verifiers/test_always.rb'
 
-# Offense count: 281
+# Offense count: 291
 # Cop supports --auto-correct.
 Layout/SpaceAfterComma:
   Enabled: false
@@ -99,7 +73,7 @@ Layout/SpaceAfterComma:
 Layout/SpaceAroundEqualsInParameterDefault:
   Enabled: false
 
-# Offense count: 10
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
@@ -122,14 +96,14 @@ Layout/SpaceInsideReferenceBrackets:
   Exclude:
     - 'lib/net/ssh/transport/algorithms.rb'
 
-# Offense count: 17
+# Offense count: 18
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: final_newline, final_blank_line
 Layout/TrailingBlankLines:
   Enabled: false
 
-# Offense count: 739
+# Offense count: 730
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
@@ -177,14 +151,6 @@ Lint/Loop:
     - 'lib/net/ssh/authentication/methods/password.rb'
     - 'lib/net/ssh/key_factory.rb'
 
-# Offense count: 3
-# Configuration parameters: MaximumRangeSize.
-Lint/MissingCopEnableDirective:
-  Exclude:
-    - 'test/authentication/test_agent.rb'
-    - 'test/authentication/test_certificate.rb'
-    - 'test/integration/test_agent.rb'
-
 # Offense count: 1
 Lint/NonLocalExitFromIterator:
   Exclude:
@@ -207,12 +173,6 @@ Lint/UnderscorePrefixedVariableName:
   Exclude:
     - 'lib/net/ssh/test/local_packet.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Lint/UnneededRequireStatement:
-  Exclude:
-    - 'lib/net/ssh/ruby_compat.rb'
-
 # Offense count: 60
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
@@ -229,7 +189,7 @@ Lint/UnusedBlockArgument:
     - 'test/transport/test_algorithms.rb'
     - 'test/transport/test_hmac.rb'
 
-# Offense count: 62
+# Offense count: 65
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
@@ -251,11 +211,11 @@ Lint/UselessAssignment:
     - 'test/integration/common.rb'
     - 'test/integration/test_forward.rb'
 
-# Offense count: 229
+# Offense count: 239
 Metrics/AbcSize:
-  Max: 89
+  Max: 71
 
-# Offense count: 15
+# Offense count: 17
 # Configuration parameters: CountComments, ExcludedMethods.
 # ExcludedMethods: refine
 Metrics/BlockLength:
@@ -266,23 +226,21 @@ Metrics/BlockLength:
 Metrics/BlockNesting:
   Max: 4
 
-# Offense count: 31
+# Offense count: 33
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 488
 
-# Offense count: 38
+# Offense count: 40
 Metrics/CyclomaticComplexity:
-  Max: 27
-  Exclude:
-    - 'lib/net/ssh/config.rb'
+  Max: 28
 
-# Offense count: 211
+# Offense count: 224
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
-  Max: 82
+  Max: 72
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
   Max: 160
@@ -292,11 +250,11 @@ Metrics/ModuleLength:
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 30
+# Offense count: 32
 Metrics/PerceivedComplexity:
   Max: 20
 
-# Offense count: 9
+# Offense count: 10
 Naming/AccessorMethodName:
   Exclude:
     - 'lib/net/ssh/authentication/methods/password.rb'
@@ -313,25 +271,9 @@ Naming/BinaryOperatorParameterName:
     - 'lib/net/ssh/buffer.rb'
     - 'lib/net/ssh/version.rb'
 
-# Offense count: 12
+# Offense count: 16
 Naming/ClassAndModuleCamelCase:
-  Exclude:
-    - 'lib/net/ssh/transport/hmac/md5_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha1_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_256.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_256_etm.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_512.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_512_etm.rb'
-    - 'test/transport/hmac/test_md5_96.rb'
-    - 'test/transport/hmac/test_sha1_96.rb'
-    - 'test/transport/hmac/test_sha2_256.rb'
-    - 'test/transport/hmac/test_sha2_256_96.rb'
-    - 'test/transport/hmac/test_sha2_256_etm.rb'
-    - 'test/transport/hmac/test_sha2_512.rb'
-    - 'test/transport/hmac/test_sha2_512_96.rb'
-    - 'test/transport/hmac/test_sha2_512_etm.rb'
+  Enabled: false
 
 # Offense count: 4
 Naming/ConstantName:
@@ -340,7 +282,7 @@ Naming/ConstantName:
     - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
     - 'lib/net/ssh/transport/openssl.rb'
 
-# Offense count: 11
+# Offense count: 12
 # Configuration parameters: Blacklist.
 # Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -352,7 +294,7 @@ Naming/HeredocDelimiterNaming:
     - 'test/integration/test_agent.rb'
     - 'test/test_key_factory.rb'
 
-# Offense count: 4
+# Offense count: 5
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -394,7 +336,6 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/net/ssh/authentication/pageant.rb'
     - 'lib/net/ssh/buffer.rb'
     - 'lib/net/ssh/buffered_io.rb'
-    - 'lib/net/ssh/ruby_compat.rb'
     - 'lib/net/ssh/test/socket.rb'
     - 'lib/net/ssh/transport/ctr.rb'
     - 'lib/net/ssh/transport/hmac/abstract.rb'
@@ -446,7 +387,7 @@ Style/AsciiComments:
     - 'lib/net/ssh/authentication/pageant.rb'
     - 'lib/net/ssh/buffered_io.rb'
 
-# Offense count: 8
+# Offense count: 9
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
@@ -487,29 +428,12 @@ Style/CharacterLiteral:
   Exclude:
     - 'test/test_buffer.rb'
 
-# Offense count: 15
+# Offense count: 17
 # Cop supports --auto-correct.
 # Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
-  Exclude:
-    - 'lib/net/ssh/transport/ctr.rb'
-    - 'lib/net/ssh/transport/hmac.rb'
-    - 'lib/net/ssh/transport/hmac/md5.rb'
-    - 'lib/net/ssh/transport/hmac/md5_96.rb'
-    - 'lib/net/ssh/transport/hmac/none.rb'
-    - 'lib/net/ssh/transport/hmac/ripemd160.rb'
-    - 'lib/net/ssh/transport/hmac/sha1.rb'
-    - 'lib/net/ssh/transport/hmac/sha1_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_256.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_256_etm.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_512.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
-    - 'lib/net/ssh/transport/hmac/sha2_512_etm.rb'
-    - 'lib/net/ssh/transport/kex.rb'
-    - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
-    - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb'
+  Enabled: false
 
 # Offense count: 7
 Style/ClassVars:
@@ -560,7 +484,7 @@ Style/DefWithParentheses:
   Exclude:
     - 'test/integration/test_forward.rb'
 
-# Offense count: 14
+# Offense count: 13
 Style/Documentation:
   Exclude:
     - 'spec/**/*'
@@ -568,7 +492,6 @@ Style/Documentation:
     - 'lib/net/ssh/authentication/ed25519.rb'
     - 'lib/net/ssh/connection/keepalive.rb'
     - 'lib/net/ssh/connection/session.rb'
-    - 'lib/net/ssh/ruby_compat.rb'
     - 'lib/net/ssh/test/extensions.rb'
     - 'lib/net/ssh/transport/kex.rb'
     - 'lib/net/ssh/transport/key_expander.rb'
@@ -602,14 +525,14 @@ Style/FormatStringToken:
   Exclude:
     - 'lib/net/ssh/loggable.rb'
 
-# Offense count: 166
+# Offense count: 171
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
-# Offense count: 34
+# Offense count: 35
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false
@@ -620,7 +543,7 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/net/ssh/connection/session.rb'
 
-# Offense count: 16
+# Offense count: 13
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Exclude:
@@ -629,8 +552,6 @@ Style/IfUnlessModifier:
     - 'lib/net/ssh/proxy/command.rb'
     - 'lib/net/ssh/service/forward.rb'
     - 'lib/net/ssh/transport/ctr.rb'
-    - 'lib/net/ssh/transport/kex.rb'
-    - 'lib/net/ssh/transport/kex/abstract5656.rb'
     - 'lib/net/ssh/transport/key_expander.rb'
     - 'test/integration/test_proxy.rb'
     - 'test/test_key_factory.rb'
@@ -690,7 +611,7 @@ Style/MultipleComparison:
 Style/MutableConstant:
   Enabled: false
 
-# Offense count: 13
+# Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: both, prefix, postfix
@@ -734,7 +655,7 @@ Style/Not:
   Exclude:
     - 'lib/net/ssh/connection/channel.rb'
 
-# Offense count: 8
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: Strict.
 Style/NumericLiterals:
@@ -771,7 +692,7 @@ Style/ParenthesesAroundCondition:
     - 'lib/net/ssh/transport/ctr.rb'
     - 'test/integration/test_proxy.rb'
 
-# Offense count: 33
+# Offense count: 23
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
@@ -819,19 +740,13 @@ Style/RedundantBegin:
     - 'lib/net/ssh/verifiers/accept_new.rb'
     - 'test/manual/test_pageant.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/RedundantParentheses:
-  Exclude:
-    - 'support/arcfour_check.rb'
-
-# Offense count: 59
+# Offense count: 61
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
   Enabled: false
 
-# Offense count: 14
+# Offense count: 18
 # Cop supports --auto-correct.
 Style/RedundantSelf:
   Exclude:
@@ -910,14 +825,14 @@ Style/SpecialGlobalVars:
     - 'test/manual/test_pageant.rb'
     - 'test/test_all.rb'
 
-# Offense count: 1754
+# Offense count: 1801
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 11
+# Offense count: 7
 # Cop supports --auto-correct.
 # Configuration parameters: IgnoredMethods.
 # IgnoredMethods: respond_to, define_method
@@ -928,8 +843,6 @@ Style/SymbolProc:
     - 'lib/net/ssh/connection/session.rb'
     - 'lib/net/ssh/test/extensions.rb'
     - 'lib/net/ssh/transport/algorithms.rb'
-    - 'test/integration/test_forward.rb'
-    - 'test/test/test_test.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
@@ -937,20 +850,18 @@ Style/UnneededCondition:
   Exclude:
     - 'lib/net/ssh/proxy/command.rb'
 
-# Offense count: 4
+# Offense count: 2
 # Cop supports --auto-correct.
 Style/UnneededInterpolation:
   Exclude:
     - 'lib/net/ssh/proxy/socks5.rb'
     - 'lib/net/ssh/transport/session.rb'
-    - 'test/integration/test_forward.rb'
 
-# Offense count: 15
+# Offense count: 2
 # Cop supports --auto-correct.
 Style/UnneededPercentQ:
   Exclude:
     - 'net-ssh.gemspec'
-    - 'test/test_config.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -973,10 +884,3 @@ Style/ZeroLengthPredicate:
   Exclude:
     - 'lib/net/ssh/buffered_io.rb'
     - 'lib/net/ssh/connection/channel.rb'
-
-# Offense count: 1636
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 932