diff options
| author | Davide Cavalca <dcavalca@fb.com> | 2016-03-08 10:28:33 -0800 |
|---|---|---|
| committer | Davide Cavalca <dcavalca@fb.com> | 2016-03-08 10:28:33 -0800 |
| commit | f5f0e2985f021997d4cdedc683cd77635032e578 (patch) | |
| tree | 9950d2b507a3b48b66d73c7ca0e805eea3309b10 | |
| parent | 13c86a5fc571bc45ca37c889e77d6dc970596ee5 (diff) | |
| download | ohai-f5f0e2985f021997d4cdedc683cd77635032e578.tar.gz | |
use shell_out!
| -rw-r--r-- | lib/ohai/plugins/linux/sessions.rb | 3 | ||||
| -rw-r--r-- | spec/unit/plugins/linux/sessions_spec.rb | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/lib/ohai/plugins/linux/sessions.rb b/lib/ohai/plugins/linux/sessions.rb index f2f33bba..bd1364c8 100644 --- a/lib/ohai/plugins/linux/sessions.rb +++ b/lib/ohai/plugins/linux/sessions.rb @@ -25,10 +25,11 @@ Ohai.plugin(:Sessions) do collect_data(:linux) do loginctl_path = which("loginctl") + if loginctl_path cmd = "#{loginctl_path} --no-pager --no-legend --no-ask-password " + "list-sessions" - loginctl = shell_out(cmd) + loginctl = shell_out!(cmd) sessions Mash.new unless sessions sessions[:by_session] = Mash.new unless sessions[:by_session] diff --git a/spec/unit/plugins/linux/sessions_spec.rb b/spec/unit/plugins/linux/sessions_spec.rb index 32936670..1e1ab2c1 100644 --- a/spec/unit/plugins/linux/sessions_spec.rb +++ b/spec/unit/plugins/linux/sessions_spec.rb @@ -33,7 +33,7 @@ describe Ohai::System, "Linux sessions plugin" do 306 1000 joe LOGINCTL_OUT allow(plugin).to receive(:which).with("loginctl").and_return("/bin/loginctl") - allow(plugin).to receive(:shell_out).with("/bin/loginctl --no-pager --no-legend --no-ask-password list-sessions").and_return(mock_shell_out(0, loginctl_out, "")) + allow(plugin).to receive(:shell_out!).with("/bin/loginctl --no-pager --no-legend --no-ask-password list-sessions").and_return(mock_shell_out(0, loginctl_out, "")) plugin.run expect(plugin[:sessions].to_hash).to eq({ "by_session" => { |