summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Bail out early to avoid safe operatorchefstyleTim Smith2020-09-081-3/+5
| | | | | | | | | Also add some notes here that we should convert this to a filter_map when we can as that's easier to read and faster. Perf benchmarks from the tubes: Signed-off-by: Tim Smith <tsmith@chef.io>
* Simplify respond_to?Tim Smith2020-09-081-1/+1
| | | | | | There's no need for the &. here Signed-off-by: Tim Smith <tsmith@chef.io>
* Simplify things with &.Tim Smith2020-09-083-13/+9
| | | | | | We can avoid some duplicate checks by using &. in places Signed-off-by: Tim Smith <tsmith@chef.io>
* Resolve new chefstyle warningsTim Smith2020-08-252-2/+2
| | | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Update CHANGELOG.md to reflect the promotion of 16.4.12Chef Expeditor2020-08-191-12/+9
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Update CHANGELOG.mdTim Smith2020-08-191-4/+2
| | | Signed-off-by: Tim Smith <tsmith@chef.io>
* Update CHANGELOG.md to reflect the promotion of 16.4.11Chef Expeditor2020-08-191-1/+3
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.4.12 by Chef Expeditorv16.4.12Chef Expeditor2020-08-193-4/+12
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1500 from chef/networkTim Smith2020-08-191-1/+1
|\ | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add missing require for windows network pluginnetworkTim Smith2020-08-191-1/+1
|/ | | | | | | | This was missed since the windows network plugin just mocks out the IP data. I'll see what I can do to make these more real world tests in a followup PR Signed-off-by: Tim Smith <tsmith@chef.io>
* Update CHANGELOG.md to reflect the promotion of 16.4.11Chef Expeditor2020-08-141-22/+19
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.4.11 by Chef Expeditorv16.4.11Chef Expeditor2020-08-123-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1497 from chef/requiresTim Smith2020-08-122-2/+2
|\ | | | | Optimize 2 of our requires
| * Optimize 2 of our requiresrequiresTim Smith2020-08-122-2/+2
|/ | | | | | Only include set if we need to and use require_relative which is faster Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.4.10 by Chef Expeditorv16.4.10Chef Expeditor2020-08-123-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1495 from chef/rubocop_performanceTim Smith2020-08-122-0/+6
|\ | | | | Use rubocop-performance to enforce some best practices
| * Use rubocop-performance to enforce some best practicesrubocop_performanceTim Smith2020-08-112-0/+6
| | | | | | | | | | | | I've already fixed all the warnings. This will keep it that way. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 16.4.9 by Chef Expeditorv16.4.9Chef Expeditor2020-08-123-5/+6
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #1496 from chef/remove_profileTim Smith2020-08-121-5/+1
|\ \ | |/ |/| Remove profile gemfile group for now
| * Remove profile gemfile group for nowremove_profileTim Smith2020-08-121-5/+1
|/ | | | | | This causes bundle install issues on windows Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.4.8 by Chef Expeditorv16.4.8Chef Expeditor2020-08-103-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Bump version to 16.4.7 by Chef Expeditorv16.4.7Chef Expeditor2020-08-103-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1493 from chef/fix_requireTim Smith2020-08-102-3/+2
|\ | | | | Update network plugin to use ipaddr not ipaddress gem
| * Update network plugin to use ipaddr not ipaddress gemfix_requireTim Smith2020-08-102-3/+2
| | | | | | | | | | | | This broke because we never actually required ipaddress in the plugin, but the specs passed because we required it there. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Merge pull request #1494 from chef/remove_requiresTim Smith2020-08-107-9/+0
|\ \ | | | | | | Remove non-Ohai requires from specs to prevent false positives
| * | Remove non-Ohai requires from specs to prevent false positivesremove_requiresTim Smith2020-08-107-9/+0
|/ / | | | | | | | | | | The plugins should require everything they need unless we're using those library to mock out objects like we do in some Windows specs. This way we rely on the requires in the plugins and specs fail if those requires are removed. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 16.4.6 by Chef Expeditorv16.4.6Chef Expeditor2020-08-103-5/+6
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #1490 from chef/systemuTim Smith2020-08-101-1/+0
|\ \ | | | | | | Remove unused systemu dependency
| * | Remove unused systemu dependencysystemuTim Smith2020-08-091-1/+0
| | | | | | | | | | | | | | | | | | I can't see a place where we're using this. Signed-off-by: Tim Smith <tsmith@chef.io>
* | | Bump version to 16.4.5 by Chef Expeditorv16.4.5Chef Expeditor2020-08-103-5/+6
| | | | | | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | | Merge pull request #1491 from chef/avoid_valsTim Smith2020-08-1059-139/+108
|\ \ \ | |/ / |/| / | |/ Minor memory optimizations
| * Avoid creating more shellout objectsavoid_valsTim Smith2020-08-091-10/+5
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Simplify constantsTim Smith2020-08-092-4/+2
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Avoid creating more shellout objects we don't needTim Smith2020-08-099-34/+16
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Avoid creating shellout objects in the platform pluginsTim Smith2020-08-095-18/+9
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Avoid setting the mid value to nil and then setting it againTim Smith2020-08-091-2/+2
| | | | | | | | | | | | Just fall back to nil with an else Signed-off-by: Tim Smith <tsmith@chef.io>
| * Exclude profiling gems on WindowsTim Smith2020-08-093-3/+4
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Avoid a constant we don't actually needTim Smith2020-08-091-17/+14
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Move requires into collect methodsTim Smith2020-08-0910-15/+20
| | | | | | | | | | | | Avoid requiring these unless we actually run the plugin. Signed-off-by: Tim Smith <tsmith@chef.io>
| * Gate more of the external requiresTim Smith2020-08-0936-38/+38
| | | | | | | | | | | | Decreases memory usage slightly Signed-off-by: Tim Smith <tsmith@chef.io>
| * Require net/http not net/https in softlayerTim Smith2020-08-091-1/+1
| | | | | | | | | | | | We actually only use net/http and this way we avoid requiring another file Signed-off-by: Tim Smith <tsmith@chef.io>
| * Add stackprof to the gemfile for optimizationTim Smith2020-08-091-0/+1
| | | | | | | | Signed-off-by: Tim Smith <tsmith@chef.io>
| * Simplify load_additional methodTim Smith2020-08-091-2/+1
|/ | | | | | Avoid creating an object here Signed-off-by: Tim Smith <tsmith@chef.io>
* Bump version to 16.4.4 by Chef Expeditorv16.4.4Chef Expeditor2020-08-083-5/+6
| | | | Obvious fix; these changes are the result of automation not creative thinking.
* Merge pull request #1489 from chef/fix_fipsTim Smith2020-08-072-26/+9
|\ | | | | Simplify FIPS plugin and use system fips status
| * Simplify FIPS plugin and use system fips statusfix_fipsTim Smith2020-08-072-26/+9
| | | | | | | | | | | | Don't rely on fips being enabled by chef-config. Pull the system status instead. Signed-off-by: Tim Smith <tsmith@chef.io>
* | Bump version to 16.4.3 by Chef Expeditorv16.4.3Chef Expeditor2020-08-083-5/+6
| | | | | | | | Obvious fix; these changes are the result of automation not creative thinking.
* | Merge pull request #1488 from chef/rubocop_Performance_RegexpMatchTim Smith2020-08-072-2/+3
|\ \ | |/ |/| Use match? instead of =~ when MatchData is not used
| * Make sure /proc/cmdline exists before reading itrubocop_Performance_RegexpMatchTim Smith2020-08-072-2/+3
| | | | | | | | | | | | Don't run match? against nil Signed-off-by: Tim Smith <tsmith@chef.io>
| * Use match? instead of =~ when MatchData is not usedTim Smith2020-08-071-1/+1
|/ | | | | | We don't need this data. Signed-off-by: Tim Smith <tsmith@chef.io>
View Lorry Controller Status