1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
|
#
# Author:: Claire McQuin (<claire@chef.io>)
# Copyright:: Copyright (c) 2013-2016 Chef Software, Inc.
# License:: Apache License, Version 2.0
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
# implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
require_relative "../spec_helper.rb"
describe Ohai::Loader do
extend IntegrationSupport
let(:loader) { Ohai::Loader.new(ohai) }
let(:ohai) { double("Ohai::System", :data => Mash.new, :provides_map => provides_map) }
let(:provides_map) { Ohai::ProvidesMap.new }
describe "#initialize" do
it "returns an Ohai::Loader object" do
loader = Ohai::Loader.new(ohai)
expect(loader).to be_a_kind_of(Ohai::Loader)
end
end
when_plugins_directory "contains both V6 & V7 plugins" do
with_plugin("zoo.rb", <<EOF)
Ohai.plugin(:Zoo) do
provides 'seals'
end
EOF
with_plugin("zoo_too.rb", <<EOF)
Ohai.plugin(:Zoo) do
provides 'elephants'
end
EOF
with_plugin("lake.rb", <<EOF)
provides 'fish'
EOF
describe "load_plugin() method" do
describe "when loading a v7 plugin" do
let(:plugin) { loader.load_plugin(path_to("zoo.rb")) }
it "saves the plugin according to its attribute" do
plugin
expect(provides_map.map.keys).to include("seals")
end
it "saves a single plugin source" do
expect(plugin.source).to eql([path_to("zoo.rb")])
end
it "saves all plugin sources" do
plugin
loader.load_plugin(path_to("zoo_too.rb"))
expect(plugin.source).to eql([path_to("zoo.rb"), path_to("zoo_too.rb")])
end
end
describe "when loading a v6 plugin" do
let(:plugin) { loader.load_plugin(path_to("lake.rb"), path_to(".")) }
before(:each) do
expect(Ohai::Log).to receive(:warn).with(/\[DEPRECATION\]/)
end
it "does not add this plugin's provided attributes to the provides map" do
plugin
expect(provides_map.map).to be_empty
end
it "saves the plugin's source" do
expect(plugin.source).to eql(path_to("lake.rb"))
end
end
it "logs a warning if a plugin doesn't exist" do
expect(Ohai::Log).to receive(:warn).with(/Unable to open or read plugin/)
loader.load_plugin(path_to("rainier.rb"), path_to("."))
expect(provides_map.map).to be_empty
end
end
end
when_plugins_directory "contains invalid plugins" do
with_plugin("extra_s.rb", <<EOF)
Ohai.plugins(:ExtraS) do
provides "the_letter_s"
end
EOF
with_plugin("no_method.rb", <<EOF)
Ohai.plugin(:NoMethod) do
really_wants "this_attribute"
end
EOF
with_plugin("illegal_def.rb", <<EOF)
Ohai.plugin(:Zoo) do
collect_data(:darwin) do
end
collect_data(:darwin) do
end
end
EOF
with_plugin("unexpected_error.rb", <<EOF)
Ohai.plugin(:Zoo) do
raise "You aren't expecting this."
end
EOF
with_plugin("bad_symbol.rb", <<EOF)
Ohai.plugin(:1nval!d) do
provides "not_a_symbol"
end
EOF
with_plugin("no_end.rb", <<EOF)
Ohai.plugin(:NoEnd) do
provides "fish_oil"
collect_data do
end
EOF
with_plugin("bad_name.rb", <<EOF)
Ohai.plugin(:you_give_plugins_a_bad_name) do
provides "that/one/song"
end
EOF
describe "load_plugin() method" do
describe "when the plugin uses Ohai.plugin instead of Ohai.plugins" do
it "logs an unsupported operation warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Method Error: <#{path_to("extra_s.rb")}>:/)
loader.load_plugin(path_to("extra_s.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("extra_s.rb")) }.not_to raise_error
end
end
describe "when the plugin tries to call an unexisting method" do
it "shoud log an unsupported operation warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Method Error: <#{path_to("no_method.rb")}>:/)
loader.load_plugin(path_to("no_method.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("no_method.rb")) }.not_to raise_error
end
end
describe "when the plugin defines collect_data on the same platform more than once" do
it "shoud log an illegal plugin definition warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Definition Error: <#{path_to("illegal_def.rb")}>:/)
loader.load_plugin(path_to("illegal_def.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("illegal_def.rb")) }.not_to raise_error
end
end
describe "when an unexpected error is encountered" do
it "logs a warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Error: <#{path_to("unexpected_error.rb")}>:/)
loader.load_plugin(path_to("unexpected_error.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("unexpected_error.rb")) }.not_to raise_error
end
end
describe "when the plugin name symbol has bad syntax" do
it "logs a syntax error warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Syntax Error: <#{path_to("bad_symbol.rb")}>:/)
loader.load_plugin(path_to("bad_symbol.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("bad_symbol.rb")) }.not_to raise_error
end
end
describe "when the plugin forgets an 'end'" do
it "logs a syntax error warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Syntax Error: <#{path_to("no_end.rb")}>:/)
loader.load_plugin(path_to("no_end.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("no_end.rb")) }.not_to raise_error
end
end
describe "when the plugin has an invalid name" do
it "logs an invalid plugin name warning" do
expect(Ohai::Log).to receive(:warn).with(/Plugin Name Error: <#{path_to("bad_name.rb")}>:/)
loader.load_plugin(path_to("bad_name.rb"))
end
it "does not raise an error" do
expect { loader.load_plugin(path_to("bad_name.rb")) }.not_to raise_error
end
end
describe "when plugin directory does not exist" do
it "logs an invalid plugin path warning" do
expect(Ohai::Log).to receive(:warn).with(/The plugin path.*does not exist/)
allow(Dir).to receive(:exist?).with("/bogus/dir").and_return(false)
Ohai::Loader::PluginFile.find_all_in("/bogus/dir")
end
end
end
end
end
|
