summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #1797 from pry/rubocop-layout-end-alignmentKyrylo Silin2018-10-135-34/+17
|\ | | | | rubocop: fix offences of the Layout/EndAlignment cop
| * rubocop: fix offences of the Layout/EndAlignment copKyrylo Silin2018-10-135-34/+17
|/
* Merge pull request #1796 from pry/rubocop-layout-extra-spacingKyrylo Silin2018-10-1328-61/+56
|\ | | | | rubocop: fix offences of the Layout/ExtraSpacing cop
| * rubocop: fix offences of the Layout/ExtraSpacing copKyrylo Silin2018-10-1328-61/+56
|/
* Merge pull request #1795 from pry/bright-default-removalKyrylo Silin2018-10-131-1/+0
|\ | | | | helpers/text: delete the 'bright_default' alias
| * helpers/text: delete the 'bright_default' aliasKyrylo Silin2018-10-131-1/+0
|/ | | | | | | | Replaces https://github.com/pry/pry/pull/1692 (Remove the "default" method from `Pry::Helpers::Text`) This alias serves no real purpose because `bold` is already superior: it's short and understandable.
* Merge pull request #1790 from bambooengineering/handle_null_bytes_in_historyKyrylo Silin2018-10-122-2/+18
|\ | | | | Gracefully handle (ignore) null bytes in history lines
| * Gracefully handle (ignore) null bytes in history linesOwen Stephens2018-10-092-2/+18
| | | | | | | | | | | | | | | | Fixes #1789. Readline is unable to add lines to its history that contain a null byte; we should therefore avoid saving such lines to the history file, and ignore any such lines that are already present in the file.
* | Merge pull request #1794 from pry/yardoc-checkKyrylo Silin2018-10-112-8/+3
|\ \ | | | | | | travis: generate docs and fail if there are warnings
| * | README: remove sponsorsKyrylo Silin2018-10-111-8/+0
| | | | | | | | | | | | | | | 1. The links break the build because YARD cannot "resolve" them 2. Pry does not receive money from these companies for at least 4+ years
| * | travis: generate docs and fail if there are warningsKyrylo Silin2018-10-111-0/+3
|/ / | | | | | | | | | | | | The idea is extracted from https://github.com/pry/pry/pull/1720. This ensures that documentation mistakes don't slip through the cracks in the future.
* | Merge pull request #1793 from pry/pryrc-tweaksKyrylo Silin2018-10-114-17/+14
|\ \ | | | | | | Tweak documentation for pryrc
| * | Tweak documentation for pryrcKyrylo Silin2018-10-114-17/+14
|/ / | | | | | | | | | | | | | | Since `~/.pryrc` was replaced by `$XDG_CONFIG_HOME` and `~/.config/pry/pryrc` in https://github.com/pry/pry/pull/1609, we need to adjust some documentation. `~/.pryrc` becomes simply `pryrc`. I've also edited the wiki with this similar change.
* | Merge pull request #1609 from franklinyu/feat/config-file-pathKyrylo Silin2018-10-101-1/+12
|\ \ | | | | | | Find configuration file in XDG Base Directory
| * | Find configuration file in XDG Base DirectoryFranklin Yu2018-10-091-1/+12
| | | | | | | | | | | | | | | | | | Find configuration file in XDG Base Directory only if `PRYRC` is not set, and `~/.pryrc` does not exist, therefore not confusing current users. Note that cache file path is not modified.
* | | Merge pull request #1791 from pry/1449-wtf-causeKyrylo Silin2018-10-103-0/+61
|\ \ \ | |_|/ |/| | commands/wtf,pry: add support for Exception#cause
| * | commands/wtf,pry: add support for Exception#causeAleksandar Kostadinov2018-10-103-0/+61
|/ / | | | | | | | | Fixes #1449 (support exceptions with cause) Replaces #1525
* | Merge pull request #1788 from pry/badge-masterKyrylo Silin2018-10-081-3/+5
|\ \ | | | | | | README: update badges
| * | README: add gem stat badgesKyrylo Silin2018-10-081-0/+2
| | |
| * | README: update documentation badgeKyrylo Silin2018-10-081-1/+1
| | |
| * | README: update the Code Climate badgeKyrylo Silin2018-10-081-1/+1
| | | | | | | | | | | | Apparently, they've changed the URL. The old URL wasn't working.
| * | README: update travis badgeKyrylo Silin2018-10-081-1/+1
|/ / | | | | | | The old badge link seems to be outdated.
* | Merge pull request #1787 from pry/rbx-removalKyrylo Silin2018-10-071-1/+0
|\ \ | |/ |/| spec/commands/edit: delete unwanted unlinking
| * spec/commands/edit: delete unwanted unlinkingrbx-removalKyrylo Silin2018-10-071-1/+0
|/ | | | This line was needed for Rubinius but since we dropped it, it serves no purpose.
* Merge pull request #1785 from pry/1775-rubinius-bye-byeKyrylo Silin2018-10-0724-324/+232
|\ | | | | Drop support for Rubinius
| * Drop support for RubiniusKyrylo Silin2018-10-0724-324/+232
|/ | | | | | | Fixes #1775 (Drop support for Rubinius) I am amazed how many hacks we've had just to support Rubinius. It feels good to be able to remove them and reduce the complexity of the codebase.
* Merge pull request #1784 from pry/spec-run-simplificationKyrylo Silin2018-10-061-25/+3
|\ | | | | Rakefile: unit test with help of RSpec::Core::RakeTask
| * Rakefile: unit test with help of RSpec::Core::RakeTaskKyrylo Silin2018-10-061-25/+3
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | Commit a99861f1b1cea84d044c458ec5fba401d88c6802 broke some tests for me when I try to run them locally. Example failures: ``` Failures: 1) gist nominally logs in Failure/Error: expect(Pad.gist_calls[:login!]).not_to be_nil expected: not nil got: nil 2) show-doc on modules show-doc -a messages relating to -a indicates... Failure/Error: raise CommandError, "No docs found for: #{ obj_name ? obj_name : 'current context' Pry::CommandError: No docs found for: TestClassForShowSource ``` There's little reason to use our own task for specs since RSpec already provides one. Switching to that deletes some old (likely unused) code and fixes the failures for me. Win-win.
* Merge pull request #1783 from pry/rubocopKyrylo Silin2018-10-064-0/+1749
|\ | | | | Add Rubocop
| * travis: run rubocop checksrubocopKyrylo Silin2018-10-061-0/+4
| |
| * rubocop: generate configKyrylo Silin2018-10-062-0/+1740
| | | | | | | | | | The config ignores all violations for now. We will be fixing them at our own pace.
| * Gemfile: add rubocop 0.59.2 and lock itKyrylo Silin2018-10-061-0/+5
|/ | | | | | Rubocop is a really nice tool when configured properly. A lot of default rules are very opinionated but the good thing is that it's very easy to disable them. With help of Rubocop I'd like to improve the quality of Pry's code.
* Merge pull request #1771 from DamienRobert/fix_indentKyrylo Silin2018-10-042-1/+16
|\ | | | | repl.rb: guard against negative overhang
| * pry_repl_spec: test for previous overhang fixDamien Robert2018-10-031-0/+15
| |
| * repl.rb: guard against negative overhangDamien Robert2018-10-031-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | When copy pasting into pry a code like this ~~~ ruby foo do bar #note the tab here done ~~~ then `@indent.indent(val)` replace the tab by two spaces, and so `overhang = original_val.length - indented_val.length` is negative, which yields an Exception in `whitespace = ' ' * overhang`. Guard against this by taking the max with 0.
* | Merge pull request #1779 from pry/1452-show-source-fixKyrylo Silin2018-10-044-4/+41
|\ \ | |/ |/| commands/show_source: handle when source is nil but comment exists
| * commands/show_source: handle when source is nil but comment exists1452-show-source-fixKyrylo Silin2018-10-044-4/+41
|/ | | | | | | Fixes https://github.com/pry/pry/issues/1452. ($ RuntimeError.exception fails) Alternative to https://github.com/pry/pry/pull/1453.
* CHANGELOG: delete unwanted bracketKyrylo Silin2018-10-011-1/+1
|
* CHANGELOG: mention #1774Kyrylo Silin2018-10-011-1/+2
|
* Merge pull request #1774 from MatthiasWinkelmann/realpathKyrylo Silin2018-10-011-1/+3
|\ | | | | Check for existance of cli_options_file before calling realpath()
| * Check for existance of cli_options_file before calling realpath()Matthias Winkelmann2018-10-011-1/+3
|/
* Add 'Data' as a deprecated constant (#1731)Robert2018-10-012-1/+5
|
* Merge pull request #1773 from dnamsons/patch-1Kyrylo Silin2018-10-012-2/+2
|\ | | | | Update year in LICENSE
| * Update year in LICENSEDāvis Namsons2018-09-302-2/+2
| |
* | CHANGELOG: mention #1762Kyrylo Silin2018-10-011-0/+4
| |
* | PluginManager#load_cli_options: use the realpath (#1762)Damien Robert2018-10-011-0/+1
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | * PluginManager#load_cli_options: use the realpath Since ruby 2.5, `require 'foo'` will use the realpath of the file corresponding to foo.rb. However `require '/absolute/path/to/foo.rb'` won't use the realpath. So when $GEM_HOME contains a symlink (ie it is not the realpath), when a pry plugin is loaded, by `activate!`: require gem_name if !active? the real_path of `gem_name` is used. But then in load_cli_options: cli_options_file = File.join(spec.full_gem_path, "lib/#{spec.name}/cli.rb") require cli_options_file if File.exist?(cli_options_file) since the path given is absolute, it will be used directly without realpath. This means that cli.rb may potentially be required twice (once via its realpath if the plugin requires it, the other via its $GEM_HOME path when required by `load_cli_options`), which could raise some errors. Fix this by using the realpath in load_cli_options too. Revision r59984 in ruby 2.5 introduced the use of realpath for load paths, and it was backported to version 2.4 in the minor revision 2.4.4. So only use the realpath ourselves for ruby versions above or equal to 2.4.4.
* CHANGELOG: mention #1767Kyrylo Silin2018-09-221-0/+4
|
* Silence output message in Windows when pager doesn't exist.Silver Phoenix2018-09-221-1/+1
| | | | | | | | | | | | | | | | | | | In Windows, if `less` (or another pager) isn't found by `where.exe` it outputs this info to stderr: ``` [1] pry(main)> 1 INFO: Could not find files for the given pattern(s). => 1 ``` The `/Q` flag silences this message: ``` [1] pry(main)> 1 => 1 ``` Tested on Conemu, cmd and PowerShell.
* Merge pull request #1759 from jackkinsella/patch-1Kyrylo Silin2018-09-201-2/+2
|\ | | | | Fix formatting in spec
| * Fix formatting in specJack Kinsella2018-05-191-2/+2
|/
View Lorry Controller Status