summaryrefslogtreecommitdiff
path: root/lib/pry
Commit message (Collapse)AuthorAgeFilesLines
* Delete the 'simple-prompt' commandprompt-commandsKyrylo Silin2018-11-041-24/+0
| | | | It's duplicative since you can use `change-prompt simple`.
* commands/change_prompt: incorporate 'list_prompts' functionalityKyrylo Silin2018-11-043-44/+35
| | | | Fixes #1829 (Merge `list-prompts` and `change-prompt` into one command)
* config/default: use XDG_DATA_HOME, not XDG_CACHE_HOME for historyKyrylo Silin2018-11-041-3/+3
| | | | | | | | It turns out cache is supposed to be purgeable without losing information and we don't want to lose history. Thanks to @SirNerdBear for pointing out (https://github.com/pry/pry/issues/1316#issuecomment-435611191)
* prompt: deprecate Pry::Prompt::MAPKyrylo Silin2018-11-041-0/+4
|
* prompt: add basic API for adding promptsKyrylo Silin2018-11-048-118/+129
| | | | Fixes #1836 (Add an API for adding new prompts)
* pry_instance: properly deprecate #{input,output}_arrayKyrylo Silin2018-11-041-4/+20
| | | | Without this the warning will actually be printed on every line.
* ring: alias #count as #sizeKyrylo Silin2018-11-041-0/+1
| | | | | This is for backwards compatibility. Pry Rails uses `#size`: https://github.com/rweng/pry-rails/blob/77f770f376077e37c69116dda39ff03ee7961f64/lib/pry-rails/prompt.rb#L23
* config/default: add support for $XDG_CACHE_HOME for historyKyrylo Silin2018-11-032-6/+14
| | | | | Fixes #1316 (support XDG Base Directory Specification)
* method: update deprecated method callKyrylo Silin2018-11-031-1/+1
|
* Merge pull request #1845 from pry/base-helpers-backportKyrylo Silin2018-11-031-0/+143
|\ | | | | helpers/base: properly backport deprecated methods
| * helpers/base: properly backport deprecated methodsbase-helpers-backportKyrylo Silin2018-11-031-0/+143
| | | | | | | | | | The code is extremely ugly but this way people will have more time to update their plugins. I'll revert this PR as soon as the new Pry version is out.
* | repl: calculate JRuby overhang (or rather not)Kyrylo Silin2018-11-031-6/+13
|/ | | | | | Fixes #1840 (NotImplementedError: vi_editing_mode?() function is unimplemented on this machine)
* Deprecate Pry::Platform and introduce Pry::Helpers::PlatformKyrylo Silin2018-11-0219-112/+171
| | | | | | `Pry::Platform` really looks like a helper and therefore should be defined as one. Invoking `Pry::Platform` emits a warning now. Users are encouraged to use `Pry::Helpers::Platform`.
* Delete Pry::CommandSet#{before,after}_commandKyrylo Silin2018-11-012-37/+0
| | | | These commands have been deprecated for years. It's high time to get rid of them.
* command: delete #source_locationKyrylo Silin2018-11-011-6/+0
| | | | | This method doesn't seem to be used anywhere, so there's no benefit in keeping it.
* Merge pull request #1834 from pry/update-copyrightsKyrylo Silin2018-10-281-6/+6
|\ | | | | Update copyrights
| * Update copyrightsKyrylo Silin2018-10-281-6/+6
| | | | | | | | | | * Added myself (should've done that years ago) * Made it look like Pry is a team effort
* | prompt: make it possible to set name dynamicallyKyrylo Silin2018-10-283-3/+53
|/ | | | | | | | | | | | | | Fixes #1738 (Possible to make prompt_name dynamic?) The user-facing API is the following: ```rb Pry.config.prompt_name = Pry.lazy { rand(100) } [1] 80(main)> [2] 87(main)> [3] 30(main)> ```
* config: simplify structureconfig-code-formatKyrylo Silin2018-10-286-433/+447
| | | | | | | | | | | * Replace `require_relative` with `require` The project tries to use the `require` form everywhere where possible, which is the common form * `require` from `pry.rb` Spreaded `require` statements where we require internal classes is confusing * Fixed namespace definition for Config classes https://github.com/rubocop-hq/ruby-style-guide#namespace-definition recommends to use explicit nesting
* prompt: refactor to reduce duplicationKyrylo Silin2018-10-281-59/+65
| | | | | | | Since we always need to define two procs that look almost the same, duplication was unavoidable. With help of method wrappers around procs we can reduce it. As a bonus, the class has some YARD annotations now.
* config/default: rename prompt_safe_objects to prompt_safe_contextsKyrylo Silin2018-10-283-4/+4
| | | | | It makes sense to rename it because "objects" we are referring in the context of prompt are actually prompt "contexts".
* Move prompt related code from pry.rb to prompt.rbKyrylo Silin2018-10-286-20/+100
| | | | | It makes a lot more sense to keep these procs under the `Pry::Prompt` namespace than `Pry`, which is already heavily populated by other various things.
* prompt: use explicit nesting for class definitionKyrylo Silin2018-10-281-21/+23
| | | | Per https://github.com/rubocop-hq/ruby-style-guide#namespace-definition
* pry: move INITIAL_PWD to code/code_fileKyrylo Silin2018-10-281-1/+5
| | | | | This constant is not used anywhere else but this file so it makes sense to keep it there.
* repl: fix broken input while using rb-readlineKyrylo Silin2018-10-261-1/+5
| | | | Fixes #1823 (Broken upstream when rb-readline is enabled)
* cli: fix `-f` not suppressing load of `pryrc`Kyrylo Silin2018-10-221-3/+1
| | | | | | | Fixes #1761 (`pry -f` can no longer suppress the loading of .pryrc) If I recall correctly, we split session loading in #1393 because of `Pry.start`. This broke `-f`. I think we can get away with a simple reorder in #parse_options
* indent: tidy up #correct_indentationKyrylo Silin2018-10-221-11/+10
|
* ring: fix #to_a exampleKyrylo Silin2018-10-221-1/+1
|
* repl: correctly calculate overhang for empty linesKyrylo Silin2018-10-221-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This improves on https://github.com/pry/pry/pull/1813. I spotted a problem with the way it works: sometimes, if you enter an empty line, the output would span across two lines: ``` [1] pry(main)> [2] pry(main)> [3] pry(main)> ``` This is because overhang is bigger than the current line. I also noticed a bug with method definition, where defining a method leaves an unwanted empty line: ``` [3] pry(main)> def foo | end => :foo ``` To fix this I changed the way we calculate overhang. First and the most important change is that I stopped calculating overhang for emacs mode. This is because it's too risky to introduce this change because it's the default mode and 99% of our users use this, so there's no need to change this behaviour. Another reason is that emacs mode users typically don't use any mode indicators (because emacs has no modes), so it strikes me as a more pragmatic solution. With Vi mode we calculate overhang and still support custom indicators.
* rubocop: fix offences of the Lint/AssignmentInCondition copKyrylo Silin2018-10-219-14/+14
|
* ring: rewrite the class to improve APIKyrylo Silin2018-10-213-97/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, the Ring class is written with help of Hash as backend store. According to the comments, the implementation should behave like a circular buffer, however it doesn't. Upon reaching maximum capacity Ring doesn't replace old elements but keeps writing to new cells, deleting old cells, so that the hash contains `nil` entries. The new implementation is based on Array and seems to be closer to the actual Ring. Older elemens get overwritten with newer ones. This class also includes Enumerable, however none of our APIs take advantage of it, so it seems like an overkill. There was also a problem with with this API because of the above-mentioned nils. For example, if the ring exceeds its maximum size, then callin `Enumerable#first` on it returns `nil`. The new implementation deals with this with removal of Enumerable. The `#[]` syntax is preserved, and now `ring[0]` returns an actual element instead of `nil`. In case users need the Enumerable functionality, they can call `Ring#to_a` to build the array, which supports the wanted methods. As for the speed, the new implementation is: * slower overall because it's thread-safe * faster without mutexes for `#<<` * slower without mutexes for `#[]` Benchmark for old implementation: ``` Warming up -------------------------------------- Ring#<< 223.451k i/100ms Ring#[] 2.837k i/100ms Calculating ------------------------------------- Ring#<< 223.157B (± 3.4%) i/s - 778.097B Ring#[] 82.485M (± 9.4%) i/s - 402.602M in 4.957792s ``` Benchmark for this implementation: ``` Warming up -------------------------------------- Ring#<< 211.587k i/100ms Ring#[] 1.974k i/100ms Calculating ------------------------------------- Ring#<< 211.385B (± 2.8%) i/s - 698.439B Ring#[] 40.292M (±17.0%) i/s - 190.069M in 4.971195s ``` The benchmark: ```rb require './lib/pry' require 'benchmark/ips' Benchmark.ips do |x| empty_ring = Pry::Ring.new(100) populated_ring = Pry::Ring.new(100) 150.times { |i| populated_ring << i } x.report("Ring#<<") do |times| empty_ring << times end x.report("Ring#[]") do |times| populated_ring[0] populated_ring[1] populated_ring[2] populated_ring[-1] populated_ring[-2] populated_ring[-3] populated_ring[1..2] populated_ring[-2..-1] populated_ring[-2..3] populated_ring[0..-1] populated_ring[2..-1] populated_ring[-1..10] populated_ring[-1..0] populated_ring[-1..1] end end ```
* Properly clear after indenting (#1813)W2018-10-201-2/+18
| | | Fixes #1812
* pry_instance: deprecate '#output_array' & '#input_array'Kyrylo Silin2018-10-201-0/+21
| | | | I figured it's better to deprecate them to let plugin authors update their API.
* Rename '{input/output}_array' to '{input/output}_ring'Kyrylo Silin2018-10-206-27/+28
|
* Rename HistoryArray to RingKyrylo Silin2018-10-202-16/+16
| | | | | | | | | | | | `HistoryArray` is a very specific name and it doesn't tell the reader what it *really* means unless you read its code or the docs of the class. On the other hand, `Ring` is a [very well-known term][1], which means exactly what `HistoryArray` does. The alias name for it is circular buffer. I chose `Ring` because it is shorter and used by Golang, so I expect programmers to be familiar with `Ring`. [1]: https://en.wikipedia.org/wiki/Circular_buffer
* rubocop: fix offences of the Style/MultilineTernaryOperator copKyrylo Silin2018-10-205-28/+24
|
* core_extensions: make '__binding__' work with redefined #respond_to?Kyrylo Silin2018-10-171-1/+1
| | | | | | | | | | | | | | | | | | | | | Fixes https://github.com/pry/pry/issues/1596 (Unable to inspect object built from class) Replaces https://github.com/pry/pry/pull/1719 Big thanks to @egwspiti for the repro case and the proposed PR. When a class redefines `respond_to?` or `method_missing` this leads to some problems and confuses Pry. I found another example where Pry misbehaves: ``` [1] pry(main)> cd Class.new { def method_missing(*) end; def respond_to_missing?(*) true end; }.new NoMethodError: private method `eval' called for nil:NilClass from /Users/kyrylo/.gem/ruby/2.4.2/gems/pry-0.11.3/lib/pry/pry_instance.rb:163:in `inject_local' ``` By using `method_defined?` we can work around these bugs since this method doesn't check whether the receiver responds to a certain message but checks whether this method is defined (so we don't redefine it later). Seems like a win-win.
* ommands/ls/formatter,helpers/table: pass local Pry configKyrylo Silin2018-10-162-10/+12
| | | | | | | | | | | | | | | | | Replaces #1713 (Pry local config The following methods take a third required argument, an instance of Pry) This fulfills queries to `_pry_.config` in: * Pry::Helpers.tablify * Pry::Helpers.tablify_to_screen_width * Pry::Helpers.tablify_or_one_line Unlike #1713 this PR doesn't introduce any breaking changes thanks to the default parameter value trick, *except* the `Table#new` signature. Overall, this brings the code in line with how the rest of Pry works.
* rubocop: fix offences of the Lint/StringConversionInInterpolationKyrylo Silin2018-10-163-3/+3
|
* rubocop: fix offences of the Lint/UnneededRequireStatement copKyrylo Silin2018-10-161-2/+0
|
* rubocop: fix offences of the Lint/AmbiguousBlockAssociation coprubocop-lint-ambiguous-block-assosicationKyrylo Silin2018-10-161-3/+4
|
* Fix rubocop empty line after guard clause style violationsArlandis Word2018-10-1436-0/+56
|
* command: fix YARD warning for '#complete'Kyrylo Silin2018-10-141-1/+1
|
* method/disowned: delete unused 'binding' parameterKyrylo Silin2018-10-141-1/+1
| | | | | This was added by 97f1be86b29e41e0a786cf0177d934c4c22e8572 and it feels like a mishap, thus removing.
* commands/watch_expression: add a todo to fix arguments laterKyrylo Silin2018-10-141-0/+2
| | | | | | b031df2f2f5850ee6e9018f33d35f3485a9b0423 added this command but never made use of this variable. The method is being passed an argument but it never uses it. Why? Idk, needs investigation.
* commands/import_set: add a comment to figure out what it does laterKyrylo Silin2018-10-141-0/+1
| | | | | This command is quite obscure: no docs and the parameter it expects is not used in the method. For simplicity, I am leaving the comment to check later.
* commands/amend_line: refactor 'amended_input'Kyrylo Silin2018-10-141-3/+2
| | | | | | The way it's written is still a little bit confusing, however for simplicity of https://github.com/pry/pry/pull/1801 I am leaving this as is and resolving the parameter issue only.
* code: delete unused 'top_module' parameterKyrylo Silin2018-10-141-2/+1
| | | | | | | | This was added by 6fd797d302a63f29d10cf5834bfa25cec7f1ac74. I inspected it closely and I cannot seem to find the reason for this parameter. I don't see it being used anywhere and it doesn't seem to do what it declares. Therefore, I am deleting it.
* rubocop: fix offences of the Lint/UnusedMethodArgument copKyrylo Silin2018-10-1412-12/+12
|
* rubocop: fix offences of the Layout/EmptyLineBetweenDefs copKyrylo Silin2018-10-149-3/+13
|
View Lorry Controller Status