diff options
| author | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2015-11-16 23:25:03 +0000 |
|---|---|---|
| committer | normal <normal@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2015-11-16 23:25:03 +0000 |
| commit | 528ff1b9f9ea887970d2766bb94f900469af50b0 (patch) | |
| tree | 8dc381843c809cda667fefaf45b236d7007f5f5e /ChangeLog | |
| parent | 7506498f3894316ba4f644270497edfeddfbceab (diff) | |
| download | ruby-528ff1b9f9ea887970d2766bb94f900469af50b0.tar.gz | |
socket: avoid arg parsing in rsock_s_recvfrom_nonblock
* ext/socket/init.c (rsock_s_recvfrom_nonblock):
avoid arg parsing with C API
[ruby-core:71439] [Feature #11339]
* ext/socket/basicsocket.c (bsock_recv_nonblock):
adjust for above change, make private
* ext/socket/socket.c (sock_recvfrom_nonblock): ditto
* ext/socket/udpsocket.c (udp_recvfrom_nonblock): ditto
* ext/socket/lib/socket.rb (BasicSocket#recv_nonblock):
new wrapper for private method, move RDoc
(Socket#recvfrom_nonblock): ditto
(UDPSocket#recvfrom_nonblock): ditto
Note, not adding bm_recv_nonblock.rb to benchmark/ directory
since it is non-portable. It is only in this commit message.
Benchmark results + code
target 0: a (ruby 2.3.0dev (2015-11-12 trunk 52540) [x86_64-linux])
target 1: b (ruby 2.3.0dev (2015-11-12 avoid-kwarg-capi 52540) [x86_64-linux]
-----------------------------------------------------------
recv_nonblock
require 'socket'
nr = 1000000
msg = 'hello world'
buf = ''
size = msg.bytesize
UNIXSocket.pair(:SEQPACKET) do |a, b|
nr.times do
a.sendmsg(msg)
b.recv_nonblock(size, 0, buf, exception: false)
end
end
-----------------------------------------------------------
raw data:
[["recv_nonblock",
[[1.83511221408844,
1.8703329525887966,
1.8448856547474861,
1.859263762831688,
1.8331583738327026],
[1.5637447573244572,
1.4062932096421719,
1.4247371144592762,
1.4108827747404575,
1.4802536629140377]]]]
Elapsed time: 16.530452496 (sec)
-----------------------------------------------------------
benchmark results:
minimum results in each 5 measurements.
Execution time (sec)
name a b
recv_nonblock 1.833 1.406
Speedup ratio: compare with the result of `a' (greater is better)
name b
recv_nonblock 1.304
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52598 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 14 |
1 files changed, 14 insertions, 0 deletions
@@ -1,3 +1,17 @@ +Tue Nov 17 08:16:09 2015 Eric Wong <e@80x24.org> + + * ext/socket/init.c (rsock_s_recvfrom_nonblock): + avoid arg parsing with C API + [ruby-core:71439] [Feature #11339] + * ext/socket/basicsocket.c (bsock_recv_nonblock): + adjust for above change, make private + * ext/socket/socket.c (sock_recvfrom_nonblock): ditto + * ext/socket/udpsocket.c (udp_recvfrom_nonblock): ditto + * ext/socket/lib/socket.rb (BasicSocket#recv_nonblock): + new wrapper for private method, move RDoc + (Socket#recvfrom_nonblock): ditto + (UDPSocket#recvfrom_nonblock): ditto + Mon Nov 16 21:27:54 2015 Naohisa Goto <ngotogenome@gmail.com> * test/dtrace/helper.rb (Dtrace::TestCase#trap_probe): dtrace buffer |