diff options
author | ko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-10-24 11:13:49 +0000 |
---|---|---|
committer | ko1 <ko1@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-10-24 11:13:49 +0000 |
commit | 5ee9513a7104078d9d2f51aecc354ae67f1ba002 (patch) | |
tree | 52e299b3ec089f27e306012ee11d4e70d82ff848 /vm_args.c | |
parent | d0d32ba1e8e30443cadc0580e3f1e534af547f07 (diff) | |
download | ruby-5ee9513a7104078d9d2f51aecc354ae67f1ba002.tar.gz |
Lazy Proc allocation for block parameters
[Feature #14045]
* insns.def (getblockparam, setblockparam): add special access
instructions for block parameters.
getblockparam checks VM_FRAME_FLAG_MODIFIED_BLOCK_PARAM and
if it is not set this instruction creates a Proc object from
a given blcok and set VM_FRAME_FLAG_MODIFIED_BLOCK_PARAM.
setblockparam is similar to setlocal, but set
VM_FRAME_FLAG_MODIFIED_BLOCK_PARAM.
* compile.c: use get/setblockparm instead get/setlocal instructions.
Note that they are used for method local block parameters (def m(&b)),
not for block local method parameters (iter{|&b|).
* proc.c (get_local_variable_ptr): creates Proc object for
Binding#local_variable_get/set.
* safe.c (safe_setter): we need to create Proc objects for postponed
block parameters when $SAFE is changed.
* vm_args.c (args_setup_block_parameter): used only for block local blcok
parameters.
* vm_args.c (vm_caller_setup_arg_block): if called with
VM_CALL_ARGS_BLOCKARG_BLOCKPARAM flag then passed block values should be
a block handler.
* test/ruby/test_optimization.rb: add tests.
* benchmark/bm_vm1_blockparam*: added.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'vm_args.c')
-rw-r--r-- | vm_args.c | 62 |
1 files changed, 26 insertions, 36 deletions
@@ -477,24 +477,7 @@ static inline void args_setup_block_parameter(rb_thread_t *th, struct rb_calling_info *calling, VALUE *locals) { VALUE block_handler = calling->block_handler; - VALUE blockval = Qnil; - - if (block_handler != VM_BLOCK_HANDLER_NONE) { - - switch (vm_block_handler_type(block_handler)) { - case block_handler_type_iseq: - case block_handler_type_ifunc: - blockval = rb_vm_make_proc(th, VM_BH_TO_CAPT_BLOCK(block_handler), rb_cProc); - break; - case block_handler_type_symbol: - blockval = rb_sym_to_proc(VM_BH_TO_SYMBOL(block_handler)); - break; - case block_handler_type_proc: - blockval = VM_BH_TO_PROC(block_handler); - break; - } - } - *locals = blockval; + *locals = rb_vm_bh_to_procval(th, block_handler); } struct fill_values_arg { @@ -683,7 +666,12 @@ setup_parameters_complex(rb_thread_t * const th, const rb_iseq_t * const iseq, } if (iseq->body->param.flags.has_block) { - args_setup_block_parameter(th, calling, locals + iseq->body->param.block_start); + if (iseq->body->local_iseq == iseq) { + /* Do nothing */ + } + else { + args_setup_block_parameter(th, calling, locals + iseq->body->param.block_start); + } } #if 0 @@ -843,27 +831,29 @@ vm_caller_setup_arg_block(const rb_thread_t *th, rb_control_frame_t *reg_cfp, if (ci->flag & VM_CALL_ARGS_BLOCKARG) { VALUE block_code = *(--reg_cfp->sp); - if (NIL_P(block_code)) { + if ((ci->flag & VM_CALL_ARGS_BLOCKARG_BLOCKPARAM) && + !VM_ENV_FLAGS(VM_CF_LEP(reg_cfp), VM_FRAME_FLAG_MODIFIED_BLOCK_PARAM)) { + calling->block_handler = VM_CF_BLOCK_HANDLER(reg_cfp); + } + else if (NIL_P(block_code)) { calling->block_handler = VM_BLOCK_HANDLER_NONE; } - else { - if (SYMBOL_P(block_code) && rb_method_basic_definition_p(rb_cSymbol, idTo_proc)) { - const rb_cref_t *cref = vm_env_cref(reg_cfp->ep); - if (cref && !NIL_P(cref->refinements)) { - VALUE ref = cref->refinements; - VALUE func = rb_hash_lookup(ref, block_code); - if (NIL_P(func)) { - /* TODO: limit cached funcs */ - func = rb_func_proc_new(refine_sym_proc_call, block_code); - rb_hash_aset(ref, block_code, func); - } - block_code = func; + else if (SYMBOL_P(block_code) && rb_method_basic_definition_p(rb_cSymbol, idTo_proc)) { + const rb_cref_t *cref = vm_env_cref(reg_cfp->ep); + if (cref && !NIL_P(cref->refinements)) { + VALUE ref = cref->refinements; + VALUE func = rb_hash_lookup(ref, block_code); + if (NIL_P(func)) { + /* TODO: limit cached funcs */ + func = rb_func_proc_new(refine_sym_proc_call, block_code); + rb_hash_aset(ref, block_code, func); } - calling->block_handler = block_code; - } - else { - calling->block_handler = vm_to_proc(block_code); + block_code = func; } + calling->block_handler = block_code; + } + else { + calling->block_handler = vm_to_proc(block_code); } } else if (blockiseq != NULL) { /* likely */ |