summaryrefslogtreecommitdiff
path: root/yjit_core.h
Commit message (Collapse)AuthorAgeFilesLines
* YJIT: Remove unused branch_t::src_ctx fieldAlan Wu2021-12-151-1/+2
| | | No one reads it at the moment and it's heap allocated.
* YJIT: Add ability to exit to interpreter from stubsAlan Wu2021-11-261-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, YJIT assumed that it's always possible to generate a new basic block when servicing a stub in branch_stub_hit(). When YJIT is out of executable memory, for example, this assumption doesn't hold up. Add handling to branch_stub_hit() for servicing stubs without consuming more executable memory by adding a code path that exits to the interpreter at the location the branch stub represents. The new code path reconstructs interpreter state in branch_stub_hit() and then exits with a new snippet called `code_for_exit_from_stub` that returns `Qundef` from the YJIT native stack frame. As this change adds another place where we regenerate code from `branch_t`, extract the logic for it into a new function and call it regenerate_branch(). While we are at it, make the branch shrinking code path in branch_stub_hit() more explicit. This new functionality is hard to test without full support for out of memory conditions. To verify this change, I ran `RUBY_YJIT_ENABLE=1 make check -j12` with the following patch to stress test the new code path: ```diff diff --git a/yjit_core.c b/yjit_core.c index 4ab63d9806..5788b8c5ed 100644 --- a/yjit_core.c +++ b/yjit_core.c @@ -878,8 +878,12 @@ branch_stub_hit(branch_t *branch, const uint32_t target_idx, rb_execution_contex cb_set_write_ptr(cb, branch->end_addr); } +if (rand() < RAND_MAX/2) { // Compile the new block version p_block = gen_block_version(target, target_ctx, ec); +}else{ + p_block = NULL; +} if (!p_block && branch_modified) { // We couldn't generate a new block for the branch, but we modified the branch. ``` We can enable the new test along with other OOM tests once full support lands. Other small changes: * yjit_utils.c (print_str): Update to work with new native frame shape. Follow up for 8fa0ee4d404. * yjit_iface.c (rb_yjit_init): Run yjit_init_core() after yjit_init_codegen() so `cb` and `ocb` are available.
* YJIT: Make block invalidation more robustAlan Wu2021-11-221-2/+6
| | | | | | | | | | | | | | | | | | | | | This commit adds an entry_exit field to block_t for use in invalidate_block_version(). By patching the start of the block while invalidating it, invalidate_block_version() can function correctly while there is no executable memory left for new branch stubs. This change additionally fixes correctness for situations where we cannot patch incoming jumps to the invalidated block. In situations such as Shopify/yjit#226, the address to the start of the block is saved and used later, possibly after the block is invalidated. The assume_* family of function now generate block->entry_exit before remembering blocks for invalidation. RubyVM::YJIT.simulate_oom! is introduced for testing out of memory conditions. The test for it is disabled for now because OOM triggers other failure conditions not addressed by this commit. Fixes Shopify/yjit#226
* YJIT code pages refactoring for code GC (#5073)Maxime Chevalier-Boisvert2021-11-041-10/+6
| | | | | | | | | | | | | | | * New code page allocation logic * Fix leaked globals * Fix leaked symbols, yjit asm tests * Make COUNTED_EXIT take a jit argument, so we can eliminate global ocb * Remove extra whitespace * Change block start_pos/end_pos to be pointers instead of uint32_t * Change branch end_pos and start_pos to end_addr, start_addr
* Fix typosNobuyoshi Nakada2021-11-021-1/+1
|
* Put YJIT into a single compilation unitAlan Wu2021-10-201-52/+4
| | | | | | | | | | | | | | | | | | | | | For upstreaming, we want functions we export either prefixed with "rb_" or made static. Historically we haven't been following this rule, so we were "leaking" a lot of symbols as `make leak-globals` would tell us. This change unifies everything YJIT into a single compilation unit, yjit.o, and makes everything unprefixed static to pass `make leak-globals`. This manual "unified build" setup is similar to that of vm.o. Having everything in one compilation unit allows static functions to be visible across YJIT files and removes the need for declarations in headers in some cases. Unnecessary declarations were removed. Other changes of note: - switched to MJIT_SYMBOL_EXPORT_BEGIN which indicates stuff as being off limits for native extensions - the first include of each YJIT file is change to be "internal.h" - undefined MAP_STACK before explicitly redefining it since it collide's with a definition in system headers. Consider renaming?
* Fix changes from rebaseNoah Gibbs2021-10-201-1/+2
|
* Step 2 to remove the global cb/ocb objects.Maxime Chevalier-Boisvert2021-10-201-4/+39
|
* Store block callee_cme in darrayJohn Hawthorn2021-10-201-4/+12
| | | | This allows a block version to have dependencies on multiple CMEs.
* Use callee-saved regs for REG_SP, REG_EP, REG_CFPJohn Hawthorn2021-10-201-6/+4
|
* Move yjit_type_of_value into yjit_core.cJohn Hawthorn2021-10-201-0/+1
|
* Implement verify_ctx for debuggingJohn Hawthorn2021-10-201-0/+2
|
* Introduce ctx_{get,set}_opnd_mappingJohn Hawthorn2021-10-201-0/+11
|
* Rename to ctx_upgrade_opnd_typeJohn Hawthorn2021-10-201-1/+1
|
* Change register definitions to match the entry point calling conventionAaron Patterson2021-10-201-2/+2
| | | | | The JIT entry point passes the CFP as RSI and the EC as RDI. Lets match that so we don't have to shuffle registers around.
* First pass at code page GC object.Maxime Chevalier-Boisvert2021-10-201-0/+4
|
* Add FLONUM detectionJohn Hawthorn2021-10-201-0/+2
|
* Support guards against symbols and integersJohn Hawthorn2021-10-201-0/+1
| | | | This adds guards
* Add concatstrings to yjit codegen (#58)John Hawthorn2021-10-201-1/+5
| | | | | | | | | * Add ETYPE_TRUE and ETYPE_FALSE * Implement checktype * Implement concatstrings * Update deps
* Merge pull request #50 from jhawthorn/detect_typeJohn Hawthorn2021-10-201-0/+1
| | | Detect types from putobject and getinlinecache
* Implement getblockparamproxyAlan Wu2021-10-201-0/+2
| | | | | | | | | | | | | * Implement getblockparamproxy * Parallel runner: wait for timeout thread to terminate after killing Or else the leak cheaker could sees the thread as running and cause test failures in test-tool. * Add a comment, use jne * Comment about where 0x3 comes from
* Malloc branch entries (#112)Maxime Chevalier-Boisvert2021-10-201-7/+14
| | | | | | | | | | | * Malloc branch entries * Add ASM comment for stack overflow check * WIP * Fix branch GC code. Add rb_darray_remove_unordered(). * Fix block end_pos after branch rewriting. Remove dst_patched bits.
* Re-enable local type tracking, until first callMaxime Chevalier-Boisvert2021-10-201-0/+1
|
* Remove unnamed enums because MSVC suxMaxime Chevalier-Boisvert2021-10-201-19/+19
|
* Introduce concept of YJIT instruction operandsMaxime Chevalier-Boisvert2021-10-201-27/+39
|
* YJIT: Fancier opt_getinlinecacheAlan Wu2021-10-201-0/+1
| | | | | | | Make sure `opt_getinlinecache` is in a block all on its own, and invalidate it from the interpreter when `opt_setinlinecache`. It will recompile with a filled cache the second time around. This lets YJIT runs well when the IC for constant is cold.
* Add flag bits to avoid compiling stubs multiple times.Maxime Chevalier-Boisvert2021-10-201-1/+5
| | | | Fixes bug involving ractors and branch stubs.
* Keep track of local types in the contextMaxime Chevalier-Boisvert2021-10-201-0/+2
|
* Add ctcx_stack_push_local()Maxime Chevalier-Boisvert2021-10-201-2/+3
|
* YJIT: adjust branch shape properly when target already existsAlan Wu2021-10-201-1/+1
| | | | | | | | | The old code decides branch->shape based on the write position of the native code block, which is unsound in case the block already exists and no new code is written to the write position. Make this decision with the start address of the target block instead. Also handle when the branch becomes smaller after patching.
* use ctx_stack_push_self()Maxime Chevalier-Boisvert2021-10-201-2/+5
|
* Part 1 of improved type tracking logicMaxime Chevalier-Boisvert2021-10-201-41/+31
|
* WIPMaxime Chevalier-Boisvert2021-10-201-1/+5
|
* Commit WIPMaxime Chevalier-Boisvert2021-10-201-8/+21
|
* First sketch at temp type mappingMaxime Chevalier-Boisvert2021-10-201-0/+69
|
* Get rid of dependency on rb_call_cacheAlan Wu2021-10-201-5/+4
|
* Yjit: rename context structAlan Wu2021-10-201-1/+1
|
* Yet Another Ruby JIT!Jose Narvaez2021-10-201-0/+178
Renaming uJIT to YJIT. AKA s/ujit/yjit/g.
View Lorry Controller Status