summaryrefslogtreecommitdiff
path: root/yjit_iface.c
Commit message (Collapse)AuthorAgeFilesLines
* Add --yjit-no-type-prop so we can test YJIT without type propagation (#5135)Maxime Chevalier-Boisvert2021-11-181-0/+6
| | | | | | | * Add --yjit-no-type-prop so we can test YJIT without type propagation * Fix typo in command line option * Leave just two test workflows enable for YJIT
* Suppress unused-function warningsNobuyoshi Nakada2021-11-051-0/+4
|
* YJIT code pages refactoring for code GC (#5073)Maxime Chevalier-Boisvert2021-11-041-21/+120
| | | | | | | | | | | | | | | * New code page allocation logic * Fix leaked globals * Fix leaked symbols, yjit asm tests * Make COUNTED_EXIT take a jit argument, so we can eliminate global ocb * Remove extra whitespace * Change block start_pos/end_pos to be pointers instead of uint32_t * Change branch end_pos and start_pos to end_addr, start_addr
* remove the repeat 'the'1809092021-11-021-1/+1
|
* Rename ::YJIT to RubyVM::YJITAlan Wu2021-10-281-1/+1
| | | | | Since the YJIT Ruby module is CRuby specific and not meant for general use, it should live under RubyVM instead of at top level.
* YJIT: move --yjit-stats at_exit call into RubyAlan Wu2021-10-271-13/+6
| | | | | | This change fixes `-v --yjit-stats`. Previously in this situation, YJIT._print_stats wasn't defined as yjit.rb is not evaluated when there is only "-v" and no Ruby code to run.
* YJIT: Don't take VM lock on constant IC fill when disabledAlan Wu2021-10-221-0/+2
| | | | | While theoretically it's fine to take the lock and then immediately release it, we don't need to do it when YJIT is off.
* Don't enable YJIT by default. More tests on both Ubuntu and MacOS.Noah Gibbs2021-10-201-1/+1
| | | | | Add RUBY_YJIT_ENABLE env var and YJIT_FORCE_ENABLE compile-time constant. Rename YJIT_STATS to RUBY_YJIT_STATS.
* Put YJIT into a single compilation unitAlan Wu2021-10-201-24/+19
| | | | | | | | | | | | | | | | | | | | | For upstreaming, we want functions we export either prefixed with "rb_" or made static. Historically we haven't been following this rule, so we were "leaking" a lot of symbols as `make leak-globals` would tell us. This change unifies everything YJIT into a single compilation unit, yjit.o, and makes everything unprefixed static to pass `make leak-globals`. This manual "unified build" setup is similar to that of vm.o. Having everything in one compilation unit allows static functions to be visible across YJIT files and removes the need for declarations in headers in some cases. Unnecessary declarations were removed. Other changes of note: - switched to MJIT_SYMBOL_EXPORT_BEGIN which indicates stuff as being off limits for native extensions - the first include of each YJIT file is change to be "internal.h" - undefined MAP_STACK before explicitly redefining it since it collide's with a definition in system headers. Consider renaming?
* Remove unused functionAlan Wu2021-10-201-16/+0
|
* Fix changes from rebaseNoah Gibbs2021-10-201-3/+3
|
* style: align pointer "*" to the rightAlan Wu2021-10-201-13/+13
|
* Add counters for version invalidation reasonsAlan Wu2021-10-201-10/+27
| | | | | I noticed that there were two st_table iterators that do exactly the same thing so I merged them into one.
* Try to break the code page refactoring into smaller stepsMaxime Chevalier-Boisvert2021-10-201-0/+42
|
* Fix excessive invalidation for opt_getinlinecacheAlan Wu2021-10-201-1/+9
| | | | | | | | | | | | | | | | | | | YJIT expects the VM to invalidate opt_getinlinecache when updating the constant cache, and the invalidation used to happen even when YJIT can't use the cached value. Once the first invalidation happens, the block for opt_getinlinecache becomes a stub. When the stub is hit, YJIT fails to compile the instruction as the cache is not usable. The stub becomes a block that exits for opt_getinlinecache which can be invalidated again. Some workloads that bust the interpreter's constant cache can create an invalidation loop with this behavior. Check if the cache is usable become doing invalidation to fix this problem. In the test harness, evaluate the test script in a lambda instead of a proc so `return` doesn't return out of the harness.
* Add counters for tracking invalidationsAlan Wu2021-10-201-0/+3
|
* Fix warnings about redefining YJIT_STATSAlan Wu2021-10-201-6/+1
| | | | | | Follow up for ecb5b383a0c17550b9b27663005049ddac871edb. Now that YJIT_STATS is defined in yjit.h, it shoudl be the only place that defines it.
* Prevent stats being enabled late at run-timeMaxime Chevalier-Boisvert2021-10-201-7/+0
|
* Implement invokesuper using cfp->ep[ME] checkJohn Hawthorn2021-10-201-1/+1
| | | | | This fixes and re-enables invokesuper, replacing the existing guards with a guard on the method entry for the EP.
* Store block callee_cme in darrayJohn Hawthorn2021-10-201-18/+28
| | | | This allows a block version to have dependencies on multiple CMEs.
* Allow to toggle YJIT stats collection from runtimeJean Boussier2021-10-201-0/+7
| | | | | | | | For use cases where you want to collect the metrics for a specific piece of code (typically a web request) you can have the stats turned off by default and then turn them on at runtime before executing the code you care about.
* TracePoint supportAlan Wu2021-10-201-0/+11
| | | | | | | | | | | | | | | | | | | | | | This change fixes some cases where YJIT fails to fire tracing events. Most of the situations YJIT did not handle correctly involves enabling tracing while running inside generated code. A new operation to invalidate all generated code is added, which uses patching to make generated code exit at the next VM instruction boundary. A new routine called `jit_prepare_routine_call()` is introduced to facilitate this and should be used when generating code that could allocate, or could otherwise use `RB_VM_LOCK_ENTER()`. The `c_return` event is fired in the middle of an instruction as opposed to at an instruction boundary, so it requires special handling. C method call return points are patched to go to a fucntion which does everything the interpreter does, including firing the `c_return` event. The generated code for C method calls normally does not fire the event. Invalided code should not change after patching so the exits are not clobbered. A new variable is introduced to track the region of code that should not change.
* Allow to compile with --yjit-stats support but not the full RUBY_DEBUGJean Boussier2021-10-201-9/+16
| | | | | | | | | | | RUBY_DEBUG have a very significant performance overhead. Enough that YJIT with RUBY_DEBUG is noticeably slower than the interpreter without RUBY_DEBUG. This makes it hard to collect yjit-stats in production environments. By allowing to collect JIT statistics without the RUBy_DEBUG overhead, I hope to make such use cases smoother.
* If codeblock is NULL because YJIT is disabled, YJIT.runtime_stats should ↵Noah Gibbs2021-10-201-0/+5
| | | | return Qnil
* Add flag so we can easily tell if all stats avail. Comment out broken test.Maxime Chevalier-Boisvert2021-10-201-1/+3
|
* Make sure we can still compile with the JIT disabledAaron Patterson2021-10-201-3/+5
| | | | | | | If `--disable-jit-support` is passed to configure, then `jit_func` is removed from the iseq body and we can't compile YJIT. This commit detects when the JIT function pointer is gone and disables YJIT in that case.
* Remove the scraperAaron Patterson2021-10-201-18/+1
| | | | | Now that we're using the jit function entry point, we don't need the scraper. Thank you for your service, scraper. ❤️
* make compiler happyAaron Patterson2021-10-201-2/+3
|
* Always use `ret` to return to the interpreterAaron Patterson2021-10-201-5/+8
| | | | | | | | | | | | | | | | | | | | | Always using `ret` to return to the interpreter means that we never have to check the VM_FRAME_FLAG_FINISH flag. In the case that we return `Qundef`, the interpreter will execute the cfp. We can take advantage of this by setting the PC to the instruction we can't handle, and let the interpreter pick up the ball from there. If we return a value other than Qundef, the interpreter will take that value as the "return value" from the JIT and push that to the SP of the caller The leave instruction puts the return value on the top of the calling frame's stack. YJIT does the same thing for leave instructions. However, when we're returning back to the interpreter, the leave instruction _should not_ put the return value on the top of the stack, but put it in RAX and use RET. This commit pops the last value from the stack pointer and puts it in RAX so that the interpreter is happy with SP.
* YJIT stats should always include the inlined and outlined sizes, regardless ↵Noah Gibbs2021-10-201-12/+12
| | | | of RUBY_DEBUG and --yjit-stats/YJIT_STATS settings
* Add (void) for no arg functionsMaxime Chevalier-Boisvert2021-10-201-1/+1
|
* First pass at code page GC object.Maxime Chevalier-Boisvert2021-10-201-0/+35
|
* rb_struct_define_under needs a trailing NULLAaron Patterson2021-10-201-1/+1
| | | | | The last parameter to rb_struct_define_under needs to be NULL otherwise we can get a SEGV.
* Use snprintf rather than double strncpy.Noah Gibbs2021-10-201-2/+1
|
* Change strcpy of a static string to strncpyNoah Gibbs2021-10-201-1/+1
|
* Better comments where we add exits-by-opcode to the stats hash, plus a ↵Noah Gibbs2021-10-201-4/+5
| | | | presumably-unneeded strncpy just to be sure.
* Add back ifdefs for RUBY_DEBUG, accidentally removedNoah Gibbs2021-10-201-0/+2
|
* Convert YJIT stats reporting on exit from C to Ruby.Noah Gibbs2021-10-201-125/+0
|
* Add exit counters and inline/outlined code size to stats hashNoah Gibbs2021-10-201-2/+31
|
* Convert yjit static stat variables to countersNoah Gibbs2021-10-201-8/+4
|
* Add tests, comments, and an assert for invokesuperAlan Wu2021-10-201-2/+4
|
* Add a macro for tweaking default call thresholdAlan Wu2021-10-201-1/+1
| | | | | For use in development for writing `test.rb` and running with `make run`.
* Try running with more YJIT options in CI to surface more bugsMaxime Chevalier-Boisvert2021-10-201-2/+2
|
* Add graphviz outputAaron Patterson2021-10-201-0/+51
| | | | | | | | | This adds a method to blocks to get outgoing ids, then uses the outgoing ids to generate a graphviz graph. Two methods were added to the Block object. One method returns an id for the block, which is just the address of the underlying block. The other method returns a list of outgoing block ids. We can use Block#id in conjunction with Block#outgoing_ids to construct a graph of blocks
* Warn rather than raise when --yjit-stats is ignoredJean Boussier2021-10-201-1/+1
|
* If --yjit-stats is given without RUBY_DEBUG, that should be an error.Noah Gibbs2021-10-201-0/+7
|
* Allow to enable `--yjit-stats` via a env variableJean Boussier2021-10-201-0/+2
|
* Use builtin_inline_p to avoid pushing a frame for primitive C methods (#63)Maxime Chevalier-Boisvert2021-10-201-13/+0
| | | | | | | | | | | | | * Use builtin_inline_p to skip a frame of C methods * Fix bugs in primitive cfunc call code * Remove if (push_frame) {} * Remove if (push_frame) {} * Push Aaron's fix to avoid hardcoding insn lengths Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* Increase default YJIT call threshold to 10. Add exec mem size arg. (#52)Maxime Chevalier-Boisvert2021-10-201-2/+5
|
* Implement send with blocksAlan Wu2021-10-201-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | * Implement send with blocks Not that much extra work compared to `opt_send_without_block`. Moved the stack over flow check because it could've exited after changes are made to cfp. * rename oswb counters * Might as well implement sending block to cfuncs * Disable sending blocks to cfuncs for now * Reconstruct interpreter sp before calling into cfuncs In case the callee cfunc calls a method or delegates to a block. This also has the side benefit of letting call sites that sometimes are iseq calls and sometimes cfunc call share the same successor. * only sync with interpreter sp when passing a block Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> Co-authored-by: Aaron Patterson <aaron.patterson@shopify.com>
View Lorry Controller Status