From 02ea1fdfc70b01189574a4a640eec3c9c81d2417 Mon Sep 17 00:00:00 2001 From: usa Date: Tue, 1 Oct 2019 10:58:14 +0000 Subject: merge revision(s) a0a2640b398cffd351f87d3f6243103add66575b Fix for wrong fnmatch patttern * dir.c (file_s_fnmatch): ensure that pattern does not contain a NUL character. https://hackerone.com/reports/449617 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_5@67809 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- dir.c | 2 +- test/ruby/test_fnmatch.rb | 6 ++++++ version.h | 8 ++++---- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/dir.c b/dir.c index 351d36157a..40bd4eb193 100644 --- a/dir.c +++ b/dir.c @@ -3020,7 +3020,7 @@ file_s_fnmatch(int argc, VALUE *argv, VALUE obj) else flags = 0; - StringValue(pattern); + StringValueCStr(pattern); FilePathStringValue(path); if (flags & FNM_EXTGLOB) { diff --git a/test/ruby/test_fnmatch.rb b/test/ruby/test_fnmatch.rb index ca01a28698..30250b5a19 100644 --- a/test/ruby/test_fnmatch.rb +++ b/test/ruby/test_fnmatch.rb @@ -129,4 +129,10 @@ class TestFnmatch < Test::Unit::TestCase assert_file.fnmatch("[a-\u3042]*", "\u3042") assert_file.not_fnmatch("[a-\u3042]*", "\u3043") end + + def test_nullchar + assert_raise(ArgumentError) { + File.fnmatch("a\0z", "a") + } + end end diff --git a/version.h b/version.h index 25e5741d3b..f8eb732c56 100644 --- a/version.h +++ b/version.h @@ -1,10 +1,10 @@ #define RUBY_VERSION "2.5.7" -#define RUBY_RELEASE_DATE "2019-09-02" -#define RUBY_PATCHLEVEL 202 +#define RUBY_RELEASE_DATE "2019-10-01" +#define RUBY_PATCHLEVEL 203 #define RUBY_RELEASE_YEAR 2019 -#define RUBY_RELEASE_MONTH 9 -#define RUBY_RELEASE_DAY 2 +#define RUBY_RELEASE_MONTH 10 +#define RUBY_RELEASE_DAY 1 #include "ruby/version.h" -- cgit v1.2.1