From 66d626fdb5b91459d4cc191f767d0d61d056bd83 Mon Sep 17 00:00:00 2001 From: "NARUSE, Yui" Date: Mon, 8 May 2023 12:09:07 +0900 Subject: Skip drb tests on mswin (#7789) * Skip TestDRbSSLAry on mswin This doesn't seem to stably work on mswin: https://github.com/ruby/ruby/actions/runs/3505363753/jobs/5871633211 For CI stability, it generally seems like a bad idea to run druby tests on Windows, given that it's pretty much unstable on MinGW as well. * Do not run drb SSL tests on Windows These tests often cause a timeout and this issue seems specific to the Windows platforms. https://github.com/ruby/ruby/actions/runs/3603761925/jobs/6072346738 --------- Co-authored-by: Takashi Kokubun --- test/drb/test_drbssl.rb | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/test/drb/test_drbssl.rb b/test/drb/test_drbssl.rb index 4369c6614b..0c7e39ca70 100644 --- a/test/drb/test_drbssl.rb +++ b/test/drb/test_drbssl.rb @@ -41,9 +41,9 @@ end class TestDRbSSLCore < Test::Unit::TestCase include DRbCore def setup - if RUBY_PLATFORM.match?(/mingw/) + if RUBY_PLATFORM.match?(/mswin|mingw/) @omitted = true - omit 'This test seems to randomly hang on GitHub Actions MinGW' + omit 'This test seems to randomly hang on Windows' end @drb_service = DRbSSLService.new super @@ -63,6 +63,10 @@ end class TestDRbSSLAry < Test::Unit::TestCase include DRbAry def setup + if RUBY_PLATFORM.match?(/mswin|mingw/) + @omitted = true + omit 'This test seems to randomly hang on Windows' + end LeakChecker.skip if defined?(LeakChecker) @drb_service = DRbSSLService.new super -- cgit v1.2.1