From 85f041c0c5cb3edf2bd062aa19020bde3b4cbc44 Mon Sep 17 00:00:00 2001 From: Takashi Kokubun Date: Fri, 2 Dec 2022 10:18:49 -0800 Subject: Skip a couple of Ractor tests Koichi plans to rework Ractor implementation to address these failures. He agreed to skip flaky Ractor tests for now. --- bootstraptest/test_ractor.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'bootstraptest') diff --git a/bootstraptest/test_ractor.rb b/bootstraptest/test_ractor.rb index ae7ec91704..78a6486c5d 100644 --- a/bootstraptest/test_ractor.rb +++ b/bootstraptest/test_ractor.rb @@ -284,7 +284,8 @@ assert_equal 30.times.map { 'ok' }.to_s, %q{ test i } } unless ENV['RUN_OPTS'] =~ /--mjit-call-threshold=5/ || # This always fails with --mjit-wait --mjit-call-threshold=5 - (ENV.key?('TRAVIS') && ENV['TRAVIS_CPU_ARCH'] == 'arm64') # https://bugs.ruby-lang.org/issues/17878 + (ENV.key?('TRAVIS') && ENV['TRAVIS_CPU_ARCH'] == 'arm64') || # https://bugs.ruby-lang.org/issues/17878 + true # too flaky everywhere http://ci.rvm.jp/results/trunk@ruby-sp1/4321096 # Exception for empty select assert_match /specify at least one ractor/, %q{ @@ -479,6 +480,7 @@ assert_equal 'ok', %q{ } # multiple Ractors can receive (wait) from one Ractor +yjit_enabled = ENV.key?('RUBY_YJIT_ENABLE') || ENV.fetch('RUN_OPTS', '').include?('yjit') assert_equal '[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]', %q{ pipe = Ractor.new do loop do @@ -501,7 +503,7 @@ assert_equal '[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]', %q{ rs.delete r n }.sort -} +} unless yjit_enabled # flaky with YJIT https://github.com/ruby/ruby/actions/runs/3603398545/jobs/6071549328#step:18:33 # Ractor.select also support multiple take, receive and yield assert_equal '[true, true, true]', %q{ -- cgit v1.2.1