From 6b30638bdb729c73a05190587123e43e2ffd69f3 Mon Sep 17 00:00:00 2001 From: Koichi Sasada Date: Thu, 27 Feb 2020 04:06:28 +0900 Subject: MiniTest::Unit.options has default :seed MiniTest::Unit (superclass of Test::Unit::Runner) does not has default seed parameter, but assigned after initializing. However some tests use MiniTest::Unit without setup of seed option and it cases unexpected test failures. To solve this issue, add default seed parameter 42. --- tool/lib/minitest/unit.rb | 2 +- tool/test/minitest/metametameta.rb | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) (limited to 'tool') diff --git a/tool/lib/minitest/unit.rb b/tool/lib/minitest/unit.rb index 0b0d892436..f4e5e4ec8b 100644 --- a/tool/lib/minitest/unit.rb +++ b/tool/lib/minitest/unit.rb @@ -763,7 +763,7 @@ module MiniTest # Lazy accessor for options. def options - @options ||= {} + @options ||= {seed: 42} end @@installed_at_exit ||= false diff --git a/tool/test/minitest/metametameta.rb b/tool/test/minitest/metametameta.rb index f7e0f02798..a12717c8b1 100644 --- a/tool/test/minitest/metametameta.rb +++ b/tool/test/minitest/metametameta.rb @@ -47,7 +47,6 @@ class MetaMetaMetaTestCase < MiniTest::Unit::TestCase srand 42 MiniTest::Unit::TestCase.reset @tu = MiniTest::Unit.new - @tu.options[:seed] = 42 MiniTest::Unit.runner = nil # protect the outer runner from the inner tests end -- cgit v1.2.1