diff options
| author | bors <bors@rust-lang.org> | 2023-04-19 21:36:56 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2023-04-19 21:36:56 +0000 |
| commit | a964608984589fb4190304e7cad14afec993a250 (patch) | |
| tree | a193e27d8ca2bd1c0cc2f024ca34e5a8f760b241 | |
| parent | 4983ced7004f075672e0663ebbc4e8122302f1e1 (diff) | |
| parent | 4e82ee6998753f49f4ac6c08459e8cdc0d0c66a6 (diff) | |
| download | rust-libc-a964608984589fb4190304e7cad14afec993a250.tar.gz | |
Auto merge of #3207 - JohnTitor:placeholder-pr-template, r=JohnTitor
Mention unstable values on PR template
cc #3131
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a4958ba8c5..3e49d7473f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,8 +3,10 @@ Thanks for considering submitting a PR! Here's a checklist for things that will be checked during review or continuous integration. - \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove item(s) +- \[ ] Your PR doesn't contain any *unstable* values like `*LAST` or `*MAX` (see [#3131](https://github.com/rust-lang/libc/issues/3131)) +- \[ ] If your PR increments version number, it must not contain any other changes - \[ ] `rustc ci/style.rs && ./style src` -- \[ ] `cd libc-test && cargo test` (This might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure.) -- \[ ] Your PR that bumps up the crate version doesn't contain any other changes +- \[ ] `cd libc-test && cargo test` + - (this might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure) Delete this line and everything above before opening your PR. |