summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYuki Okushi <jtitor@2k36.org>2023-04-20 04:27:39 +0900
committerYuki Okushi <jtitor@2k36.org>2023-04-20 04:27:39 +0900
commit4e82ee6998753f49f4ac6c08459e8cdc0d0c66a6 (patch)
tree445103b51b68f77170e22d5ae66efb3527edb8ea
parent9cc77816fae6b66172798df7bc975e5faae754f2 (diff)
downloadrust-libc-4e82ee6998753f49f4ac6c08459e8cdc0d0c66a6.tar.gz
Mention unstable values on PR template
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
-rw-r--r--.github/PULL_REQUEST_TEMPLATE.md6
1 files changed, 4 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index a4958ba8c5..3e49d7473f 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -3,8 +3,10 @@ Thanks for considering submitting a PR!
Here's a checklist for things that will be checked during review or continuous integration.
- \[ ] Edit corresponding file(s) under `libc-test/semver` when you add/remove item(s)
+- \[ ] Your PR doesn't contain any *unstable* values like `*LAST` or `*MAX` (see [#3131](https://github.com/rust-lang/libc/issues/3131))
+- \[ ] If your PR increments version number, it must not contain any other changes
- \[ ] `rustc ci/style.rs && ./style src`
-- \[ ] `cd libc-test && cargo test` (This might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure.)
-- \[ ] Your PR that bumps up the crate version doesn't contain any other changes
+- \[ ] `cd libc-test && cargo test`
+ - (this might fail on your env due to environment difference between your env and CI. Ignore failures if you are not sure)
Delete this line and everything above before opening your PR.