diff options
| author | Kleis Auke Wolthuizen <github@kleisauke.nl> | 2023-01-23 17:32:29 +0100 |
|---|---|---|
| committer | Kleis Auke Wolthuizen <github@kleisauke.nl> | 2023-01-23 17:40:19 +0100 |
| commit | 03b410a6b2ab951a63b86091b54557d2e637f7bd (patch) | |
| tree | 3b3c2fe37c8787a05a7ad5f85017d8b0c1a8b0bf /libc-test/build.rs | |
| parent | d6c991e32c3f058131d8c8c2fa2f2133987df684 (diff) | |
| download | rust-libc-03b410a6b2ab951a63b86091b54557d2e637f7bd.tar.gz | |
Update a couple of comments
Diffstat (limited to 'libc-test/build.rs')
| -rw-r--r-- | libc-test/build.rs | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/libc-test/build.rs b/libc-test/build.rs index f98dbbfe84..c1a42784c0 100644 --- a/libc-test/build.rs +++ b/libc-test/build.rs @@ -2566,7 +2566,8 @@ fn test_emscripten(target: &str) { // FIXME: The size has been changed when upgraded to musl 1.2.2 "pthread_mutex_t" => true, - // FIXME: The size has been changed + // FIXME: Lowered from 16 to 8 bytes in + // llvm/llvm-project@d1a96e9 "max_align_t" => true, // FIXME: The size has been changed due to time64 @@ -2579,20 +2580,13 @@ fn test_emscripten(target: &str) { cfg.skip_fn(move |name| { match name { - // FIXME: https://github.com/rust-lang/libc/issues/1272 - "execv" | "execve" | "execvp" | "execvpe" | "fexecve" => true, + // Emscripten does not support fork/exec/wait or any kind of multi-process support + // https://github.com/emscripten-core/emscripten/blob/3.1.30/tools/system_libs.py#L973 + "execv" | "execve" | "execvp" | "execvpe" | "fexecve" | "wait4" => true, - // FIXME: Investigate why CI is missing it. + // FIXME: Remove after emscripten-core/emscripten#18492 is released (> 3.1.30). "clearenv" => true, - // FIXME: Somehow the ctest cannot find it on emscripten: - // = note: error: undefined symbol: wait4 (referenced by top-level compiled C/C++ code) - // warning: Link with `-sLLD_REPORT_UNDEFINED` to get more information on undefined symbols - // warning: To disable errors for undefined symbols use `-sERROR_ON_UNDEFINED_SYMBOLS=0` - // warning: _wait4 may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library - // Error: Aborting compilation due to previous errors - "wait4" => true, - _ => false, } }); |