From 204aee3c422370b82b656e0b7d11889c244464e1 Mon Sep 17 00:00:00 2001 From: Yuki Okushi Date: Wed, 22 Feb 2023 19:27:40 +0900 Subject: Drop semver check job on CI Signed-off-by: Yuki Okushi --- .github/workflows/bors.yml | 26 --------------- ci/semver.sh | 75 ------------------------------------------ libc-test/semver/linux-gnu.txt | 2 +- 3 files changed, 1 insertion(+), 102 deletions(-) delete mode 100644 ci/semver.sh diff --git a/.github/workflows/bors.yml b/.github/workflows/bors.yml index fc9a5b6ec3..49a06de686 100644 --- a/.github/workflows/bors.yml +++ b/.github/workflows/bors.yml @@ -317,32 +317,6 @@ jobs: run: LIBC_CI=1 TOOLCHAIN=${{ matrix.toolchain }} WIN_TARGET=${{ matrix.target }} sh ./ci/build.sh shell: bash - semver_linux: - if: ${{ false }} # This is currently broken - name: Semver Linux - runs-on: ubuntu-22.04 - continue-on-error: true - steps: - - uses: actions/checkout@v3 - - name: Setup Rust toolchain - # Should update the semverver revision in semver.sh if we touch nightly ver. - run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh - - name: Check breaking changes - run: sh ci/semver.sh linux - - semver_macos: - if: ${{ false }} # This is currently broken - name: Semver macOS - runs-on: macos-12 - continue-on-error: true - steps: - - uses: actions/checkout@v3 - - name: Setup Rust toolchain - # Pin nightly version to make semverver compilable. - run: TOOLCHAIN=nightly-2022-05-23 sh ./ci/install-rust.sh - - name: Check breaking changes - run: sh ci/semver.sh macos - docs: permissions: actions: write # to cancel workflows (rust-lang/simpleinfra/github-actions/cancel-outdated-builds) diff --git a/ci/semver.sh b/ci/semver.sh deleted file mode 100644 index 9f81d335ca..0000000000 --- a/ci/semver.sh +++ /dev/null @@ -1,75 +0,0 @@ -#!/usr/bin/env sh - -# Checks that libc does not contain breaking changes for the following targets. - -set -ex - -OS=${1} - -echo "Testing Semver on ${OS}" - -if ! rustc --version | grep -E "nightly" ; then - echo "Building semverver requires a nightly Rust toolchain" - exit 1 -fi - -rustup component add rustc-dev llvm-tools-preview - -# Should update the nightly version in bors CI config if we touch this. -cargo install semverver --version=0.1.50 - -TARGETS= -case "${OS}" in - *linux*) - TARGETS="\ -aarch64-unknown-fuchsia \ -aarch64-linux-android \ -aarch64-unknown-linux-gnu \ -aarch64-unknown-linux-musl \ -armv7-linux-androideabi \ -armv7-unknown-linux-gnueabihf \ -i586-unknown-linux-gnu \ -i586-unknown-linux-musl \ -i686-linux-android \ -i686-unknown-freebsd \ -i686-unknown-linux-gnu \ -i686-unknown-linux-musl \ -i686-pc-windows-gnu \ -x86_64-unknown-freebsd \ -x86_64-unknown-linux-gnu \ -x86_64-unknown-linux-musl \ -x86_64-unknown-netbsd \ -x86_64-pc-solaris \ -x86_64-unknown-fuchsia \ -x86_64-pc-windows-gnu \ -x86_64-unknown-linux-gnux32 \ -x86_64-unknown-redox \ -x86_64-fortanix-unknown-sgx \ -wasm32-unknown-unknown \ -" - ;; - *macos*) - TARGETS="\ -aarch64-apple-ios \ -x86_64-apple-darwin \ -x86_64-apple-ios \ -" - ;; -esac - -for TARGET in $TARGETS; do - # FIXME: rustup often fails to download some artifacts due to network - # issues, so we retry this N times. - N=5 - n=0 - until [ $n -ge $N ] - do - if rustup target add "${TARGET}" ; then - break - fi - n=$((n+1)) - sleep 1 - done - - cargo semver --api-guidelines --target="${TARGET}" -done diff --git a/libc-test/semver/linux-gnu.txt b/libc-test/semver/linux-gnu.txt index 736a8d2a56..f34e0681c3 100644 --- a/libc-test/semver/linux-gnu.txt +++ b/libc-test/semver/linux-gnu.txt @@ -669,4 +669,4 @@ strftime strptime dirname posix_basename -gnu_basename \ No newline at end of file +gnu_basename -- cgit v1.2.1