diff options
| author | bors <bors@rust-lang.org> | 2022-12-13 18:46:35 +0000 |
|---|---|---|
| committer | bors <bors@rust-lang.org> | 2022-12-13 18:46:35 +0000 |
| commit | 0f529f0f49f4dd404b78e605398531c96f220fc5 (patch) | |
| tree | 89622414130b3793f214fc25dd77051c5bc467ab /tests/rustdoc-js-std/parser-errors.js | |
| parent | aa5b179599427ef233c4e47db8dac6edae22b4f8 (diff) | |
| parent | 05bc2513ef55a3b71c7ccbda41f07be9f10f3a7f (diff) | |
| download | rust-0f529f0f49f4dd404b78e605398531c96f220fc5.tar.gz | |
Auto merge of #102813 - Akida31:issue-64915/simpler_diagnostic_when_passing_arg_to_closure_and_missing_borrow, r=estebank
Simpler diagnostic when passing arg to closure and missing borrow
fixes #64915
I followed roughly the instructions and the older PR #76362.
The number of references for the expected and the found types will be compared and depending on which has more the diagnostic will be emitted.
I'm not quite sure if my approach with the many `span_bug!`s is good, it could lead to some ICEs. Would it be better if those errors are ignored?
As far as I know the following code works similarly but in a different context. Is this probably reusable since it looks like it would emit better diagnostics?
https://github.com/rust-lang/rust/blob/a688a0305fad9219505a8f2576446510601bafe8/compiler/rustc_hir_analysis/src/check/demand.rs#L713-L1061
When running the tests locally, a codegen test failed. Is there something I can/ should do about that?
If you have some improvements/ corrections please say so and I will happily include them.
r? `@estebank` (as you added the mentoring instructions to the issue)
Diffstat (limited to 'tests/rustdoc-js-std/parser-errors.js')
0 files changed, 0 insertions, 0 deletions