diff options
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | 2023-01-27 07:57:27 +1300 |
|---|---|---|
| committer | Jule Anger <janger@samba.org> | 2023-03-20 10:03:50 +0100 |
| commit | 88b5d9215c6f712ad1932604e2830edd111a5618 (patch) | |
| tree | 4bd4be785908e4baec55c7c93c73711016e49ceb | |
| parent | 90b5fddb8269de4fc8ca33dda3c9f0f3a7aee075 (diff) | |
| download | samba-88b5d9215c6f712ad1932604e2830edd111a5618.tar.gz | |
CVE-2023-0614 libcli/security: Make some parameters const
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15270
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| -rw-r--r-- | libcli/security/access_check.c | 10 | ||||
| -rw-r--r-- | libcli/security/access_check.h | 2 |
2 files changed, 6 insertions, 6 deletions
diff --git a/libcli/security/access_check.c b/libcli/security/access_check.c index 7d8eca74c43..70d8b9f0155 100644 --- a/libcli/security/access_check.c +++ b/libcli/security/access_check.c @@ -431,7 +431,7 @@ NTSTATUS se_file_access_check(const struct security_descriptor *sd, return NT_STATUS_OK; } -static const struct GUID *get_ace_object_type(struct security_ace *ace) +static const struct GUID *get_ace_object_type(const struct security_ace *ace) { if (ace->object.object.flags & SEC_ACE_OBJECT_TYPE_PRESENT) { return &ace->object.object.type.type; @@ -449,7 +449,7 @@ static const struct GUID *get_ace_object_type(struct security_ace *ace) * rights to the object/attribute * @returns NT_STATUS_OK, unless access was denied */ -static NTSTATUS check_object_specific_access(struct security_ace *ace, +static NTSTATUS check_object_specific_access(const struct security_ace *ace, struct object_tree *tree, bool *grant_access) { @@ -520,7 +520,7 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd uint32_t access_desired, uint32_t *access_granted, struct object_tree *tree, - struct dom_sid *replace_sid, + const struct dom_sid *replace_sid, enum implicit_owner_rights implicit_owner_rights) { uint32_t i; @@ -579,8 +579,8 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd /* check each ace in turn. */ for (i=0; bits_remaining && i < sd->dacl->num_aces; i++) { - struct dom_sid *trustee; - struct security_ace *ace = &sd->dacl->aces[i]; + const struct dom_sid *trustee; + const struct security_ace *ace = &sd->dacl->aces[i]; NTSTATUS status; bool grant_access = false; diff --git a/libcli/security/access_check.h b/libcli/security/access_check.h index e7150914524..7c424b9e05a 100644 --- a/libcli/security/access_check.h +++ b/libcli/security/access_check.h @@ -70,7 +70,7 @@ NTSTATUS sec_access_check_ds_implicit_owner(const struct security_descriptor *sd uint32_t access_desired, uint32_t *access_granted, struct object_tree *tree, - struct dom_sid *replace_sid, + const struct dom_sid *replace_sid, enum implicit_owner_rights implicit_owner_rights); /* modified access check for the purposes of DS security |