summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2020-09-16 12:48:21 -0700
committerKarolin Seeger <kseeger@samba.org>2020-09-18 12:45:37 +0200
commitd5926ad40ffc31a9b0f6e2cb66d47aa58e1e5e4e (patch)
treef907cec591cb4fa78cfc366925885a949e23d388
parent9b174d71541ec60157c17938551d8c9b429e578f (diff)
downloadsamba-d5926ad40ffc31a9b0f6e2cb66d47aa58e1e5e4e.tar.gz
CVE-2020-1472(ZeroLogon): s3:rpc_server/netlogon: Fix mem leak onto p->mem_ctx in error path of _netr_ServerPasswordSet2().
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14497 Signed-off-by: Jeremy Allison <jra@samba.org> [dbagnall@samba.org, abartlet@samba.org: adapt for indentation changes]
-rw-r--r--source3/rpc_server/netlogon/srv_netlog_nt.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
index 3894eecd7ae..bc5ec654a95 100644
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
@@ -1364,6 +1364,7 @@ NTSTATUS _netr_ServerPasswordSet2(struct pipes_struct *p,
password_buf.data,
516);
if (!NT_STATUS_IS_OK(status)) {
+ TALLOC_FREE(creds);
return status;
}
}