summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Metzmacher <metze@samba.org>2019-03-21 16:38:35 +0100
committerJule Anger <janger@samba.org>2023-04-05 10:40:13 +0000
commite804feaf76d3609e0f69a4bb1cc9d42934c221d3 (patch)
tree49f7ba791b6ec68405d099d682df5e54e56d46f7
parentfd7e0aaa196c83f28d76a0309d09c27e5eedae59 (diff)
downloadsamba-e804feaf76d3609e0f69a4bb1cc9d42934c221d3.tar.gz
idmap_hash: provide ID_TYPE_BOTH mappings also for unixids_to_sids
While sids_to_unixids returns ID_TYPE_BOTH mappings, unixids_to_sids() returns the callers asked for, which fills gencache with the non ID_TYPE_BOTH mappings. As a result also the sids_to_unixids fast path via gencache won't return ID_TYPE_BOTH mappings. BUG: https://bugzilla.samba.org/show_bug.cgi?id=15319 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> (cherry picked from commit 9a24570d3d69f51b6d50bb04b739815ec67c1a3d)
-rw-r--r--source3/winbindd/idmap_hash/idmap_hash.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/source3/winbindd/idmap_hash/idmap_hash.c b/source3/winbindd/idmap_hash/idmap_hash.c
index d0bed7631a6..ec85119b063 100644
--- a/source3/winbindd/idmap_hash/idmap_hash.c
+++ b/source3/winbindd/idmap_hash/idmap_hash.c
@@ -224,6 +224,7 @@ static NTSTATUS unixids_to_sids(struct idmap_domain *dom,
if (!hashed_domains[h_domain].sid)
continue;
+ ids[i]->xid.type = ID_TYPE_BOTH;
sid_compose(ids[i]->sid, hashed_domains[h_domain].sid, h_rid);
ids[i]->status = ID_MAPPED;
}