From 02e6970ad65c1b1681d9581917130651d3431ede Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Tue, 9 May 2023 14:53:33 +1200 Subject: s4:kdc: Fix leaks Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- source4/kdc/db-glue.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source4/kdc/db-glue.c b/source4/kdc/db-glue.c index bff6d0b165b..be8bd7e3293 100644 --- a/source4/kdc/db-glue.c +++ b/source4/kdc/db-glue.c @@ -2997,6 +2997,7 @@ krb5_error_code samba_kdc_firstkey(krb5_context context, if (!mem_ctx) { ret = ENOMEM; krb5_set_error_message(context, ret, "samba_kdc_firstkey: talloc_named() failed!"); + TALLOC_FREE(priv); return ret; } @@ -3170,6 +3171,7 @@ samba_kdc_check_s4u2proxy(krb5_context context, krb5_set_error_message(context, ret, "samba_kdc_check_s4u2proxy:" " ldb_dn_get_linearized() failed!"); + talloc_free(mem_ctx); return ret; } @@ -3187,6 +3189,7 @@ samba_kdc_check_s4u2proxy(krb5_context context, * delegation target, allow to forward. */ if (target_principal == NULL) { + talloc_free(mem_ctx); return 0; } @@ -3218,6 +3221,7 @@ samba_kdc_check_s4u2proxy(krb5_context context, krb5_set_error_message(context, ret, "samba_kdc_check_s4u2proxy:" " talloc_strdup() failed!"); + talloc_free(mem_ctx); return ret; } @@ -3471,6 +3475,7 @@ NTSTATUS samba_kdc_setup_db_ctx(TALLOC_CTX *mem_ctx, struct samba_kdc_base_conte session_info = system_session(kdc_db_ctx->lp_ctx); if (session_info == NULL) { + talloc_free(kdc_db_ctx); return NT_STATUS_INTERNAL_ERROR; } -- cgit v1.2.1