From 0c6fb4bfb01254d565d5b8308b24447d926b5085 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Thu, 20 Apr 2023 13:09:26 +0200 Subject: dfs_server: Fix debug statement if searched_site is NULL MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In file included from source4/include/includes.h:61, from dfs_server/dfs_server_ad.c:21: dfs_server/dfs_server_ad.c: In function ‘get_dcs.constprop’: lib/util/debug.h:200:12: error: ‘%s’ directive argument is null [-Werror=format-overflow=] 200 | && (dbgtext body) ) | ~^~~~~~~~~~~~~ dfs_server/dfs_server_ad.c:462:25: note: in expansion of macro ‘DEBUG’ 462 | DEBUG(2,(__location__ ": Site: %s %s\n", | ^~~~~ Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- dfs_server/dfs_server_ad.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'dfs_server') diff --git a/dfs_server/dfs_server_ad.c b/dfs_server/dfs_server_ad.c index b97d0882f94..f992042966e 100644 --- a/dfs_server/dfs_server_ad.c +++ b/dfs_server/dfs_server_ad.c @@ -459,8 +459,11 @@ static NTSTATUS get_dcs(TALLOC_CTX *ctx, struct ldb_context *ldb, if (searched_site == NULL || strcmp(searched_site, site_name) != 0) { - DEBUG(2,(__location__ ": Site: %s %s\n", - searched_site, site_name)); + DEBUG(2, + (__location__ ": Site: %s %s\n", + searched_site != NULL ? searched_site + : "UNKNOWN", + site_name)); /* * Do all the site but the one of the client -- cgit v1.2.1