diff options
author | Steven Knight <knight@baldmt.com> | 2004-12-14 15:18:32 +0000 |
---|---|---|
committer | Steven Knight <knight@baldmt.com> | 2004-12-14 15:18:32 +0000 |
commit | 7fb6f3fba8fee089062cb3a5159037d80abd55b7 (patch) | |
tree | caafbee0d32da27cabad29c000b4ec4a7b064cad /src/engine/SCons | |
parent | 3953f0e69aae524012d80ea6b1c86bf4393d8cf9 (diff) | |
download | scons-7fb6f3fba8fee089062cb3a5159037d80abd55b7.tar.gz |
Remove unnecessary scan keyword argument from Node.current(). (Kevin Quick)
Diffstat (limited to 'src/engine/SCons')
-rw-r--r-- | src/engine/SCons/Node/FS.py | 2 | ||||
-rw-r--r-- | src/engine/SCons/Node/NodeTests.py | 7 | ||||
-rw-r--r-- | src/engine/SCons/Node/__init__.py | 2 |
3 files changed, 8 insertions, 3 deletions
diff --git a/src/engine/SCons/Node/FS.py b/src/engine/SCons/Node/FS.py index c381b8a6..bc9e6829 100644 --- a/src/engine/SCons/Node/FS.py +++ b/src/engine/SCons/Node/FS.py @@ -1769,7 +1769,7 @@ class File(Base): return csig - def current(self, calc=None, scan=1): + def current(self, calc=None): self.binfo = self.gen_binfo(calc) if self.always_build: return None diff --git a/src/engine/SCons/Node/NodeTests.py b/src/engine/SCons/Node/NodeTests.py index d85be8bb..7282f80c 100644 --- a/src/engine/SCons/Node/NodeTests.py +++ b/src/engine/SCons/Node/NodeTests.py @@ -115,12 +115,15 @@ class Environment: return apply(Environment, (), d) def _update(self, dict): self._dict.update(dict) + def get_calculator(self): + return SCons.Sig.default_calc class Builder: def __init__(self, is_explicit=1): self.env = Environment() self.overrides = {} self.action = MyAction() + self.source_factory = MyNode self.is_explicit = is_explicit def targets(self, t): return [t] @@ -862,12 +865,14 @@ class NodeTestCase(unittest.TestCase): try: sn = StoredNode("eee") sn._children = ['fake'] + sn.builder_set(Builder()) sn.target_scanner = s sn.scan() assert sn.implicit == [], sn.implicit - assert not hasattr(sn, '_children'), "unexpected _children attribute" + assert sn._children == [], sn._children + finally: SCons.Sig.default_calc = save_default_calc SCons.Node.implicit_cache = save_implicit_cache diff --git a/src/engine/SCons/Node/__init__.py b/src/engine/SCons/Node/__init__.py index fc3d7ec4..3b0d3a46 100644 --- a/src/engine/SCons/Node/__init__.py +++ b/src/engine/SCons/Node/__init__.py @@ -463,7 +463,7 @@ class Node: implicit = map(self.implicit_factory, implicit) self._add_child(self.implicit, self.implicit_dict, implicit) calc = build_env.get_calculator() - if implicit_deps_unchanged or self.current(calc, scan=0): + if implicit_deps_unchanged or self.current(calc): return else: # one of this node's sources has changed, so |