From 334f648b1479c4cab6c887604e3f67930966311d Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Tue, 10 Jan 2012 22:52:17 -0500 Subject: Fixed typo in mask comparison Bl0ckeduser I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS Classic). All the tests worked without issues, but the compiler gave this warning [formatting edited for email format]: } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) { ":src:video:SDL_video.c"; line 990 #Warning 2: possible unintended assignment I discussed this with another programmer and we came to the conclusion that this is probably a typo. I have checked the latest mercurial sources, and the possible typo is still there. Bl0ckeduser --- src/video/SDL_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video/SDL_video.c b/src/video/SDL_video.c index b226e0376..46285c990 100644 --- a/src/video/SDL_video.c +++ b/src/video/SDL_video.c @@ -987,7 +987,7 @@ SDL_Surface *SDL_DisplayFormatAlpha(SDL_Surface *surface) if ( (vf->Rmask == 0xff) && (vf->Bmask == 0xff0000) ) { rmask = 0xff; bmask = 0xff0000; - } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) { + } else if ( vf->Rmask == 0xFF00 && (vf->Bmask == 0xFF000000) ) { amask = 0x000000FF; rmask = 0x0000FF00; gmask = 0x00FF0000; -- cgit v1.2.1