diff options
author | Bilal Alsharifi <bilal.alsharifi@gmail.com> | 2021-08-10 17:25:30 -0400 |
---|---|---|
committer | Bilal Alsharifi <bilal.alsharifi@gmail.com> | 2021-08-10 17:25:30 -0400 |
commit | dca0119b642a6706abaaa149b6a6cf3d4faf8110 (patch) | |
tree | e046e6cded7a0aabe8f66e6df32b024b51a5ccd3 | |
parent | c2609d0b79a8dfc9e869e32d7dc86f61ff0b7771 (diff) | |
download | sdl_android-dca0119b642a6706abaaa149b6a6cf3d4faf8110.tar.gz |
Fix issue in menuCellsAreUnique
-rw-r--r-- | base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseMenuManager.java | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseMenuManager.java b/base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseMenuManager.java index 33f004171..82aafd50f 100644 --- a/base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseMenuManager.java +++ b/base/src/main/java/com/smartdevicelink/managers/screen/menu/BaseMenuManager.java @@ -448,10 +448,6 @@ abstract class BaseMenuManager extends BaseSubManager { HashSet<MenuCell> identicalCellsCheckSet = new HashSet<>(); for (MenuCell cell : cells) { - // We don't want the UniqueTitle & listener to be considered in uniqueness check - cell.setUniqueTitle(null); - cell.setMenuSelectionListener(null); - identicalCellsCheckSet.add(cell); // Recursively check the sub-cell lists to see if they are all unique as well. If anything is not, this will chain back up the list to return false. @@ -472,7 +468,7 @@ abstract class BaseMenuManager extends BaseSubManager { // Check for duplicate cells if (identicalCellsCheckSet.size() != cells.size()) { - DebugTool.logError(TAG, "Not all cells are unique. The menu will not be set."); + DebugTool.logError(TAG, "Not all cells are unique. Cells in each list (such as main menu or sub cell list) must have some differentiating property other than the sub cells within a cell. The menu will not be set."); return false; } |