diff options
| author | Joey Grover <joeygrover@gmail.com> | 2018-11-19 15:07:09 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-11-19 15:07:09 -0500 |
| commit | 84e9078d3ce846ef344b21a1a405415964587515 (patch) | |
| tree | 112083711d479c5617941374e66dca0af7990972 | |
| parent | 0260a49e018032fec83a93876f4450a69eaf6edd (diff) | |
| parent | 4d2937cfd4474c0f813718c03c368c453624d449 (diff) | |
| download | sdl_android-84e9078d3ce846ef344b21a1a405415964587515.tar.gz | |
Merge pull request #915 from smartdevicelink/hotfix/pull_request_template
add best practices link and review info to PR template
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8581b12e8..14e81feee 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_android/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA. +[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_android/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @joeygrover. Delete the above section when you've read it.] @@ -30,4 +30,4 @@ This PR makes **[no / minor / major]** API changes. - [ ] [Task 2] ### CLA -- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)
\ No newline at end of file +- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform) |