summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBilal Alsharifi <bilal.alsharifi@gmail.com>2020-08-18 14:36:18 -0400
committerBilal Alsharifi <bilal.alsharifi@gmail.com>2020-08-18 14:36:18 -0400
commita485667a567a1adffc62f013998138423cc01fda (patch)
tree2bbd9866921e61b16fd069ab6eee2d5a384ac8f9
parent1d85d37fd2c7845182a0eed0db2a8b104b9f8944 (diff)
downloadsdl_android-a485667a567a1adffc62f013998138423cc01fda.tar.gz
Remove onError from response listener
-rw-r--r--base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnMultipleRequestListener.java13
-rw-r--r--base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnRPCResponseListener.java18
2 files changed, 0 insertions, 31 deletions
diff --git a/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnMultipleRequestListener.java b/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnMultipleRequestListener.java
index 462a73283..f62f2cafd 100644
--- a/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnMultipleRequestListener.java
+++ b/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnMultipleRequestListener.java
@@ -43,7 +43,6 @@ public abstract class OnMultipleRequestListener extends OnRPCResponseListener {
final Vector<Integer> correlationIds;
OnRPCResponseListener rpcResponseListener;
- private static String TAG = "OnMultipleRequestListener";
public OnMultipleRequestListener(){
setListenerType(UPDATE_LISTENER_TYPE_MULTIPLE_REQUESTS);
@@ -53,17 +52,6 @@ public abstract class OnMultipleRequestListener extends OnRPCResponseListener {
@Override
public void onResponse(int correlationId, RPCResponse response) {
OnMultipleRequestListener.this.onResponse(correlationId, response);
- update(correlationId);
- }
-
- @Override
- public void onError(int correlationId, Result resultCode, String info) {
- super.onError(correlationId, resultCode, info);
- OnMultipleRequestListener.this.onError(correlationId, resultCode, info);
- update(correlationId);
- }
-
- private synchronized void update(int correlationId){
correlationIds.remove(Integer.valueOf(correlationId));
onUpdate(correlationIds.size());
if(correlationIds.size() == 0){
@@ -82,7 +70,6 @@ public abstract class OnMultipleRequestListener extends OnRPCResponseListener {
*/
public abstract void onUpdate(int remainingRequests);
public abstract void onFinished();
- public abstract void onError(int correlationId, Result resultCode, String info);
public OnRPCResponseListener getSingleRpcResponseListener(){
return rpcResponseListener;
diff --git a/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnRPCResponseListener.java b/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnRPCResponseListener.java
index 89b082326..b5aacd370 100644
--- a/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnRPCResponseListener.java
+++ b/base/src/main/java/com/smartdevicelink/proxy/rpc/listeners/OnRPCResponseListener.java
@@ -68,22 +68,4 @@ public abstract class OnRPCResponseListener extends OnRPCListener {
* for a PutFile request, the message parameter should be cast to a PutFileResponse class.
*/
public abstract void onResponse(int correlationId, final RPCResponse response);
-
- /**
- * @deprecated This method has been deprecated in favor of just using the onResponse callback. In the next
- * version this method will be removed and all responses successful or not will be returned
- * through the onResponse method callback.
- *
- * Called when there was some sort of error during the original request.
- * @param correlationId
- * @param resultCode
- * @param info
- */
- @Deprecated
- public void onError(int correlationId, Result resultCode, String info){
-
- };
-
-
-
}