Return void from log methodsbugfix/fix_log

3 files changed, 13 insertions, 20 deletions

diff --git a/android/sdl_android/src/main/java/com/smartdevicelink/util/Log.java b/android/sdl_android/src/main/java/com/smartdevicelink/util/Log.java
index b769055f5..c6f2d2649 100644
--- a/android/sdl_android/src/main/java/com/smartdevicelink/util/Log.java
+++ b/android/sdl_android/src/main/java/com/smartdevicelink/util/Log.java
@@ -1,19 +1,19 @@
 package com.smartdevicelink.util;
 
 public class Log {
-    public static int i(String tag, String message) {
-        return android.util.Log.i(tag, message);
+    public static void i(String tag, String message) {
+        android.util.Log.i(tag, message);
     }
 
-    public static int w(String tag, String message) {
-        return android.util.Log.w(tag, message);
+    public static void w(String tag, String message) {
+        android.util.Log.w(tag, message);
     }
 
-    public static int e(String tag, String message, Throwable t) {
+    public static void e(String tag, String message, Throwable t) {
         if (t != null) {
-            return android.util.Log.e(tag, message, t);
+            android.util.Log.e(tag, message, t);
         } else {
-            return android.util.Log.e(tag, message);
+            android.util.Log.e(tag, message);
         }
     }
 }
\ No newline at end of file
diff --git a/base/src/main/java/com/smartdevicelink/util/NativeLogTool.java b/base/src/main/java/com/smartdevicelink/util/NativeLogTool.java
index 5c5b15d11..b0e3217cb 100644
--- a/base/src/main/java/com/smartdevicelink/util/NativeLogTool.java
+++ b/base/src/main/java/com/smartdevicelink/util/NativeLogTool.java
@@ -109,7 +109,6 @@ public class NativeLogTool {
 			return false;

 		}

 

-		int bytesWritten = 0;

 		int substrSize = 0;

 		String chunk = null;

 		try {

@@ -118,18 +117,15 @@ public class NativeLogTool {
 				chunk = logMsg.substring(idx, idx + substrSize);

 				switch (ltarg) {

 					case Info:

-						bytesWritten = Log.i(source, chunk);

+						Log.i(source, chunk);

 						break;

 					case Warning:

-						bytesWritten = Log.w(source, chunk);

+						Log.w(source, chunk);

 						break;

 					case Error:

-						bytesWritten = Log.e(source, chunk, null);

+						Log.e(source, chunk, null);

 						break;

 				}

-				if (bytesWritten < chunk.length()) {

-					Log.w(TAG, "Calling Log.w: msg length=" + chunk.length() + ", bytesWritten=" + bytesWritten);

-				}

 			}			

 		} catch (Exception ex) {

 			Log.e(TAG, "Failure writing " + ltarg.name() + " fragments to android log:" + ex.toString(), null);

diff --git a/javaSE/src/main/java/com/smartdevicelink/util/Log.java b/javaSE/src/main/java/com/smartdevicelink/util/Log.java
index 93dc3b0ad..2de00692c 100644
--- a/javaSE/src/main/java/com/smartdevicelink/util/Log.java
+++ b/javaSE/src/main/java/com/smartdevicelink/util/Log.java
@@ -1,22 +1,19 @@
 package com.smartdevicelink.util;
 
 public class Log {
-    public static int i(String tag, String message) {
+    public static void i(String tag, String message) {
         System.out.print("\r\nINFO: " + tag + " - " + message);
-        return 4000;
     }
 
-    public static int w(String tag, String message) {
+    public static void w(String tag, String message) {
         System.out.print("\r\nWARN: " + tag + " - " + message);
-        return 4000;
     }
 
-    public static int e(String tag, String message, Throwable t) {
+    public static void e(String tag, String message, Throwable t) {
         if (t != null) {
             System.out.print("\r\nERROR: " + tag + " - " + message + " - " + t.getMessage());
         } else {
             System.out.print("\r\nERROR: " + tag + " - " + message);
         }
-        return 4000;
     }
 }
\ No newline at end of file