summaryrefslogtreecommitdiff
path: root/base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java
diff options
context:
space:
mode:
authorJulian Kast <julian@livio.com>2020-08-20 21:00:43 -0400
committerJulian Kast <julian@livio.com>2020-08-20 21:00:43 -0400
commit43f81dff43becf0bf6b37f2bbd78736ea189d194 (patch)
tree17d25e1367b4bb457d289f4996d71dc519ff55eb /base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java
parent6addbc1143d00c13ff42ebf33fc10db9deb76719 (diff)
downloadsdl_android-43f81dff43becf0bf6b37f2bbd78736ea189d194.tar.gz
Fixed future potential NPE
Diffstat (limited to 'base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java')
-rw-r--r--base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java6
1 files changed, 3 insertions, 3 deletions
diff --git a/base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java b/base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java
index 259d5debc..4028b1a44 100644
--- a/base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java
+++ b/base/src/main/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperation.java
@@ -214,10 +214,10 @@ public class TextAndGraphicUpdateOperation extends Task {
return show;
}
- private Show createImageOnlyShowWithPrimaryArtwork(SdlArtwork primaryArtwork, SdlArtwork secondaryArtwork) {
+ Show createImageOnlyShowWithPrimaryArtwork(SdlArtwork primaryArtwork, SdlArtwork secondaryArtwork) {
Show newShow = new Show();
- newShow.setGraphic(!(sdlArtworkNeedsUpload(primaryArtwork)) ? primaryArtwork.getImageRPC() : null);
- newShow.setSecondaryGraphic(!(sdlArtworkNeedsUpload(secondaryArtwork)) ? secondaryArtwork.getImageRPC() : null);
+ newShow.setGraphic((primaryArtwork != null && !(sdlArtworkNeedsUpload(primaryArtwork))) ? primaryArtwork.getImageRPC() : null);
+ newShow.setSecondaryGraphic((secondaryArtwork != null && !(sdlArtworkNeedsUpload(secondaryArtwork))) ? secondaryArtwork.getImageRPC() : null);
if (newShow.getGraphic() == null && newShow.getSecondaryGraphic() == null) {
DebugTool.logInfo(TAG, "No graphics to upload");
return null;