From ed0591873c155e44f18cf60915447a010065f6d6 Mon Sep 17 00:00:00 2001 From: Julian Kast Date: Thu, 30 Sep 2021 14:02:46 -0400 Subject: code review suggestions --- .../com/smartdevicelink/managers/file/DeleteFileOperation.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java b/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java index b732a525f..522c5c7e9 100644 --- a/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java +++ b/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java @@ -70,10 +70,12 @@ class DeleteFileOperation extends Task { if (getState() == Task.CANCELED) { return; } - if (!mutableRemoteFileNames.contains(fileName) && completionListener != null) { - String errorMessage = "File to delete is no longer on the head unit, aborting operation"; - // Returning BaseFileManager.SPACE_AVAILABLE_MAX_VALUE for bytesAvaialble as a placeHolder, it will not get updated in BaseFileManager as long as success returned is false. - completionListener.onComplete(false, BaseFileManager.SPACE_AVAILABLE_MAX_VALUE, mutableRemoteFileNames, errorMessage); + if (!mutableRemoteFileNames.contains(fileName)) { + if (completionListener != null) { + String errorMessage = "File to delete is no longer on the head unit, aborting operation"; + // Returning BaseFileManager.SPACE_AVAILABLE_MAX_VALUE for bytesAvaialble as a placeHolder, it will not get updated in BaseFileManager as long as success returned is false. + completionListener.onComplete(false, BaseFileManager.SPACE_AVAILABLE_MAX_VALUE, mutableRemoteFileNames, errorMessage); + } onFinished(); return; } -- cgit v1.2.1