diff options
| author | JackLivio <jack@livio.io> | 2019-07-17 13:49:03 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-17 13:49:03 -0400 |
| commit | 4505a975445c1a04ec85460122abda49500cbfae (patch) | |
| tree | 8a438b18e69c61db3cb0c70714cb9c19899782a2 | |
| parent | 1e3a86da29ece1e05543b7facb470f7e6f4a63eb (diff) | |
| download | sdl_core-4505a975445c1a04ec85460122abda49500cbfae.tar.gz | |
Apply suggestions from code review
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
| -rw-r--r-- | src/components/interfaces/HMI_API.xml | 2 | ||||
| -rw-r--r-- | src/components/interfaces/MOBILE_API.xml | 6 | ||||
| -rw-r--r-- | src/components/policy/policy_external/src/policy_table/enums.cc | 2 |
3 files changed, 5 insertions, 5 deletions
diff --git a/src/components/interfaces/HMI_API.xml b/src/components/interfaces/HMI_API.xml index 5730039fdb..5d5a340b1f 100644 --- a/src/components/interfaces/HMI_API.xml +++ b/src/components/interfaces/HMI_API.xml @@ -6342,7 +6342,7 @@ </function> <function name="UnpublishAppService" messagetype="request"> - <description>Unpublish an existing service published by this application.</description> + <description>Unpublish an existing service published by the HMI.</description> <param name="serviceID" type="String" mandatory="true"> <description> The ID of the service to be unpublished. </description> diff --git a/src/components/interfaces/MOBILE_API.xml b/src/components/interfaces/MOBILE_API.xml index 28f8c41d35..1cafb883fa 100644 --- a/src/components/interfaces/MOBILE_API.xml +++ b/src/components/interfaces/MOBILE_API.xml @@ -2645,7 +2645,7 @@ <element name="GetAppServiceDataID" value="53" hexvalue="35" since="5.1" /> <element name="GetFileID" value="54" hexvalue="36" since="5.1" /> <element name="PerformAppServiceInteractionID" value="55" hexvalue="37" since="5.1" /> - <element name="UnpublishAppServiceID" value="56" hexvalue="38" since="5.2" /> + <element name="UnpublishAppServiceID" value="56" hexvalue="38" since="6.0" /> <!-- Base Notifications @@ -7243,7 +7243,7 @@ </param> </function> - <function name="UnpublishAppService" functionID="UnpublishAppServiceID" messagetype="request" since="5.2"> + <function name="UnpublishAppService" functionID="UnpublishAppServiceID" messagetype="request" since="6.0"> <description> Unpublish an existing service published by this application. </description> <param name="serviceID" type="String" mandatory="true"> @@ -7251,7 +7251,7 @@ </param> </function> - <function name="UnpublishAppService" functionID="UnpublishAppServiceID" messagetype="response" since="5.2"> + <function name="UnpublishAppService" functionID="UnpublishAppServiceID" messagetype="response" since="6.0"> <description> The response to UnpublishAppService </description> <param name="success" type="Boolean" platform="documentation" mandatory="true"> <description> true, if successful; false, if failed </description> diff --git a/src/components/policy/policy_external/src/policy_table/enums.cc b/src/components/policy/policy_external/src/policy_table/enums.cc index 4717ea7d6e..bb66892e83 100644 --- a/src/components/policy/policy_external/src/policy_table/enums.cc +++ b/src/components/policy/policy_external/src/policy_table/enums.cc @@ -1160,7 +1160,7 @@ bool EnumFromJsonString(const std::string& literal, FunctionID* result) { } if ("UnpublishAppService" == literal) { - *result = PublishAppServiceID; + *result = UnpublishAppServiceID; return true; } |