diff options
author | jacobkeeler <jacob.keeler@livioradio.com> | 2019-05-23 17:21:16 -0400 |
---|---|---|
committer | jacobkeeler <jacob.keeler@livioradio.com> | 2019-05-23 17:21:16 -0400 |
commit | ae78d836128922dd37eddcd7825c445acaf6b45e (patch) | |
tree | 2b44b6d67f22a925dc59b5dc1c09b5f50bf2c2fd | |
parent | 08725d22256b7f2156ef1172142549325e2619c4 (diff) | |
download | sdl_core-ae78d836128922dd37eddcd7825c445acaf6b45e.tar.gz |
Address review commentshotfix/mobile_notification_broadcasting
3 files changed, 17 insertions, 17 deletions
diff --git a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_command_factory.cc b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_command_factory.cc index 019f8feed9..acfc75a389 100644 --- a/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_command_factory.cc +++ b/src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_command_factory.cc @@ -170,6 +170,9 @@ bool RCCommandFactory::IsAbleToProcess( CommandCreator& RCCommandFactory::get_mobile_command_creator( const mobile_apis::FunctionID::eType id, const mobile_apis::messageType::eType message_type) const { + LOG4CXX_DEBUG(logger_, + "get_mobile_command_creator function_id: " + << id << " message_type: " << message_type); RCCommandCreatorFactory rc_factory(params_); switch (id) { case mobile_apis::FunctionID::ButtonPressID: { @@ -213,9 +216,6 @@ CommandCreator& RCCommandFactory::get_mobile_creator_factory( const mobile_apis::FunctionID::eType id, const mobile_apis::messageType::eType message_type, const app_mngr::commands::Command::CommandSource source) const { - LOG4CXX_DEBUG(logger_, - "CreateMobileCommand function_id: " << id << " message_type: " - << message_type); RCCommandCreatorFactory rc_factory(params_); switch (message_type) { case mobile_apis::messageType::request: { diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/mobile_command_factory.h b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/mobile_command_factory.h index 16c20b10e1..44a4475b62 100644 --- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/mobile_command_factory.h +++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/mobile_command_factory.h @@ -59,16 +59,16 @@ class MobileCommandFactory : public app_mngr::CommandFactory { private: app_mngr::CommandCreator& get_creator_factory( - mobile_apis::FunctionID::eType id, - mobile_apis::messageType::eType message_type, - app_mngr::commands::Command::CommandSource source) const; + const mobile_apis::FunctionID::eType id, + const mobile_apis::messageType::eType message_type, + const app_mngr::commands::Command::CommandSource source) const; app_mngr::CommandCreator& get_command_creator( - mobile_apis::FunctionID::eType id, - mobile_apis::messageType::eType message_type) const; + const mobile_apis::FunctionID::eType id, + const mobile_apis::messageType::eType message_type) const; app_mngr::CommandCreator& get_notification_creator( - mobile_apis::FunctionID::eType id) const; + const mobile_apis::FunctionID::eType id) const; app_mngr::CommandCreator& get_notification_from_mobile_creator( - mobile_apis::FunctionID::eType id) const; + const mobile_apis::FunctionID::eType id) const; app_mngr::ApplicationManager& application_manager_; app_mngr::rpc_service::RPCService& rpc_service_; diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc index 70b5b0fba4..fbbe5183df 100644 --- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc +++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/mobile_command_factory.cc @@ -138,8 +138,8 @@ namespace sdl_rpc_plugin { using namespace application_manager; CommandCreator& MobileCommandFactory::get_command_creator( - mobile_apis::FunctionID::eType id, - mobile_apis::messageType::eType message_type) const { + const mobile_apis::FunctionID::eType id, + const mobile_apis::messageType::eType message_type) const { CommandCreatorFactory factory( application_manager_, rpc_service_, hmi_capabilities_, policy_handler_); switch (id) { @@ -366,7 +366,7 @@ CommandCreator& MobileCommandFactory::get_command_creator( } CommandCreator& MobileCommandFactory::get_notification_creator( - mobile_apis::FunctionID::eType id) const { + const mobile_apis::FunctionID::eType id) const { CommandCreatorFactory factory( application_manager_, rpc_service_, hmi_capabilities_, policy_handler_); switch (id) { @@ -429,7 +429,7 @@ CommandCreator& MobileCommandFactory::get_notification_creator( } CommandCreator& MobileCommandFactory::get_notification_from_mobile_creator( - mobile_apis::FunctionID::eType id) const { + const mobile_apis::FunctionID::eType id) const { CommandCreatorFactory factory( application_manager_, rpc_service_, hmi_capabilities_, policy_handler_); switch (id) { @@ -442,9 +442,9 @@ CommandCreator& MobileCommandFactory::get_notification_from_mobile_creator( } CommandCreator& MobileCommandFactory::get_creator_factory( - mobile_apis::FunctionID::eType id, - mobile_apis::messageType::eType message_type, - app_mngr::commands::Command::CommandSource source) const { + const mobile_apis::FunctionID::eType id, + const mobile_apis::messageType::eType message_type, + const app_mngr::commands::Command::CommandSource source) const { switch (message_type) { case mobile_api::messageType::request: { if (app_mngr::commands::Command::CommandSource::SOURCE_MOBILE == source) { |