diff options
| author | JackLivio <jack@livio.io> | 2018-09-20 17:10:29 -0400 |
|---|---|---|
| committer | JackLivio <jack@livio.io> | 2018-09-20 17:10:29 -0400 |
| commit | 3eb89f8a33c603f7d3bcee5592b62840fb728d34 (patch) | |
| tree | 661f9f13a282c5faa038660ecc1c597ff8f31abf | |
| parent | 7e280a5140278cad627a64844e438bd476fe1866 (diff) | |
| download | sdl_core-3eb89f8a33c603f7d3bcee5592b62840fb728d34.tar.gz | |
Address comments
4 files changed, 8 insertions, 8 deletions
diff --git a/src/components/policy/policy_external/include/policy/policy_table/enums.h b/src/components/policy/policy_external/include/policy/policy_table/enums.h index 82322d442d..34864c5602 100644 --- a/src/components/policy/policy_external/include/policy/policy_table/enums.h +++ b/src/components/policy/policy_external/include/policy/policy_table/enums.h @@ -185,7 +185,7 @@ bool EnumFromJsonString(const std::string& literal, ModuleType* result); * @brief Enumeration FunctionID. * * Enumeration linking function names with function IDs in AppLink protocol. - *Assumes enumeration starts at value 0. + * Assumes enumeration starts at value 0. */ enum FunctionID { /** diff --git a/src/components/policy/policy_external/src/policy_manager_impl.cc b/src/components/policy/policy_external/src/policy_manager_impl.cc index 34d58b5812..e93eea3969 100644 --- a/src/components/policy/policy_external/src/policy_manager_impl.cc +++ b/src/components/policy/policy_external/src/policy_manager_impl.cc @@ -302,7 +302,8 @@ void FilterInvalidRPCParameters(policy_table::RpcParameters& rpc_parameters) { rpc_parameters.hmi_levels.swap(valid_hmi_levels); policy_table::Parameters valid_params; - for (const auto& param : *(rpc_parameters.parameters)) { + const policy_table::Parameters& params = *(rpc_parameters.parameters); + for (const auto& param : params) { if (param.is_valid()) { valid_params.push_back(param); } @@ -312,8 +313,7 @@ void FilterInvalidRPCParameters(policy_table::RpcParameters& rpc_parameters) { /** * @brief FilterInvalidPriorityValues filter notification priorities that are - * not - * present in schema + * not present in schema * @param notifications priorities to filter */ void FilterInvalidPriorityValues( diff --git a/src/components/policy/policy_regular/include/policy/policy_table/enums.h b/src/components/policy/policy_regular/include/policy/policy_table/enums.h index 693d547cb9..1f10db9f6f 100644 --- a/src/components/policy/policy_regular/include/policy/policy_table/enums.h +++ b/src/components/policy/policy_regular/include/policy/policy_table/enums.h @@ -171,7 +171,7 @@ bool EnumFromJsonString(const std::string& literal, ModuleType* result); * @brief Enumeration FunctionID. * * Enumeration linking function names with function IDs in AppLink protocol. - *Assumes enumeration starts at value 0. + * Assumes enumeration starts at value 0. */ enum FunctionID { /** diff --git a/src/components/policy/policy_regular/src/policy_manager_impl.cc b/src/components/policy/policy_regular/src/policy_manager_impl.cc index 6ecf8521ed..a4e21a023c 100644 --- a/src/components/policy/policy_regular/src/policy_manager_impl.cc +++ b/src/components/policy/policy_regular/src/policy_manager_impl.cc @@ -174,7 +174,8 @@ void FilterInvalidRPCParameters(policy_table::RpcParameters& rpc_parameters) { rpc_parameters.hmi_levels.swap(valid_hmi_levels); policy_table::Parameters valid_params; - for (const auto& param : *(rpc_parameters.parameters)) { + const policy_table::Parameters& params = *(rpc_parameters.parameters); + for (const auto& param : params) { if (param.is_valid()) { valid_params.push_back(param); } @@ -184,8 +185,7 @@ void FilterInvalidRPCParameters(policy_table::RpcParameters& rpc_parameters) { /** * @brief FilterInvalidPriorityValues filter notification priorities that are - * not - * present in schema + * not present in schema * @param notifications priorities to filter */ void FilterInvalidPriorityValues( |